From nobody Mon Apr 29 03:32:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1525966554509379.26706985785256; Thu, 10 May 2018 08:35:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 247FE81F07; Thu, 10 May 2018 15:35:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E50F96017D; Thu, 10 May 2018 15:35:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8FB244BB79; Thu, 10 May 2018 15:35:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4AFZnte001562 for ; Thu, 10 May 2018 11:35:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2DC272026E04; Thu, 10 May 2018 15:35:49 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6FC12026DEF for ; Thu, 10 May 2018 15:35:48 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 10 May 2018 17:35:43 +0200 Message-Id: <20180510153545.18176-2-abologna@redhat.com> In-Reply-To: <20180510153545.18176-1-abologna@redhat.com> References: <20180510153545.18176-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 1/3] jobs: Run commands after loading environments X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 10 May 2018 15:35:53 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The contents of either global_env or local_env might affect the behavior of the build, so no command should be executed before loading them both. Signed-off-by: Andrea Bolognani Reviewed-by: Erik Skultety --- jobs/perl-makemaker.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jobs/perl-makemaker.yaml b/jobs/perl-makemaker.yaml index 84b368e..065b38e 100644 --- a/jobs/perl-makemaker.yaml +++ b/jobs/perl-makemaker.yaml @@ -40,9 +40,9 @@ values: '{obj:machines}' builders: - shell: | - perl Makefile.PL PREFIX=3D"$VIRT_PREFIX" {global_env} {local_env} + perl Makefile.PL PREFIX=3D"$VIRT_PREFIX" $MAKE $MAKE -j{smp} install $MAKE -j{smp} manifest --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 03:32:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1525966554604264.6628710739135; Thu, 10 May 2018 08:35:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2739330C4CA6; Thu, 10 May 2018 15:35:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D81A45C57D; Thu, 10 May 2018 15:35:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1CB544BB78; Thu, 10 May 2018 15:35:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4AFZnRZ001570 for ; Thu, 10 May 2018 11:35:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id C35962026E04; Thu, 10 May 2018 15:35:49 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 68B0E2026DEF for ; Thu, 10 May 2018 15:35:49 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 10 May 2018 17:35:44 +0200 Message-Id: <20180510153545.18176-3-abologna@redhat.com> In-Reply-To: <20180510153545.18176-1-abologna@redhat.com> References: <20180510153545.18176-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 2/3] jobs: Use local_env for Perl test arguments X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 10 May 2018 15:35:53 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We're already using this approach for Go tests, the main advantage being that we can use existing facilities instead of defining custom one-use variables. Signed-off-by: Andrea Bolognani Reviewed-by: Erik Skultety --- jobs/perl-makemaker.yaml | 3 +-- projects/libvirt-perl.yaml | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/jobs/perl-makemaker.yaml b/jobs/perl-makemaker.yaml index 065b38e..491b7fa 100644 --- a/jobs/perl-makemaker.yaml +++ b/jobs/perl-makemaker.yaml @@ -58,7 +58,6 @@ name: '{name}-{branch}-test{variant}' project-type: matrix description: '{title} Test' - test_args: '' workspace: '{name}-{branch}{variant}' child-workspace: '.' block-downstream: true @@ -85,7 +84,7 @@ - shell: | {global_env} {local_env} - $MAKE -j{smp} test {test_args} + $MAKE -j{smp} test $TEST_ARGS publishers: - email: recipients: '{obj:spam}' diff --git a/projects/libvirt-perl.yaml b/projects/libvirt-perl.yaml index 0a6f648..165470a 100644 --- a/projects/libvirt-perl.yaml +++ b/projects/libvirt-perl.yaml @@ -8,7 +8,8 @@ parent_jobs: 'libvirt-master-build' - perl-makemaker-test-job: parent_jobs: 'libvirt-perl-master-build' - test_args: 'TEST_MAINTAINER=3D1' + local_env: | + export TEST_ARGS=3D"TEST_MAINTAINER=3D1" - perl-makemaker-rpm-job: parent_jobs: 'libvirt-perl-master-test' machines: '{rpm_machines}' --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 03:32:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1525966562580605.3579600518992; Thu, 10 May 2018 08:36:02 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 93CA330CB953; Thu, 10 May 2018 15:36:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C4C82707A; Thu, 10 May 2018 15:36:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CE7741801241; Thu, 10 May 2018 15:35:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4AFZom2001577 for ; Thu, 10 May 2018 11:35:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 652FE2026993; Thu, 10 May 2018 15:35:50 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0ABC2202698A for ; Thu, 10 May 2018 15:35:49 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 10 May 2018 17:35:45 +0200 Message-Id: <20180510153545.18176-4-abologna@redhat.com> In-Reply-To: <20180510153545.18176-1-abologna@redhat.com> References: <20180510153545.18176-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 3/3] jobs: Use *-check for Perl jobs too X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 10 May 2018 15:36:01 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Perl jobs use the -test suffix instead of -check, which is used everywhere else. Rename them in order to be consistent. Signed-off-by: Andrea Bolognani Reviewed-by: Erik Skultety --- jobs/perl-makemaker.yaml | 6 +++--- jobs/perl-modulebuild.yaml | 6 +++--- projects/libvirt-perl.yaml | 4 ++-- projects/libvirt-tck.yaml | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/jobs/perl-makemaker.yaml b/jobs/perl-makemaker.yaml index 491b7fa..29bf2a1 100644 --- a/jobs/perl-makemaker.yaml +++ b/jobs/perl-makemaker.yaml @@ -54,10 +54,10 @@ =20 =20 - job-template: - id: perl-makemaker-test-job - name: '{name}-{branch}-test{variant}' + id: perl-makemaker-check-job + name: '{name}-{branch}-check{variant}' project-type: matrix - description: '{title} Test' + description: '{title} Check' workspace: '{name}-{branch}{variant}' child-workspace: '.' block-downstream: true diff --git a/jobs/perl-modulebuild.yaml b/jobs/perl-modulebuild.yaml index b159ab3..65c1710 100644 --- a/jobs/perl-modulebuild.yaml +++ b/jobs/perl-modulebuild.yaml @@ -54,10 +54,10 @@ =20 =20 - job-template: - id: perl-modulebuild-test-job - name: '{name}-{branch}-test{variant}' + id: perl-modulebuild-check-job + name: '{name}-{branch}-check{variant}' project-type: matrix - description: '{title} Test' + description: '{title} Check' workspace: '{name}-{branch}{variant}' child-workspace: '.' block-downstream: true diff --git a/projects/libvirt-perl.yaml b/projects/libvirt-perl.yaml index 165470a..8023cfe 100644 --- a/projects/libvirt-perl.yaml +++ b/projects/libvirt-perl.yaml @@ -6,10 +6,10 @@ jobs: - perl-makemaker-build-job: parent_jobs: 'libvirt-master-build' - - perl-makemaker-test-job: + - perl-makemaker-check-job: parent_jobs: 'libvirt-perl-master-build' local_env: | export TEST_ARGS=3D"TEST_MAINTAINER=3D1" - perl-makemaker-rpm-job: - parent_jobs: 'libvirt-perl-master-test' + parent_jobs: 'libvirt-perl-master-check' machines: '{rpm_machines}' diff --git a/projects/libvirt-tck.yaml b/projects/libvirt-tck.yaml index 25b674a..065678d 100644 --- a/projects/libvirt-tck.yaml +++ b/projects/libvirt-tck.yaml @@ -13,10 +13,10 @@ jobs: - perl-modulebuild-build-job: parent_jobs: 'libvirt-perl-master-build' - - perl-modulebuild-test-job: + - perl-modulebuild-check-job: parent_jobs: 'libvirt-tck-master-build' - perl-modulebuild-rpm-job: - parent_jobs: 'libvirt-tck-master-test' + parent_jobs: 'libvirt-tck-master-check' machines: - libvirt-fedora-27 - libvirt-fedora-28 --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list