From nobody Thu Nov 28 10:51:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 152484249645797.21592219813988; Fri, 27 Apr 2018 08:21:36 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E5B51C057F81; Fri, 27 Apr 2018 15:21:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A0BD278A00; Fri, 27 Apr 2018 15:21:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BF8B51805971; Fri, 27 Apr 2018 15:21:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3RFLT02031681 for ; Fri, 27 Apr 2018 11:21:29 -0400 Received: by smtp.corp.redhat.com (Postfix) id 14E1F200BCB2; Fri, 27 Apr 2018 15:21:29 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACC08200BCB7 for ; Fri, 27 Apr 2018 15:21:28 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 27 Apr 2018 17:21:20 +0200 Message-Id: <20180427152123.28666-2-abologna@redhat.com> In-Reply-To: <20180427152123.28666-1-abologna@redhat.com> References: <20180427152123.28666-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/4] tests: Fix virnetsockettest on FreeBSD X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 27 Apr 2018 15:21:35 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" FreeBSD doesn't let IPv4 clients to connect to IPv6 sockets, so one of our test cases has to be compiled out there. Signed-off-by: Andrea Bolognani --- tests/virnetsockettest.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c index 9f9a243484..d39481067e 100644 --- a/tests/virnetsockettest.c +++ b/tests/virnetsockettest.c @@ -470,9 +470,19 @@ mymain(void) if (virTestRun("Socket TCP/IPv4+IPv6 Accept", testSocketTCPAccept,= &tcpData) < 0) ret =3D -1; =20 + /* From FreeBSD's inet6(4): + * + * By default, FreeBSD does not route IPv4 traffic to AF_INET6 + * sockets. The default behavior intentionally violates RFC2553 + * for security reasons. Listen to two sockets if you want to + * accept both IPv4 and IPv6 traffic. + * + * So this test will never work on FreeBSD, and need to skip it. */ +# ifndef __FreeBSD__ tcpData.cnode =3D "::1"; if (virTestRun("Socket TCP/IPv4+IPv6 Accept", testSocketTCPAccept,= &tcpData) < 0) ret =3D -1; +# endif /* __FreeBSD__ */ } #endif =20 --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list