From nobody Wed May 8 11:16:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1524829704493341.68168433505025; Fri, 27 Apr 2018 04:48:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EFF8080F8D; Fri, 27 Apr 2018 11:48:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 795291BDD4; Fri, 27 Apr 2018 11:48:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3EDBD180596E; Fri, 27 Apr 2018 11:48:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3RBmI8M030792 for ; Fri, 27 Apr 2018 07:48:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 042C010EE6E1; Fri, 27 Apr 2018 11:48:18 +0000 (UTC) Received: from katerina.brq.redhat.com (unknown [10.43.2.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B0B610EE6DE for ; Fri, 27 Apr 2018 11:48:15 +0000 (UTC) From: Katerina Koukiou To: libvir-list@redhat.com Date: Fri, 27 Apr 2018 13:48:13 +0200 Message-Id: <20180427114813.18022-1-kkoukiou@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH] Revert "Implement MigrateGetMaxDowntime method for Domain Interface" X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 27 Apr 2018 11:48:22 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This reverts commit d4a4fd4e9e0ab50f473c24192abc34644cd8213e. This API was introduced in libvirt 3.7.0 and no APIs from version > 3.0.0 should be included until next release. Reviewed-by: Pavel Hrdina --- data/org.libvirt.Domain.xml | 6 ------ src/domain.c | 31 ------------------------------- 2 files changed, 37 deletions(-) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index 1cd79f8..6f919da 100644 --- a/data/org.libvirt.Domain.xml +++ b/data/org.libvirt.Domain.xml @@ -332,12 +332,6 @@ - - - - - diff --git a/src/domain.c b/src/domain.c index ec5b99c..06cad6f 100644 --- a/src/domain.c +++ b/src/domain.c @@ -1793,36 +1793,6 @@ virtDBusDomainMigrateGetCompressionCache(GVariant *i= nArgs, *outArgs =3D g_variant_new("(t)", cacheSize); } =20 -static void -virtDBusDomainMigrateGetMaxDowntime(GVariant *inArgs, - GUnixFDList *inFDs G_GNUC_UNUSED, - const gchar *objectPath, - gpointer userData, - GVariant **outArgs, - GUnixFDList **outFDs G_GNUC_UNUSED, - GError **error) -{ - virtDBusConnect *connect =3D userData; - g_autoptr(virDomain) domain =3D NULL; - gulong downtime; - guint flags; - gint ret; - - g_variant_get(inArgs, "(u)", &flags); - - domain =3D virtDBusDomainGetVirDomain(connect, objectPath, error); - if (!domain) - return; - - ret =3D virDomainMigrateGetMaxDowntime(domain, - (unsigned long long *)&downtime, - flags); - if (ret < 0) - return virtDBusUtilSetLastVirtError(error); - - *outArgs =3D g_variant_new("(t)", downtime); -} - static void virtDBusDomainMigrateGetMaxSpeed(GVariant *inArgs, GUnixFDList *inFDs G_GNUC_UNUSED, @@ -2669,7 +2639,6 @@ static virtDBusGDBusMethodTable virtDBusDomainMethodT= able[] =3D { { "MemoryPeek", virtDBusDomainMemoryPeek }, { "MemoryStats", virtDBusDomainMemoryStats }, { "MigrateGetCompressionCache", virtDBusDomainMigrateGetCompressionCac= he }, - { "MigrateGetMaxDowntime", virtDBusDomainMigrateGetMaxDowntime }, { "MigrateGetMaxSpeed", virtDBusDomainMigrateGetMaxSpeed }, { "MigrateSetCompressionCache", virtDBusDomainMigrateSetCompressionCac= he }, { "MigrateSetMaxDowntime", virtDBusDomainMigrateSetMaxDowntime }, --=20 2.15.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list