From nobody Sun Feb 8 16:24:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1524573070201518.6035164071079; Tue, 24 Apr 2018 05:31:10 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5597580F9E; Tue, 24 Apr 2018 12:31:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ABADE6A051; Tue, 24 Apr 2018 12:31:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E18F8B348D; Tue, 24 Apr 2018 12:31:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3OCSJ1b014684 for ; Tue, 24 Apr 2018 08:28:19 -0400 Received: by smtp.corp.redhat.com (Postfix) id 80F745D781; Tue, 24 Apr 2018 12:28:19 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-64.phx2.redhat.com [10.3.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4046A61559 for ; Tue, 24 Apr 2018 12:28:18 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 24 Apr 2018 08:28:08 -0400 Message-Id: <20180424122809.12534-6-jferlan@redhat.com> In-Reply-To: <20180424122809.12534-1-jferlan@redhat.com> References: <20180424122809.12534-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 5/6] libxl: Add refcnt for args->conn during migration X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 24 Apr 2018 12:31:09 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since the @dconn reference via args->conn will be used via a thread or callback, let's make sure memory associated with it isn't free'd unexpectedly before we use it. The Unref will be done when the object is Dispose'd. Signed-off-by: John Ferlan Reviewed-by: Erik Skultety Reviewed-by: Marc Hartmayer --- src/libxl/libxl_migration.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index 7fe352306c..d37a4a687a 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -239,6 +239,7 @@ libxlMigrationDstArgsDispose(void *obj) =20 libxlMigrationCookieFree(args->migcookie); VIR_FREE(args->socks); + virObjectUnref(args->conn); virObjectUnref(args->vm); } =20 @@ -608,7 +609,7 @@ libxlDomainMigrationDstPrepareTunnel3(virConnectPtr dco= nn, if (!(args =3D virObjectNew(libxlMigrationDstArgsClass))) goto error; =20 - args->conn =3D dconn; + args->conn =3D virObjectRef(dconn); args->vm =3D virObjectRef(vm); args->flags =3D flags; args->migcookie =3D mig; @@ -763,7 +764,7 @@ libxlDomainMigrationDstPrepare(virConnectPtr dconn, if (!(args =3D virObjectNew(libxlMigrationDstArgsClass))) goto error; =20 - args->conn =3D dconn; + args->conn =3D virObjectRef(dconn); args->vm =3D virObjectRef(vm); args->flags =3D flags; args->socks =3D socks; --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list