From nobody Fri Apr 26 10:20:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1523781517217629.7120007676175; Sun, 15 Apr 2018 01:38:37 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F2E8C3004854; Sun, 15 Apr 2018 08:38:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A552B17AC0; Sun, 15 Apr 2018 08:38:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3A924180BAF4; Sun, 15 Apr 2018 08:38:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3CFON1f019380 for ; Thu, 12 Apr 2018 11:24:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id 35998D7E19; Thu, 12 Apr 2018 15:24:23 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 726E6D7E05; Thu, 12 Apr 2018 15:24:20 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Thu, 12 Apr 2018 16:24:18 +0100 Message-Id: <20180412152418.2975-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] acl: remove various left over Xen ACL whitelist entries X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Sun, 15 Apr 2018 08:38:36 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 The legacy xen driver is removed, so these ACLL hacks can be removed too now. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=EF=BF=BDn Tomko --- src/check-aclrules.pl | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/src/check-aclrules.pl b/src/check-aclrules.pl index 5b6c711dc8..374abaa722 100755 --- a/src/check-aclrules.pl +++ b/src/check-aclrules.pl @@ -61,26 +61,12 @@ my %whitelist =3D ( "interfaceClose" =3D> 1, ); =20 -# Temp hack - remove it once xen driver is fixed +# XXX this vzDomainMigrateConfirm3Params looks +# bogus - determine why it doesn't have a valid +# ACL check. my %implwhitelist =3D ( - "xenUnifiedDomainRestore" =3D> 1, - "xenUnifiedDomainRestoreFlags" =3D> 1, - "xenUnifiedDomainMigratePrepare" =3D> 1, - "xenUnifiedNodeDeviceDettach" =3D> 1, - "xenUnifiedNodeDeviceDetachFlags" =3D> 1, - "xenUnifiedNodeDeviceReset" =3D> 1, - "xenUnifiedDomainIsActive" =3D> 1, - "xenUnifiedDomainIsPersistent" =3D> 1, - "xenUnifiedDomainIsUpdated" =3D> 1, - "xenUnifiedDomainOpenConsole" =3D> 1, "vzDomainMigrateConfirm3Params" =3D> 1, ); -my %filterimplwhitelist =3D ( - "xenUnifiedConnectListDomains" =3D> 1, - "xenUnifiedConnectNumOfDomains" =3D> 1, - "xenUnifiedConnectListDefinedDomains" =3D> 1, - "xenUnifiedConnectNumOfDefinedDomains" =3D> 1, - ); =20 my $lastfile; =20 @@ -234,8 +220,7 @@ while (<>) { } =20 if (exists $filtered{$api} && - !exists $aclfilters{$impl} && - !exists $filterimplwhitelist{$impl}) { + !exists $aclfilters{$impl}) { print "$ARGV:$. Missing ACL filter in function '$impl' for= '$api'\n"; $status =3D 1; } --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list