From nobody Sun Apr 28 07:31:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1521542570637803.0847685608711; Tue, 20 Mar 2018 03:42:50 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0509356CB; Tue, 20 Mar 2018 10:42:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA948600C2; Tue, 20 Mar 2018 10:42:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6FE164CA99; Tue, 20 Mar 2018 10:42:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2KAgiMT007656 for ; Tue, 20 Mar 2018 06:42:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 850B57C50; Tue, 20 Mar 2018 10:42:44 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B9C37C51 for ; Tue, 20 Mar 2018 10:42:41 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 20 Mar 2018 11:42:38 +0100 Message-Id: <20180320104238.20255-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] mingw: Require Fedora X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 20 Mar 2018 10:42:49 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Although it was never formally specified, it was always expected that the mingw RPM build would happen on Fedora, if anything because RHEL / CentOS don't ship the necessary mingw dependencies. Make this fact explicit by erroring out if that's not the case, the same way we already do in the main spec file. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- mingw-libvirt.spec.in | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index 5e12bb1cae..8f3f26d2d9 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -1,5 +1,16 @@ %{?mingw_package_header} =20 +# This spec file assumes you are building on a Fedora version +# that's still supported by the vendor. It may work on other distros +# or versions, but no effort will be made to ensure that going forward. +%define min_fedora 26 + +%if 0%{?fedora} && 0%{?fedora} >=3D %{min_fedora} + %define supported_platform 1 +%else + %define supported_platform 0 +%endif + # Default to skipping autoreconf. Distros can change just this one line # (or provide a command-line override) if they backport any patches that # touch configure.ac or Makefile.am. @@ -124,6 +135,11 @@ MinGW Windows libvirt virtualization library, static v= ersion. %setup -q -n libvirt-%{version} =20 %build +%if ! %{supported_platform} +echo "This RPM requires Fedora >=3D %{min_fedora}" +exit 1 +%endif + %if ! %{with_phyp} %define _without_phyp --without-phyp %endif --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list