[libvirt] [PATCH v2] spec: Drop polkit-devel from BuildRequires

Andrea Bolognani posted 1 patch 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20180315112617.26738-1-abologna@redhat.com
Test syntax-check passed
libvirt.spec.in | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[libvirt] [PATCH v2] spec: Drop polkit-devel from BuildRequires
Posted by Andrea Bolognani 6 years ago
As of 2499d1a09508 we don't link against libpolkit anymore, so
we only need the polkit package to be available during build.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 5e05d706f8..8e9836ebbd 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -358,11 +358,9 @@ BuildRequires: ebtables
 BuildRequires: module-init-tools
 BuildRequires: cyrus-sasl-devel
 %if 0%{?fedora} || 0%{?rhel} >= 7
-# F22 polkit-devel doesn't pull in polkit anymore, which we need for pkcheck
 BuildRequires: polkit >= 0.112
-BuildRequires: polkit-devel >= 0.112
 %else
-BuildRequires: polkit-devel >= 0.93
+BuildRequires: polkit >= 0.93
 %endif
 # For mount/umount in FS driver
 BuildRequires: util-linux
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] spec: Drop polkit-devel from BuildRequires
Posted by Daniel P. Berrangé 6 years ago
On Thu, Mar 15, 2018 at 12:26:17PM +0100, Andrea Bolognani wrote:
> As of 2499d1a09508 we don't link against libpolkit anymore, so
> we only need the polkit package to be available during build.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  libvirt.spec.in | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 5e05d706f8..8e9836ebbd 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -358,11 +358,9 @@ BuildRequires: ebtables
>  BuildRequires: module-init-tools
>  BuildRequires: cyrus-sasl-devel
>  %if 0%{?fedora} || 0%{?rhel} >= 7
> -# F22 polkit-devel doesn't pull in polkit anymore, which we need for pkcheck
>  BuildRequires: polkit >= 0.112
> -BuildRequires: polkit-devel >= 0.112
>  %else
> -BuildRequires: polkit-devel >= 0.93
> +BuildRequires: polkit >= 0.93
>  %endif
>  # For mount/umount in FS driver
>  BuildRequires: util-linux

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list