[libvirt] [PATCH RFCv2 0/4] Add optional pSeries features

Andrea Bolognani posted 4 patches 6 years, 1 month ago
Failed in applying to current master (apply log)
There is a newer version of this series
docs/schemas/domaincommon.rng                      |  30 ++++
src/conf/domain_conf.c                             |  74 +++++++++
src/conf/domain_conf.h                             |  15 ++
src/libvirt_private.syms                           |   2 +
src/qemu/qemu_capabilities.c                       |  17 +++
src/qemu/qemu_capabilities.h                       |   6 +
src/qemu/qemu_command.c                            | 165 +++++++++++++++++++++
src/qemu/qemu_domain.c                             |  22 +++
tests/qemuxml2argvdata/pseries-features-cfpc.args  |  19 +++
tests/qemuxml2argvdata/pseries-features-cfpc.xml   |  28 ++++
tests/qemuxml2argvdata/pseries-features-htm.args   |  19 +++
tests/qemuxml2argvdata/pseries-features-htm.xml    |  28 ++++
tests/qemuxml2argvdata/pseries-features-ibs.args   |  19 +++
tests/qemuxml2argvdata/pseries-features-ibs.xml    |  28 ++++
.../pseries-features-invalid-machine.xml           |   1 +
tests/qemuxml2argvdata/pseries-features-sbbc.args  |  19 +++
tests/qemuxml2argvdata/pseries-features-sbbc.xml   |  28 ++++
tests/qemuxml2argvtest.c                           |  20 +++
tests/qemuxml2xmloutdata/pseries-features-cfpc.xml |   1 +
tests/qemuxml2xmloutdata/pseries-features-htm.xml  |   1 +
tests/qemuxml2xmloutdata/pseries-features-ibs.xml  |   1 +
tests/qemuxml2xmloutdata/pseries-features-sbbc.xml |   1 +
tests/qemuxml2xmltest.c                            |  12 ++
23 files changed, 556 insertions(+)
create mode 100644 tests/qemuxml2argvdata/pseries-features-cfpc.args
create mode 100644 tests/qemuxml2argvdata/pseries-features-cfpc.xml
create mode 100644 tests/qemuxml2argvdata/pseries-features-htm.args
create mode 100644 tests/qemuxml2argvdata/pseries-features-htm.xml
create mode 100644 tests/qemuxml2argvdata/pseries-features-ibs.args
create mode 100644 tests/qemuxml2argvdata/pseries-features-ibs.xml
create mode 100644 tests/qemuxml2argvdata/pseries-features-sbbc.args
create mode 100644 tests/qemuxml2argvdata/pseries-features-sbbc.xml
create mode 120000 tests/qemuxml2xmloutdata/pseries-features-cfpc.xml
create mode 120000 tests/qemuxml2xmloutdata/pseries-features-htm.xml
create mode 120000 tests/qemuxml2xmloutdata/pseries-features-ibs.xml
create mode 120000 tests/qemuxml2xmloutdata/pseries-features-sbbc.xml
[libvirt] [PATCH RFCv2 0/4] Add optional pSeries features
Posted by Andrea Bolognani 6 years, 1 month ago
Applies on top of [req].

RFC because we still don't have a way of probing QEMU to figure
out whether the relevant toggles are available. Plus, there's no
documentation yet :)


Changes from [RFCv1]:

* don't nest features inside a <pseries/> element;

* implement all optional features.


[req] https://www.redhat.com/archives/libvir-list/2018-February/msg00298.html
[RFCv1] https://www.redhat.com/archives/libvir-list/2018-January/msg00779.html

Andrea Bolognani (4):
  qemu: Implement the HTM pSeries feature
  qemu: Implement the SBBC pSeries feature
  qemu: Implement the CFPC pSeries feature
  qemu: Implement the IBS pSeries feature

 docs/schemas/domaincommon.rng                      |  30 ++++
 src/conf/domain_conf.c                             |  74 +++++++++
 src/conf/domain_conf.h                             |  15 ++
 src/libvirt_private.syms                           |   2 +
 src/qemu/qemu_capabilities.c                       |  17 +++
 src/qemu/qemu_capabilities.h                       |   6 +
 src/qemu/qemu_command.c                            | 165 +++++++++++++++++++++
 src/qemu/qemu_domain.c                             |  22 +++
 tests/qemuxml2argvdata/pseries-features-cfpc.args  |  19 +++
 tests/qemuxml2argvdata/pseries-features-cfpc.xml   |  28 ++++
 tests/qemuxml2argvdata/pseries-features-htm.args   |  19 +++
 tests/qemuxml2argvdata/pseries-features-htm.xml    |  28 ++++
 tests/qemuxml2argvdata/pseries-features-ibs.args   |  19 +++
 tests/qemuxml2argvdata/pseries-features-ibs.xml    |  28 ++++
 .../pseries-features-invalid-machine.xml           |   1 +
 tests/qemuxml2argvdata/pseries-features-sbbc.args  |  19 +++
 tests/qemuxml2argvdata/pseries-features-sbbc.xml   |  28 ++++
 tests/qemuxml2argvtest.c                           |  20 +++
 tests/qemuxml2xmloutdata/pseries-features-cfpc.xml |   1 +
 tests/qemuxml2xmloutdata/pseries-features-htm.xml  |   1 +
 tests/qemuxml2xmloutdata/pseries-features-ibs.xml  |   1 +
 tests/qemuxml2xmloutdata/pseries-features-sbbc.xml |   1 +
 tests/qemuxml2xmltest.c                            |  12 ++
 23 files changed, 556 insertions(+)
 create mode 100644 tests/qemuxml2argvdata/pseries-features-cfpc.args
 create mode 100644 tests/qemuxml2argvdata/pseries-features-cfpc.xml
 create mode 100644 tests/qemuxml2argvdata/pseries-features-htm.args
 create mode 100644 tests/qemuxml2argvdata/pseries-features-htm.xml
 create mode 100644 tests/qemuxml2argvdata/pseries-features-ibs.args
 create mode 100644 tests/qemuxml2argvdata/pseries-features-ibs.xml
 create mode 100644 tests/qemuxml2argvdata/pseries-features-sbbc.args
 create mode 100644 tests/qemuxml2argvdata/pseries-features-sbbc.xml
 create mode 120000 tests/qemuxml2xmloutdata/pseries-features-cfpc.xml
 create mode 120000 tests/qemuxml2xmloutdata/pseries-features-htm.xml
 create mode 120000 tests/qemuxml2xmloutdata/pseries-features-ibs.xml
 create mode 120000 tests/qemuxml2xmloutdata/pseries-features-sbbc.xml

-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH RFCv2 0/4] Add optional pSeries features
Posted by Peter Krempa 6 years, 1 month ago
On Tue, Feb 06, 2018 at 17:54:55 +0100, Andrea Bolognani wrote:
> Applies on top of [req].
> 
> RFC because we still don't have a way of probing QEMU to figure
> out whether the relevant toggles are available. Plus, there's no
> documentation yet :)

I wanted to moan about missing docs and sub-par commit messages but
okay. Note that without documentation it's not possible to scrunitize
whether it makes any particular sense to expose a given feature at all.

Since probing is not implemented I don't think it makes sense to
introduce cabapility bits for every single feature since they are
grouped under the same version check.

Even if qemu adds QMP probing of these the capability check will not go
away since it would create a regression in behaviour. This means that
you can remove all the capability bits and group all of them under a
single one since they will only ever be enabled using that version
check.

Also I really don't think that every single feature should have it's own
XML document to test it. You can gradually add them to a single one and
test that all are added.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH RFCv2 0/4] Add optional pSeries features
Posted by Andrea Bolognani 6 years, 1 month ago
On Tue, 2018-02-06 at 21:25 +0100, Peter Krempa wrote:
> On Tue, Feb 06, 2018 at 17:54:55 +0100, Andrea Bolognani wrote:
> > Applies on top of [req].
> > 
> > RFC because we still don't have a way of probing QEMU to figure
> > out whether the relevant toggles are available. Plus, there's no
> > documentation yet :)
> 
> I wanted to moan about missing docs and sub-par commit messages but
> okay. Note that without documentation it's not possible to scrunitize
> whether it makes any particular sense to expose a given feature at all.

See https://bugzilla.redhat.com/show_bug.cgi?id=1525599#c4 for a
rationale on having the toggles. The previous comment lists all
QEMU-level toggles, and as you can see we're not implementing
either VSX or DFP because they don't have a clear use case.

> Since probing is not implemented I don't think it makes sense to
> introduce cabapility bits for every single feature since they are
> grouped under the same version check.
> 
> Even if qemu adds QMP probing of these the capability check will not go
> away since it would create a regression in behaviour. This means that
> you can remove all the capability bits and group all of them under a
> single one since they will only ever be enabled using that version
> check.

The capabilities have been introduced during the 2.12 development
cycle, so assuming QMP probing makes it into that release we should
definitely use that instead of performing a version check. If it
doesn't then yeah, a version check will probably be better in order
not to artificially block perfectly good QEMU binaries from using
the capabilites. It would still not be a regression, though.

> Also I really don't think that every single feature should have it's own
> XML document to test it. You can gradually add them to a single one and
> test that all are added.

Good point, I'll merge them.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list