From nobody Tue Feb 10 11:56:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1516038753496303.0897864805281; Mon, 15 Jan 2018 09:52:33 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1FFA1BDCC; Mon, 15 Jan 2018 17:52:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B60E608F4; Mon, 15 Jan 2018 17:52:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D9921410B5; Mon, 15 Jan 2018 17:52:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w0FHojgT030326 for ; Mon, 15 Jan 2018 12:50:45 -0500 Received: by smtp.corp.redhat.com (Postfix) id DF66117C3A; Mon, 15 Jan 2018 17:50:45 +0000 (UTC) Received: from mx1.redhat.com (ext-mx05.extmail.prod.ext.phx2.redhat.com [10.5.110.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8AF55C7DD for ; Mon, 15 Jan 2018 17:50:26 +0000 (UTC) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A4E52D1EC7 for ; Mon, 15 Jan 2018 17:50:16 +0000 (UTC) Received: by mail-lf0-f65.google.com with SMTP id h137so14305226lfe.8 for ; Mon, 15 Jan 2018 09:50:16 -0800 (PST) Received: from localhost.localdomain (mobile-user-c1d2e2-152.dhcp.inet.fi. [193.210.226.152]) by smtp.gmail.com with ESMTPSA id o26sm32827ljc.26.2018.01.15.09.50.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 09:50:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id; bh=X6Cp5s8+PG4gaI/KrA006/RiNzRGK8fMZJ8hsmx1DCc=; b=FgBO1a5itH52CrjO3q0CvgqmC9HNJilX+bl87TiRaL/mE67FLq3Mk+lY25paGbGbg2 3AsS823AameVV+VnawY607ed654r8ZULtgk1kyc08mlVXqpGvEglTmDjnl1K9A7JRCPx b8tucrRK/peeWxKYQmhqQKahlks097k3l9HWdFMZnpQbDcF6uNPNYrVq2GcjyXod+vZo bv6whAqjDuHO4fBPuKW2l0kDh3RGfR9JJzjBfCnp6RhDB6ARXbdpGEdn2a4rT6UhA6YA lL4VJNPecXo8AOv+fwGR0xw/gv6rtwfzq8pybhfdD+KNVQljm2BEuai+aMPCfznHtQeS znfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=X6Cp5s8+PG4gaI/KrA006/RiNzRGK8fMZJ8hsmx1DCc=; b=P+wxGm7UJYF9rxCkDt5EzdRsvdLXMfbNzhPVCik260F8F4mWEz9n2Bv1KgG/vAO4CS wlCgWcm2DaqlDlJEOcQ39wQmUG9Cr4RLMUHsko97FWQTNiN19mYk0qvdpJd8fbNP45I8 2RqQKX6YQ/Sv8yJBvhEl4UBuyfHImMI1eygw67mhfMv9cI0Qu7S09u6P/oSr1FUEZQqn 5G8ebkfq39Bsxg8s+1V2mNNQsDryIPO97qo18eO6P4mix/M/gjlwmW9kF69rfrHpGWMl ilVyteXbexoF5sQFgXIaCCm6s2IN1bqEG0KkuNw2LA9zcbG5bKPqDkLiEknZch2UooFU 4oUA== X-Gm-Message-State: AKwxytd5oT1dri+VGOtEoyhh/mxW4ANIw83KSQhEBetsQJKdnoUn8o53 RGtFtqFKXY+UDQBSubJxk3/EPeY5 X-Google-Smtp-Source: ACJfBotX4/+Ra5hmcg4bF7S9mNnc9MUKCwCWv2yU109Ypaw385phLHRhq0/YkW3FSTaQox8j8PXnCA== X-Received: by 10.25.19.220 with SMTP id 89mr8896244lft.57.1516038614225; Mon, 15 Jan 2018 09:50:14 -0800 (PST) From: =?UTF-8?q?Ville=20Skytt=C3=A4?= To: libvir-list@redhat.com Date: Mon, 15 Jan 2018 19:50:10 +0200 Message-Id: <20180115175010.6385-1-ville.skytta@iki.fi> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 15 Jan 2018 17:50:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 15 Jan 2018 17:50:16 +0000 (UTC) for IP:'209.85.215.65' DOMAIN:'mail-lf0-f65.google.com' HELO:'mail-lf0-f65.google.com' FROM:'vskytta@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.471 (DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL) 209.85.215.65 mail-lf0-f65.google.com 209.85.215.65 mail-lf0-f65.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.29 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH perl] block_stats: Fix rd_req and wr_req compat hash keys X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 15 Jan 2018 17:52:32 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" When virDomainBlockStatsFlags with NULL params fails, the returned read and write requests hash keys are said to be backwards compatible with the key names success case. However, they were rd_reqs and wr_reqs (in plural) as opposed to the success case's rd_req and wr_req. There is also a similar flush_reqs key, but that one does not have a corresponding value in the success case's hash, so it is left unmodified here. --- Virt.xs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Virt.xs b/Virt.xs index c47b915..a6f0477 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5611,9 +5611,9 @@ block_stats(dom, path, flags=3D0) field =3D NULL; /* For back compat with previous hash above */ if (strcmp(params[i].field, "rd_operations") =3D=3D 0) - field =3D "rd_reqs"; + field =3D "rd_req"; else if (strcmp(params[i].field, "wr_operations") =3D=3D 0) - field =3D "wr_reqs"; + field =3D "wr_req"; else if (strcmp(params[i].field, "flush_operations") =3D=3D = 0) field =3D "flush_reqs"; if (field) { --=20 2.14.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list