From nobody Mon Apr 29 03:24:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 151085240858331.899073395790424; Thu, 16 Nov 2017 09:13:28 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1D558E14BA; Thu, 16 Nov 2017 17:13:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C8B85D9C9; Thu, 16 Nov 2017 17:13:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 443373D380; Thu, 16 Nov 2017 17:13:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vAGHDOMp014661 for ; Thu, 16 Nov 2017 12:13:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6052646E64; Thu, 16 Nov 2017 17:13:24 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D77D146E6A for ; Thu, 16 Nov 2017 17:13:23 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 16 Nov 2017 18:12:54 +0100 Message-Id: <20171116171256.32426-2-abologna@redhat.com> In-Reply-To: <20171116171256.32426-1-abologna@redhat.com> References: <20171116171256.32426-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [cim PATCH 1/3] autogen: Better error handling X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 16 Nov 2017 17:13:27 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Instead of making the execution of each command dependend on the success of the previous one, check return values explicitly. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrange --- autogen.sh | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/autogen.sh b/autogen.sh index e4b7adc..5b2e4dc 100755 --- a/autogen.sh +++ b/autogen.sh @@ -2,20 +2,26 @@ # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D # (C) Copyright IBM Corp. 2005 =20 -echo "Running libtool ..." && -libtoolize --copy --force --automake && +die() +{ + test "$1" && echo "$1" >&2 + exit 1 +} =20 -echo "Running aclocal ..." && -aclocal --force && +echo "Running libtool ..." +libtoolize --copy --force --automake || die =20 -echo "Running autoheader ..." && -autoheader --force && +echo "Running aclocal ..." +aclocal --force || die =20 -echo "Running automake ..." && -automake -i --add-missing --copy --foreign && +echo "Running autoheader ..." +autoheader --force || die =20 -echo "Running autoconf ..." && -autoconf --force && +echo "Running automake ..." +automake -i --add-missing --copy --foreign || die + +echo "Running autoconf ..." +autoconf --force || die =20 if test -x $(which git); then git rev-parse --short HEAD > .changeset --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 03:24:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1510852468693668.1512097063422; Thu, 16 Nov 2017 09:14:28 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 86D11E3143; Thu, 16 Nov 2017 17:14:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5EE975C888; Thu, 16 Nov 2017 17:14:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 29C183D380; Thu, 16 Nov 2017 17:14:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vAGHDQQw014802 for ; Thu, 16 Nov 2017 12:13:26 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1523546E68; Thu, 16 Nov 2017 17:13:26 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8DFFE46E64 for ; Thu, 16 Nov 2017 17:13:25 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 16 Nov 2017 18:12:55 +0100 Message-Id: <20171116171256.32426-3-abologna@redhat.com> In-Reply-To: <20171116171256.32426-1-abologna@redhat.com> References: <20171116171256.32426-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [cim PATCH 2/3] autogen: Run configure automatically X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 16 Nov 2017 17:14:27 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This is in line with pretty much all libvirt-related projects, is entirely compatible with the old behavior and will enable some simplifications in the CI setup. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrange --- autogen.sh | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index 5b2e4dc..a04e4e6 100755 --- a/autogen.sh +++ b/autogen.sh @@ -31,4 +31,14 @@ else echo "0" > .revision fi =20 -echo "You may now run ./configure" +if test "$#" -eq 0; then + echo "Running configure without arguments ..." + echo "(If you want to pass any, specify them on the $0 command line)" +else + echo "Running configure with $@ ..." +fi + +"$srcdir/configure" "$@" || die + +echo +echo "You may now run make" --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon Apr 29 03:24:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1510852471602970.3611991203016; Thu, 16 Nov 2017 09:14:31 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 29027C047B8E; Thu, 16 Nov 2017 17:14:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 041A55C2E6; Thu, 16 Nov 2017 17:14:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BE4F53D383; Thu, 16 Nov 2017 17:14:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vAGHDQqN015099 for ; Thu, 16 Nov 2017 12:13:26 -0500 Received: by smtp.corp.redhat.com (Postfix) id DA7E346E64; Thu, 16 Nov 2017 17:13:26 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6166D46E6A for ; Thu, 16 Nov 2017 17:13:26 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 16 Nov 2017 18:12:56 +0100 Message-Id: <20171116171256.32426-4-abologna@redhat.com> In-Reply-To: <20171116171256.32426-1-abologna@redhat.com> References: <20171116171256.32426-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [cim PATCH 3/3] autogen: Support running out-of-tree X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 16 Nov 2017 17:14:30 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Instead of having to run autogen.sh inside the source directory first, before moving to a build directory and run configure there, it's now possible to run everything from the build directory. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrange --- autogen.sh | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/autogen.sh b/autogen.sh index a04e4e6..ebe6fe2 100755 --- a/autogen.sh +++ b/autogen.sh @@ -8,6 +8,14 @@ die() exit 1 } =20 +curdir=3D$(pwd) +test "$curdir" || curdir=3D. + +srcdir=3D$(dirname "$0") +test "$srcdir" || srcdir=3D. + +cd "$srcdir" || die "Failed to cd into $srcdir" + echo "Running libtool ..." libtoolize --copy --force --automake || die =20 @@ -31,6 +39,8 @@ else echo "0" > .revision fi =20 +cd "$curdir" || die "Failed to cd into $curdir" + if test "$#" -eq 0; then echo "Running configure without arguments ..." echo "(If you want to pass any, specify them on the $0 command line)" --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list