From nobody Mon Feb 9 14:38:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1508873766730549.5192968780243; Tue, 24 Oct 2017 12:36:06 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB2F87E421; Tue, 24 Oct 2017 19:36:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB53418006; Tue, 24 Oct 2017 19:36:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 913D8180610F; Tue, 24 Oct 2017 19:36:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9OJZiTS009684 for ; Tue, 24 Oct 2017 15:35:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5B00B60A9D; Tue, 24 Oct 2017 19:35:44 +0000 (UTC) Received: from mx1.redhat.com (ext-mx05.extmail.prod.ext.phx2.redhat.com [10.5.110.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5456E6BF69 for ; Tue, 24 Oct 2017 19:35:41 +0000 (UTC) Received: from mail-qk0-f196.google.com (mail-qk0-f196.google.com [209.85.220.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF5DA2D1EC7 for ; Tue, 24 Oct 2017 19:35:40 +0000 (UTC) Received: by mail-qk0-f196.google.com with SMTP id m189so27718984qke.4 for ; Tue, 24 Oct 2017 12:35:40 -0700 (PDT) Received: from dawid-fedora.datto.lan ([47.19.105.250]) by smtp.gmail.com with ESMTPSA id f66sm683127qkc.25.2017.10.24.12.35.39 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 12:35:39 -0700 (PDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EB2F87E421 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=datto.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EB2F87E421 Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=datto-com.20150623.gappssmtp.com header.i=@datto-com.20150623.gappssmtp.com header.b="fbnJ+2Kq" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AF5DA2D1EC7 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=datto.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dzamirski@datto.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com AF5DA2D1EC7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datto-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=oOuqmOq7OFdv9bd4ODZ5pMv2bLwftrvxe9d1zkHozKY=; b=fbnJ+2KqPMiaqGy6djubgO0ZEuCNJSURljtc7suTofrJoH7KlJU9UZx1flPcAoK2lP R47Y4dmlfFQxMdahsvBf/+3OTYcK5AkJt8cs2CG90JvUeSYJrfhZGwfPqCSWAi3CfORt okyHaRf1AG5o3MzXhcPMBgGsg9kvlBDHNIsUnZJARn37vjZBvFKvm0igLizinmpU/X7R N1Sn3Xd0DlcFuw+IuQc/6BOT5jNsL8lY/+l0gFnwRZZifhtMNZNEgqdWr9P20/AVgmwQ bxuUacfbTRsE+SQx0T5n39+K52XKnq2pNOipaeGoFVhPeyuAwqqeEi5aKOQa9I979XkK +0dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=oOuqmOq7OFdv9bd4ODZ5pMv2bLwftrvxe9d1zkHozKY=; b=kYtUlyfv+Fe4djUJVweUv/qNoOqKlwfaMOHcjvetl9SYLWQ6WqJZz3gHe8G9qZn6/m gN9z/jemYZtAvHte9lRAh5+rPAeAiJIrGonzEvFjzR5vhJnFJRf9QyK/UiZVlDSoCb+D Y5c+d+iZaD2BI58AzwqxcoLUXHoSqNZCygOjzpgaktXOOwdoymqbgg8GRawCsVY5YJPN 624iMjha4xLDGfLaUrcnqOJQCVKppoC81zi4gEZSS2EfAI9/WNHMaDBYISaSY7WY32sp 1/pK7y+SMgaDUZEhkV6+5Ry0yGi+yuxLbR2Uf1Ni61fQ/+HIxqz28dI5eOTzUBrHG/R6 P7Kg== X-Gm-Message-State: AMCzsaXuqQJwRgL8XKDkQJ5BYsRlW4UNGoSArsyKkQGMHj8QnF/Y4LsW kRFJylCd0eahu7V/7fKyHf0cwiC2iws= X-Google-Smtp-Source: ABhQp+SIpdYf/mD+85OMVLKVy/5o84mPmmTm3BtSZRVUxTZZBKWfROtnNdfqpRmgQhIDbVYE+r/4eA== X-Received: by 10.55.52.148 with SMTP id b142mr17108388qka.116.1508873739738; Tue, 24 Oct 2017 12:35:39 -0700 (PDT) From: Dawid Zamirski To: libvir-list@redhat.com Date: Tue, 24 Oct 2017 15:35:24 -0400 Message-Id: <20171024193538.9078-2-dzamirski@datto.com> In-Reply-To: <20171024193538.9078-1-dzamirski@datto.com> References: <20171024193538.9078-1-dzamirski@datto.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 24 Oct 2017 19:35:40 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 24 Oct 2017 19:35:40 +0000 (UTC) for IP:'209.85.220.196' DOMAIN:'mail-qk0-f196.google.com' HELO:'mail-qk0-f196.google.com' FROM:'dzamirski@datto.com' RCPT:'' X-RedHat-Spam-Score: 0.469 (DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, SPF_PASS) 209.85.220.196 mail-qk0-f196.google.com 209.85.220.196 mail-qk0-f196.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.29 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 01/15] vbox: Update ATTRIBUTE_UNUSED usage X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 24 Oct 2017 19:36:05 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since the removal of VBOX <=3D 3x, the function arguments are actually used so they should not be marked with ATTRIBUTE_UNUSED anymore. Reviewed-by: John Ferlan --- src/vbox/vbox_tmpl.c | 49 +++++++++++++++++++++++-------------------------- 1 file changed, 23 insertions(+), 26 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index dffeabde0..4aa5e9a63 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -665,7 +665,9 @@ _virtualboxCreateHardDisk(IVirtualBox *vboxObj, PRUnich= ar *format, #if VBOX_API_VERSION < 5000000 return vboxObj->vtbl->CreateHardDisk(vboxObj, format, location, medium= ); #elif VBOX_API_VERSION >=3D 5000000 /*VBOX_API_VERSION >=3D 5000000*/ - return vboxObj->vtbl->CreateMedium(vboxObj, format, location, AccessMo= de_ReadWrite, DeviceType_HardDisk, medium); + return vboxObj->vtbl->CreateMedium(vboxObj, format, location, + AccessMode_ReadWrite, + DeviceType_HardDisk, medium); #endif /*VBOX_API_VERSION >=3D 5000000*/ } =20 @@ -676,38 +678,33 @@ _virtualboxRegisterMachine(IVirtualBox *vboxObj, IMac= hine *machine) } =20 static nsresult -_virtualboxFindHardDisk(IVirtualBox *vboxObj, PRUnichar *location, - PRUint32 deviceType ATTRIBUTE_UNUSED, +_virtualboxFindHardDisk(IVirtualBox *vboxObj, + PRUnichar *location, + PRUint32 deviceType, PRUint32 accessMode ATTRIBUTE_UNUSED, IMedium **medium) { #if VBOX_API_VERSION < 4002000 - return vboxObj->vtbl->FindMedium(vboxObj, location, - deviceType, medium); + return vboxObj->vtbl->FindMedium(vboxObj, location, deviceType, medium= ); #else /* VBOX_API_VERSION >=3D 4002000 */ - return vboxObj->vtbl->OpenMedium(vboxObj, location, - deviceType, accessMode, PR_FALSE, med= ium); + return vboxObj->vtbl->OpenMedium(vboxObj, location, deviceType, access= Mode, + PR_FALSE, medium); #endif /* VBOX_API_VERSION >=3D 4002000 */ } =20 static nsresult -_virtualboxOpenMedium(IVirtualBox *vboxObj ATTRIBUTE_UNUSED, - PRUnichar *location ATTRIBUTE_UNUSED, - PRUint32 deviceType ATTRIBUTE_UNUSED, - PRUint32 accessMode ATTRIBUTE_UNUSED, - IMedium **medium ATTRIBUTE_UNUSED) +_virtualboxOpenMedium(IVirtualBox *vboxObj, + PRUnichar *location, + PRUint32 deviceType, + PRUint32 accessMode, + IMedium **medium) { #if VBOX_API_VERSION =3D=3D 4000000 - return vboxObj->vtbl->OpenMedium(vboxObj, - location, - deviceType, accessMode, + return vboxObj->vtbl->OpenMedium(vboxObj, location, deviceType, access= Mode, medium); #elif VBOX_API_VERSION >=3D 4001000 - return vboxObj->vtbl->OpenMedium(vboxObj, - location, - deviceType, accessMode, - false, - medium); + return vboxObj->vtbl->OpenMedium(vboxObj, location, deviceType, access= Mode, + false, medium); #endif } =20 @@ -759,12 +756,12 @@ _machineGetStorageControllerByName(IMachine *machine,= PRUnichar *name, } =20 static nsresult -_machineAttachDevice(IMachine *machine ATTRIBUTE_UNUSED, - PRUnichar *name ATTRIBUTE_UNUSED, - PRInt32 controllerPort ATTRIBUTE_UNUSED, - PRInt32 device ATTRIBUTE_UNUSED, - PRUint32 type ATTRIBUTE_UNUSED, - IMedium * medium ATTRIBUTE_UNUSED) +_machineAttachDevice(IMachine *machine, + PRUnichar *name, + PRInt32 controllerPort, + PRInt32 device, + PRUint32 type, + IMedium * medium) { return machine->vtbl->AttachDevice(machine, name, controllerPort, device, type, medium); --=20 2.14.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list