From nobody Fri May 3 21:34:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1508866537186878.0312514450919; Tue, 24 Oct 2017 10:35:37 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3954F2CE979; Tue, 24 Oct 2017 17:35:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7DD55EDE2; Tue, 24 Oct 2017 17:35:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 93D476EF27; Tue, 24 Oct 2017 17:35:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9OHZH1b024627 for ; Tue, 24 Oct 2017 13:35:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id 929757DF66; Tue, 24 Oct 2017 17:35:17 +0000 (UTC) Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com [10.5.110.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 845627DF68; Tue, 24 Oct 2017 17:35:17 +0000 (UTC) Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9A53712156; Tue, 24 Oct 2017 17:35:16 +0000 (UTC) Received: by mail-pg0-f65.google.com with SMTP id j3so15094502pga.1; Tue, 24 Oct 2017 10:35:16 -0700 (PDT) Received: from ps-f25-dev.eng.nutanix.com ([205.209.132.2]) by smtp.gmail.com with ESMTPSA id k2sm1333236pff.126.2017.10.24.10.35.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Oct 2017 10:35:15 -0700 (PDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3954F2CE979 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3954F2CE979 Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BNuIF/93" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9A53712156 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=saxenap.ltc@gmail.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9A53712156 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AIf6HJF6r0r23witQBrn9xprhkieZWTwWRAcDgZghKA=; b=BNuIF/93kqQhxb7KWGoiGQbU/ZWb+9vmCO6hpI6xdKHQJKoM4BHzSVXDdsAXz3/Dsn unQheqYek3d2s6zjwD8157/K+GKZPwuGDS2lBDhKef/kAuIYrunFywBMaLh9DwPEe2N4 bOsECN96kwMpeK09+B79LFW9bAruu5mWeQ3gIulK7oiGi5ZDjEbWl1Pw/W/bGUVZek8u qxkbDQ2Hr0TweUsMlHDtNVrpvGrfNKMc03UEqBEzkKJzHgcKOtN8mDhieCy1U1hfRL9T vHVcmsy9OwEv7EHXtT+UfawkqDFZvpheo86MITVynRglM0Xfz2ehm/sLx6KQI8NOxYMQ tfXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AIf6HJF6r0r23witQBrn9xprhkieZWTwWRAcDgZghKA=; b=THwQbWfowAZJ5EjTOj1M66UvbVwu734eaeREbSB6PlWFaoz0vagmMIaHRY4da76NKb yGmfyqUku3Mtt48sp39CmiBq4RZl15+U8IgD/Y986niuWdmO4fztpMl68XAxngOEgNkP 7DtaEXH9BSW+Qg8AkvMB7SXoMU4OFX7R4gWNQ/uhrUoVuuRk+xM6j2YMl2pl4WpPsiiY gaHY3WoPQXe54At1efZQnwEx/qHll8v9MecuTzpD9ilGCC/Kf3AAAwHs8+oh+87CzjIs XmKV/bMFNm5GMJ5E8om+fWUQBhHxn6VPfr9FCDXn05blHE0ZjjriCaBQ+NdVzSU7TX7D dngg== X-Gm-Message-State: AMCzsaVnNkrdl3fbqPgCELvH2bdRKnUBZhpyQdfBIYFI7rYPEfOAMjzz /tv0LUsaXeoXH07yF9ClfMtt0P0NR04= X-Google-Smtp-Source: ABhQp+T+C/6wbXZgnosBgRxn+wdTz6WhZwvsuheJ/8xDlzrf3rkEArvTosL7fUNJ9joU7Z4x9pnrQQ== X-Received: by 10.99.67.71 with SMTP id q68mr15457981pga.163.1508866515744; Tue, 24 Oct 2017 10:35:15 -0700 (PDT) From: Prerna Saxena To: libvir-list@redhat.com Date: Tue, 24 Oct 2017 10:35:01 -0700 Message-Id: <20171024173501.18105-9-saxenap.ltc@gmail.com> In-Reply-To: <20171024173501.18105-1-saxenap.ltc@gmail.com> References: <20171024173501.18105-1-saxenap.ltc@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 24 Oct 2017 17:35:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 24 Oct 2017 17:35:16 +0000 (UTC) for IP:'74.125.83.65' DOMAIN:'mail-pg0-f65.google.com' HELO:'mail-pg0-f65.google.com' FROM:'saxenap.ltc@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.37 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, SPF_PASS) 74.125.83.65 mail-pg0-f65.google.com 74.125.83.65 mail-pg0-f65.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.25 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: --jdenemar@redhat.com, --pkrempa@redhat.com Subject: [libvirt] [[RFC] 8/8] Initialize the per-VM event queues in context of domain init. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 24 Oct 2017 17:35:36 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Prerna Saxena --- src/qemu/qemu_driver.c | 20 ++++++++++++++++++++ src/qemu/qemu_event.c | 2 ++ 2 files changed, 22 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 881f253..e4b6d06 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1781,6 +1781,11 @@ static virDomainPtr qemuDomainCreateXML(virConnectPt= r conn, VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE, NULL))) goto cleanup; + + if (virQemuVmEventListInit(vm) < 0) { + virDomainObjListRemove(driver->domains, vm); + goto cleanup; + } virObjectRef(vm); def =3D NULL; =20 @@ -5531,6 +5536,11 @@ qemuDomainRestoreFlags(virConnectPtr conn, VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE, NULL))) goto cleanup; + + if (virQemuVmEventListInit(vm) < 0) { + virDomainObjListRemove(driver->domains, vm); + goto cleanup; + } virObjectRef(vm); def =3D NULL; =20 @@ -6208,6 +6218,11 @@ qemuDomainDefineXMLFlags(virConnectPtr conn, 0, &oldDef))) goto cleanup; =20 + if (virQemuVmEventListInit(vm) < 0) { + virDomainObjListRemove(driver->domains, vm); + goto cleanup; + } + virObjectRef(vm); def =3D NULL; if (qemuDomainHasBlockjob(vm, true)) { @@ -15073,6 +15088,11 @@ static virDomainPtr qemuDomainQemuAttach(virConnec= tPtr conn, NULL))) goto cleanup; =20 + if (virQemuVmEventListInit(vm) < 0) { + virDomainObjListRemove(driver->domains, vm); + goto cleanup; + } + virObjectRef(vm); def =3D NULL; =20 diff --git a/src/qemu/qemu_event.c b/src/qemu/qemu_event.c index beb309f..00a06ee 100644 --- a/src/qemu/qemu_event.c +++ b/src/qemu/qemu_event.c @@ -145,6 +145,8 @@ int virEnqueueVMEvent(virQemuEventList *qlist, qemuEven= tPtr ev) =20 /* Insert into per-Vm queue */ vmq =3D ev->vm->vmq; + if (!vmq) + goto error; =20 virMutexLock(&(vmq->lock)); if (vmq->last) { --=20 2.9.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list