[libvirt] [RFC PATCH 0/4] Deadlock fix and some minor fixes

Marc Hartmayer posted 4 patches 6 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20171009191458.17685-1-mhartmay@linux.vnet.ibm.com
src/libvirt_private.syms |  2 ++
src/lxc/lxc_container.c  | 20 +++++++++++++++-----
src/util/vircommand.c    | 39 ++++++++++++++++++++++++++++-----------
src/util/vircommand.h    |  6 +++++-
tests/commandtest.c      | 15 ++++++++++-----
5 files changed, 60 insertions(+), 22 deletions(-)
[libvirt] [RFC PATCH 0/4] Deadlock fix and some minor fixes
Posted by Marc Hartmayer 6 years, 5 months ago
The first patch is a preparatory patch for the deadlock fix (patch
2). The cleanup path for 'virExecCommon' may now be superflous. 
Patches 3-4 are only minor fixes.

Important: there may still be a deadlock for LXC (see the TODO in
patch 2)

Marc Hartmayer (4):
  util: Add virCommandGetGID and virCommandGetUID
  util: Fix deadlock across fork()
  lxc: Fixed a typo
  lxc: Fixed indentation

 src/libvirt_private.syms |  2 ++
 src/lxc/lxc_container.c  | 20 +++++++++++++++-----
 src/util/vircommand.c    | 39 ++++++++++++++++++++++++++++-----------
 src/util/vircommand.h    |  6 +++++-
 tests/commandtest.c      | 15 ++++++++++-----
 5 files changed, 60 insertions(+), 22 deletions(-)

-- 
2.5.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC PATCH 0/4] Deadlock fix and some minor fixes
Posted by Daniel P. Berrange 6 years, 5 months ago
On Mon, Oct 09, 2017 at 09:14:54PM +0200, Marc Hartmayer wrote:
> The first patch is a preparatory patch for the deadlock fix (patch
> 2). The cleanup path for 'virExecCommon' may now be superflous. 
> Patches 3-4 are only minor fixes.
> 
> Important: there may still be a deadlock for LXC (see the TODO in
> patch 2)

I've pushed this patch series as is - please send a followup to address
the further issue in LXC


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list