From nobody Sun Feb 8 16:31:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1505829646853512.4037268367938; Tue, 19 Sep 2017 07:00:46 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD94AC052426; Tue, 19 Sep 2017 14:00:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98FE95D75D; Tue, 19 Sep 2017 14:00:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 552E13FACF; Tue, 19 Sep 2017 14:00:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v8JDQ093012627 for ; Tue, 19 Sep 2017 09:26:00 -0400 Received: by smtp.corp.redhat.com (Postfix) id 125B3197F3; Tue, 19 Sep 2017 13:26:00 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-150.phx2.redhat.com [10.3.116.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB25F61346 for ; Tue, 19 Sep 2017 13:25:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BD94AC052426 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: John Ferlan To: libvir-list@redhat.com Date: Tue, 19 Sep 2017 09:25:04 -0400 Message-Id: <20170919132518.28151-6-jferlan@redhat.com> In-Reply-To: <20170919132518.28151-1-jferlan@redhat.com> References: <20170919132518.28151-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 05/19] test: Use virStoragePoolObjGetDef accessor X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 19 Sep 2017 14:00:46 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" In preparation for privatizing the object, use the accessor. Signed-off-by: John Ferlan --- src/test/test_driver.c | 162 +++++++++++++++++++++++++++------------------= ---- 1 file changed, 91 insertions(+), 71 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7ddff053b..5e68b03e5 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1046,6 +1046,7 @@ testOpenVolumesForPool(const char *file, virStoragePoolObjPtr obj, int objidx) { + virStoragePoolDefPtr def =3D virStoragePoolObjGetDef(obj); char *vol_xpath; size_t i; int num, ret =3D -1; @@ -1067,12 +1068,12 @@ testOpenVolumesForPool(const char *file, if (!node) goto error; =20 - if (!(volDef =3D virStorageVolDefParseNode(obj->def, ctxt->doc, no= de, 0))) + if (!(volDef =3D virStorageVolDefParseNode(def, ctxt->doc, node, 0= ))) goto error; =20 if (!volDef->target.path) { if (virAsprintf(&volDef->target.path, "%s/%s", - obj->def->target.path, volDef->name) < 0) + def->target.path, volDef->name) < 0) goto error; } =20 @@ -1082,8 +1083,8 @@ testOpenVolumesForPool(const char *file, if (virStoragePoolObjAddVol(obj, volDef) < 0) goto error; =20 - obj->def->allocation +=3D volDef->target.allocation; - obj->def->available =3D (obj->def->capacity - obj->def->allocation= ); + def->allocation +=3D volDef->target.allocation; + def->available =3D (def->capacity - def->allocation); volDef =3D NULL; } =20 @@ -4072,10 +4073,11 @@ static int testStoragePoolObjSetDefaults(virStoragePoolObjPtr obj) { char *configFile; + virStoragePoolDefPtr def =3D virStoragePoolObjGetDef(obj); =20 - obj->def->capacity =3D defaultPoolCap; - obj->def->allocation =3D defaultPoolAlloc; - obj->def->available =3D defaultPoolCap - defaultPoolAlloc; + def->capacity =3D defaultPoolCap; + def->allocation =3D defaultPoolAlloc; + def->available =3D defaultPoolCap - defaultPoolAlloc; =20 if (VIR_STRDUP(configFile, "") < 0) return -1; @@ -4172,13 +4174,14 @@ testStoragePoolLookupByUUID(virConnectPtr conn, { testDriverPtr privconn =3D conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; virStoragePoolPtr pool =3D NULL; =20 if (!(obj =3D testStoragePoolObjFindByUUID(privconn, uuid))) return NULL; + def =3D virStoragePoolObjGetDef(obj); =20 - pool =3D virGetStoragePool(conn, obj->def->name, obj->def->uuid, - NULL, NULL); + pool =3D virGetStoragePool(conn, def->name, def->uuid, NULL, NULL); =20 virStoragePoolObjUnlock(obj); return pool; @@ -4191,13 +4194,14 @@ testStoragePoolLookupByName(virConnectPtr conn, { testDriverPtr privconn =3D conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; virStoragePoolPtr pool =3D NULL; =20 if (!(obj =3D testStoragePoolObjFindByName(privconn, name))) return NULL; + def =3D virStoragePoolObjGetDef(obj); =20 - pool =3D virGetStoragePool(conn, obj->def->name, obj->def->uuid, - NULL, NULL); + pool =3D virGetStoragePool(conn, def->name, def->uuid, NULL, NULL); =20 virStoragePoolObjUnlock(obj); return pool; @@ -4442,38 +4446,40 @@ testStoragePoolCreateXML(virConnectPtr conn, unsigned int flags) { testDriverPtr privconn =3D conn->privateData; - virStoragePoolDefPtr def; + virStoragePoolDefPtr newDef; virStoragePoolObjPtr obj =3D NULL; + virStoragePoolDefPtr def; virStoragePoolPtr pool =3D NULL; virObjectEventPtr event =3D NULL; =20 virCheckFlags(0, NULL); =20 testDriverLock(privconn); - if (!(def =3D virStoragePoolDefParseString(xml))) + if (!(newDef =3D virStoragePoolDefParseString(xml))) goto cleanup; =20 - obj =3D virStoragePoolObjFindByUUID(&privconn->pools, def->uuid); + obj =3D virStoragePoolObjFindByUUID(&privconn->pools, newDef->uuid); if (!obj) - obj =3D virStoragePoolObjFindByName(&privconn->pools, def->name); + obj =3D virStoragePoolObjFindByName(&privconn->pools, newDef->name= ); if (obj) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("storage pool already exists")); goto cleanup; } =20 - if (!(obj =3D virStoragePoolObjAssignDef(&privconn->pools, def))) + if (!(obj =3D virStoragePoolObjAssignDef(&privconn->pools, newDef))) goto cleanup; - def =3D NULL; + newDef =3D NULL; + def =3D virStoragePoolObjGetDef(obj); =20 - if (obj->def->source.adapter.type =3D=3D VIR_STORAGE_ADAPTER_TYPE_FC_H= OST) { + if (def->source.adapter.type =3D=3D VIR_STORAGE_ADAPTER_TYPE_FC_HOST) { /* In the real code, we'd call virVHBAManageVport followed by * find_new_device, but we cannot do that here since we're not * mocking udev. The mock routine will copy an existing vHBA and * rename a few fields to mock that. */ if (testCreateVport(privconn, - obj->def->source.adapter.data.fchost.wwnn, - obj->def->source.adapter.data.fchost.wwpn) < 0= ) { + def->source.adapter.data.fchost.wwnn, + def->source.adapter.data.fchost.wwpn) < 0) { virStoragePoolObjRemove(&privconn->pools, obj); obj =3D NULL; goto cleanup; @@ -4493,14 +4499,14 @@ testStoragePoolCreateXML(virConnectPtr conn, =20 virStoragePoolObjSetActive(obj, true); =20 - event =3D virStoragePoolEventLifecycleNew(obj->def->name, obj->def->uu= id, + event =3D virStoragePoolEventLifecycleNew(def->name, def->uuid, VIR_STORAGE_POOL_EVENT_STARTED, 0); =20 - pool =3D virGetStoragePool(conn, obj->def->name, obj->def->uuid, NULL,= NULL); + pool =3D virGetStoragePool(conn, def->name, def->uuid, NULL, NULL); =20 cleanup: - virStoragePoolDefFree(def); + virStoragePoolDefFree(newDef); testObjectEventQueue(privconn, event); if (obj) virStoragePoolObjUnlock(obj); @@ -4515,26 +4521,28 @@ testStoragePoolDefineXML(virConnectPtr conn, unsigned int flags) { testDriverPtr privconn =3D conn->privateData; - virStoragePoolDefPtr def; + virStoragePoolDefPtr newDef; virStoragePoolObjPtr obj =3D NULL; + virStoragePoolDefPtr def; virStoragePoolPtr pool =3D NULL; virObjectEventPtr event =3D NULL; =20 virCheckFlags(0, NULL); =20 testDriverLock(privconn); - if (!(def =3D virStoragePoolDefParseString(xml))) + if (!(newDef =3D virStoragePoolDefParseString(xml))) goto cleanup; =20 - def->capacity =3D defaultPoolCap; - def->allocation =3D defaultPoolAlloc; - def->available =3D defaultPoolCap - defaultPoolAlloc; + newDef->capacity =3D defaultPoolCap; + newDef->allocation =3D defaultPoolAlloc; + newDef->available =3D defaultPoolCap - defaultPoolAlloc; =20 - if (!(obj =3D virStoragePoolObjAssignDef(&privconn->pools, def))) + if (!(obj =3D virStoragePoolObjAssignDef(&privconn->pools, newDef))) goto cleanup; - def =3D NULL; + newDef =3D NULL; + def =3D virStoragePoolObjGetDef(obj); =20 - event =3D virStoragePoolEventLifecycleNew(obj->def->name, obj->def->uu= id, + event =3D virStoragePoolEventLifecycleNew(def->name, def->uuid, VIR_STORAGE_POOL_EVENT_DEFINED, 0); =20 @@ -4544,10 +4552,10 @@ testStoragePoolDefineXML(virConnectPtr conn, goto cleanup; } =20 - pool =3D virGetStoragePool(conn, obj->def->name, obj->def->uuid, NULL,= NULL); + pool =3D virGetStoragePool(conn, def->name, def->uuid, NULL, NULL); =20 cleanup: - virStoragePoolDefFree(def); + virStoragePoolDefFree(newDef); testObjectEventQueue(privconn, event); if (obj) virStoragePoolObjUnlock(obj); @@ -4633,24 +4641,25 @@ testStoragePoolDestroy(virStoragePoolPtr pool) { testDriverPtr privconn =3D pool->conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; int ret =3D -1; virObjectEventPtr event =3D NULL; =20 if (!(obj =3D testStoragePoolObjFindActiveByName(privconn, pool->name)= )) return -1; + def =3D virStoragePoolObjGetDef(obj); =20 virStoragePoolObjSetActive(obj, false); =20 - if (obj->def->source.adapter.type =3D=3D - VIR_STORAGE_ADAPTER_TYPE_FC_HOST) { + if (def->source.adapter.type =3D=3D VIR_STORAGE_ADAPTER_TYPE_FC_HOST) { if (testDestroyVport(privconn, - obj->def->source.adapter.data.fchost.wwnn, - obj->def->source.adapter.data.fchost.wwpn) < = 0) + def->source.adapter.data.fchost.wwnn, + def->source.adapter.data.fchost.wwpn) < 0) goto cleanup; } =20 - event =3D virStoragePoolEventLifecycleNew(obj->def->name, - obj->def->uuid, + event =3D virStoragePoolEventLifecycleNew(def->name, + def->uuid, VIR_STORAGE_POOL_EVENT_STOPPED, 0); =20 @@ -4712,18 +4721,20 @@ testStoragePoolGetInfo(virStoragePoolPtr pool, { testDriverPtr privconn =3D pool->conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; =20 if (!(obj =3D testStoragePoolObjFindByName(privconn, pool->name))) return -1; + def =3D virStoragePoolObjGetDef(obj); =20 memset(info, 0, sizeof(virStoragePoolInfo)); if (virStoragePoolObjIsActive(obj)) info->state =3D VIR_STORAGE_POOL_RUNNING; else info->state =3D VIR_STORAGE_POOL_INACTIVE; - info->capacity =3D obj->def->capacity; - info->allocation =3D obj->def->allocation; - info->available =3D obj->def->available; + info->capacity =3D def->capacity; + info->allocation =3D def->allocation; + info->available =3D def->available; =20 virStoragePoolObjUnlock(obj); return 0; @@ -4743,7 +4754,7 @@ testStoragePoolGetXMLDesc(virStoragePoolPtr pool, if (!(obj =3D testStoragePoolObjFindByName(privconn, pool->name))) return NULL; =20 - ret =3D virStoragePoolDefFormat(obj->def); + ret =3D virStoragePoolDefFormat(virStoragePoolObjGetDef(obj)); =20 virStoragePoolObjUnlock(obj); return ret; @@ -4883,16 +4894,18 @@ testStorageVolLookupByName(virStoragePoolPtr pool, { testDriverPtr privconn =3D pool->conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; virStorageVolDefPtr privvol; virStorageVolPtr ret =3D NULL; =20 if (!(obj =3D testStoragePoolObjFindActiveByName(privconn, pool->name)= )) return NULL; + def =3D virStoragePoolObjGetDef(obj); =20 if (!(privvol =3D testStorageVolDefFindByName(obj, name))) goto cleanup; =20 - ret =3D virGetStorageVol(pool->conn, obj->def->name, + ret =3D virGetStorageVol(pool->conn, def->name, privvol->name, privvol->key, NULL, NULL); =20 @@ -4908,6 +4921,7 @@ testStorageVolLookupByKey(virConnectPtr conn, { testDriverPtr privconn =3D conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; size_t i; virStorageVolPtr ret =3D NULL; =20 @@ -4915,14 +4929,13 @@ testStorageVolLookupByKey(virConnectPtr conn, for (i =3D 0; i < privconn->pools.count; i++) { obj =3D privconn->pools.objs[i]; virStoragePoolObjLock(obj); + def =3D virStoragePoolObjGetDef(obj); if (virStoragePoolObjIsActive(obj)) { virStorageVolDefPtr privvol =3D virStorageVolDefFindByKey(obj,= key); =20 if (privvol) { - ret =3D virGetStorageVol(conn, - obj->def->name, - privvol->name, - privvol->key, + ret =3D virGetStorageVol(conn, def->name, + privvol->name, privvol->key, NULL, NULL); virStoragePoolObjUnlock(obj); break; @@ -4946,6 +4959,7 @@ testStorageVolLookupByPath(virConnectPtr conn, { testDriverPtr privconn =3D conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; size_t i; virStorageVolPtr ret =3D NULL; =20 @@ -4953,14 +4967,13 @@ testStorageVolLookupByPath(virConnectPtr conn, for (i =3D 0; i < privconn->pools.count; i++) { obj =3D privconn->pools.objs[i]; virStoragePoolObjLock(obj); + def =3D virStoragePoolObjGetDef(obj); if (virStoragePoolObjIsActive(obj)) { virStorageVolDefPtr privvol =3D virStorageVolDefFindByPath(obj= , path); =20 if (privvol) { - ret =3D virGetStorageVol(conn, - obj->def->name, - privvol->name, - privvol->key, + ret =3D virGetStorageVol(conn, def->name, + privvol->name, privvol->key, NULL, NULL); virStoragePoolObjUnlock(obj); break; @@ -4985,6 +4998,7 @@ testStorageVolCreateXML(virStoragePoolPtr pool, { testDriverPtr privconn =3D pool->conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; virStorageVolDefPtr privvol =3D NULL; virStorageVolPtr ret =3D NULL; =20 @@ -4992,8 +5006,9 @@ testStorageVolCreateXML(virStoragePoolPtr pool, =20 if (!(obj =3D testStoragePoolObjFindActiveByName(privconn, pool->name)= )) return NULL; + def =3D virStoragePoolObjGetDef(obj); =20 - privvol =3D virStorageVolDefParseString(obj->def, xmldesc, 0); + privvol =3D virStorageVolDefParseString(def, xmldesc, 0); if (privvol =3D=3D NULL) goto cleanup; =20 @@ -5004,8 +5019,8 @@ testStorageVolCreateXML(virStoragePoolPtr pool, } =20 /* Make sure enough space */ - if ((obj->def->allocation + privvol->target.allocation) > - obj->def->capacity) { + if ((def->allocation + privvol->target.allocation) > + def->capacity) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Not enough free space in pool for volume '%s'"), privvol->name); @@ -5013,17 +5028,17 @@ testStorageVolCreateXML(virStoragePoolPtr pool, } =20 if (virAsprintf(&privvol->target.path, "%s/%s", - obj->def->target.path, privvol->name) < 0) + def->target.path, privvol->name) < 0) goto cleanup; =20 if (VIR_STRDUP(privvol->key, privvol->target.path) < 0 || virStoragePoolObjAddVol(obj, privvol) < 0) goto cleanup; =20 - obj->def->allocation +=3D privvol->target.allocation; - obj->def->available =3D (obj->def->capacity - obj->def->allocation); + def->allocation +=3D privvol->target.allocation; + def->available =3D (def->capacity - def->allocation); =20 - ret =3D virGetStorageVol(pool->conn, obj->def->name, + ret =3D virGetStorageVol(pool->conn, def->name, privvol->name, privvol->key, NULL, NULL); privvol =3D NULL; @@ -5043,6 +5058,7 @@ testStorageVolCreateXMLFrom(virStoragePoolPtr pool, { testDriverPtr privconn =3D pool->conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; virStorageVolDefPtr privvol =3D NULL, origvol =3D NULL; virStorageVolPtr ret =3D NULL; =20 @@ -5050,8 +5066,9 @@ testStorageVolCreateXMLFrom(virStoragePoolPtr pool, =20 if (!(obj =3D testStoragePoolObjFindActiveByName(privconn, pool->name)= )) return NULL; + def =3D virStoragePoolObjGetDef(obj); =20 - privvol =3D virStorageVolDefParseString(obj->def, xmldesc, 0); + privvol =3D virStorageVolDefParseString(def, xmldesc, 0); if (privvol =3D=3D NULL) goto cleanup; =20 @@ -5070,27 +5087,26 @@ testStorageVolCreateXMLFrom(virStoragePoolPtr pool, } =20 /* Make sure enough space */ - if ((obj->def->allocation + privvol->target.allocation) > - obj->def->capacity) { + if ((def->allocation + privvol->target.allocation) > def->capacity) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Not enough free space in pool for volume '%s'"), privvol->name); goto cleanup; } - obj->def->available =3D (obj->def->capacity - obj->def->allocation); + def->available =3D (def->capacity - def->allocation); =20 if (virAsprintf(&privvol->target.path, "%s/%s", - obj->def->target.path, privvol->name) < 0) + def->target.path, privvol->name) < 0) goto cleanup; =20 if (VIR_STRDUP(privvol->key, privvol->target.path) < 0 || virStoragePoolObjAddVol(obj, privvol) < 0) goto cleanup; =20 - obj->def->allocation +=3D privvol->target.allocation; - obj->def->available =3D (obj->def->capacity - obj->def->allocation); + def->allocation +=3D privvol->target.allocation; + def->available =3D (def->capacity - def->allocation); =20 - ret =3D virGetStorageVol(pool->conn, obj->def->name, + ret =3D virGetStorageVol(pool->conn, def->name, privvol->name, privvol->key, NULL, NULL); privvol =3D NULL; @@ -5108,6 +5124,7 @@ testStorageVolDelete(virStorageVolPtr vol, { testDriverPtr privconn =3D vol->conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; virStorageVolDefPtr privvol; int ret =3D -1; =20 @@ -5115,12 +5132,13 @@ testStorageVolDelete(virStorageVolPtr vol, =20 if (!(obj =3D testStoragePoolObjFindActiveByName(privconn, vol->pool))) return -1; + def =3D virStoragePoolObjGetDef(obj); =20 if (!(privvol =3D testStorageVolDefFindByName(obj, vol->name))) goto cleanup; =20 - obj->def->allocation -=3D privvol->target.allocation; - obj->def->available =3D (obj->def->capacity - obj->def->allocation); + def->allocation -=3D privvol->target.allocation; + def->available =3D (def->capacity - def->allocation); =20 virStoragePoolObjRemoveVol(obj, privvol); =20 @@ -5153,17 +5171,19 @@ testStorageVolGetInfo(virStorageVolPtr vol, { testDriverPtr privconn =3D vol->conn->privateData; virStoragePoolObjPtr obj; + virStoragePoolDefPtr def; virStorageVolDefPtr privvol; int ret =3D -1; =20 if (!(obj =3D testStoragePoolObjFindActiveByName(privconn, vol->pool))) return -1; + def =3D virStoragePoolObjGetDef(obj); =20 if (!(privvol =3D testStorageVolDefFindByName(obj, vol->name))) goto cleanup; =20 memset(info, 0, sizeof(*info)); - info->type =3D testStorageVolumeTypeForPool(obj->def->type); + info->type =3D testStorageVolumeTypeForPool(def->type); info->capacity =3D privvol->target.capacity; info->allocation =3D privvol->target.allocation; ret =3D 0; @@ -5191,7 +5211,7 @@ testStorageVolGetXMLDesc(virStorageVolPtr vol, if (!(privvol =3D testStorageVolDefFindByName(obj, vol->name))) goto cleanup; =20 - ret =3D virStorageVolDefFormat(obj->def, privvol); + ret =3D virStorageVolDefFormat(virStoragePoolObjGetDef(obj), privvol); =20 cleanup: virStoragePoolObjUnlock(obj); --=20 2.13.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list