[libvirt] [PATCH 0/5] Reject parallel ports on s390, and pseries

Pino Toscano posted 5 patches 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170907121940.18090-1-ptoscano@redhat.com
src/qemu/qemu_domain.c                             | 16 ++++++++++++----
.../qemuxml2argv-pseries-no-parallel.xml           | 18 ++++++++++++++++++
.../qemuxml2argv-s390-no-parallel.xml              | 22 ++++++++++++++++++++++
tests/qemuxml2argvtest.c                           | 20 +++++++++++++++++---
4 files changed, 69 insertions(+), 7 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-no-parallel.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-no-parallel.xml
[libvirt] [PATCH 0/5] Reject parallel ports on s390, and pseries
Posted by Pino Toscano 6 years, 6 months ago
Hi,

this is a simple series to reject parallel ports on s390 architectures,
and pseries machines -- both simply do not support them.  This fixes
https://bugzilla.redhat.com/show_bug.cgi?id=1487499

Pino Toscano (5):
  tests: qemuxml2argv: fix expected type for usb-bus-missing
  tests: qemuxml2argv: fail also on unexpected pass
  qemu: pass the virDomainDef to qemuDomainChrDefValidate
  qemu: reject parallel ports for s390 archs
  qemu: reject parallel ports for pseries machines

 src/qemu/qemu_domain.c                             | 16 ++++++++++++----
 .../qemuxml2argv-pseries-no-parallel.xml           | 18 ++++++++++++++++++
 .../qemuxml2argv-s390-no-parallel.xml              | 22 ++++++++++++++++++++++
 tests/qemuxml2argvtest.c                           | 20 +++++++++++++++++---
 4 files changed, 69 insertions(+), 7 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-no-parallel.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-no-parallel.xml

-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/5] Reject parallel ports on s390, and pseries
Posted by Michal Privoznik 6 years, 6 months ago
On 09/07/2017 02:19 PM, Pino Toscano wrote:
> Hi,
> 
> this is a simple series to reject parallel ports on s390 architectures,
> and pseries machines -- both simply do not support them.  This fixes
> https://bugzilla.redhat.com/show_bug.cgi?id=1487499
> 
> Pino Toscano (5):
>   tests: qemuxml2argv: fix expected type for usb-bus-missing
>   tests: qemuxml2argv: fail also on unexpected pass
>   qemu: pass the virDomainDef to qemuDomainChrDefValidate
>   qemu: reject parallel ports for s390 archs
>   qemu: reject parallel ports for pseries machines
> 
>  src/qemu/qemu_domain.c                             | 16 ++++++++++++----
>  .../qemuxml2argv-pseries-no-parallel.xml           | 18 ++++++++++++++++++
>  .../qemuxml2argv-s390-no-parallel.xml              | 22 ++++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           | 20 +++++++++++++++++---
>  4 files changed, 69 insertions(+), 7 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-no-parallel.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-no-parallel.xml
> 

ACK series.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/5] Reject parallel ports on s390, and pseries
Posted by Andrea Bolognani 6 years, 6 months ago
On Mon, 2017-09-18 at 14:59 +0200, Michal Privoznik wrote:
> > Pino Toscano (5):
> >   tests: qemuxml2argv: fix expected type for usb-bus-missing
> >   tests: qemuxml2argv: fail also on unexpected pass
> >   qemu: pass the virDomainDef to qemuDomainChrDefValidate
> >   qemu: reject parallel ports for s390 archs
> >   qemu: reject parallel ports for pseries machines
> > 
> >  src/qemu/qemu_domain.c                             | 16 ++++++++++++----
> >  .../qemuxml2argv-pseries-no-parallel.xml           | 18 ++++++++++++++++++
> >  .../qemuxml2argv-s390-no-parallel.xml              | 22 ++++++++++++++++++++++
> >  tests/qemuxml2argvtest.c                           | 20 +++++++++++++++++---
> >  4 files changed, 69 insertions(+), 7 deletions(-)
> >  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-no-parallel.xml
> >  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-no-parallel.xml
> > 
> 
> ACK series.

Do you plan to also push the series?

AFAIK Pino doesn't have commit access to libvirt.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/5] Reject parallel ports on s390, and pseries
Posted by Michal Privoznik 6 years, 6 months ago
On 09/21/2017 12:51 PM, Andrea Bolognani wrote:
> On Mon, 2017-09-18 at 14:59 +0200, Michal Privoznik wrote:
>>> Pino Toscano (5):
>>>   tests: qemuxml2argv: fix expected type for usb-bus-missing
>>>   tests: qemuxml2argv: fail also on unexpected pass
>>>   qemu: pass the virDomainDef to qemuDomainChrDefValidate
>>>   qemu: reject parallel ports for s390 archs
>>>   qemu: reject parallel ports for pseries machines
>>>
>>>  src/qemu/qemu_domain.c                             | 16 ++++++++++++----
>>>  .../qemuxml2argv-pseries-no-parallel.xml           | 18 ++++++++++++++++++
>>>  .../qemuxml2argv-s390-no-parallel.xml              | 22 ++++++++++++++++++++++
>>>  tests/qemuxml2argvtest.c                           | 20 +++++++++++++++++---
>>>  4 files changed, 69 insertions(+), 7 deletions(-)
>>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-no-parallel.xml
>>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-no-parallel.xml
>>>
>>
>> ACK series.
> 
> Do you plan to also push the series?
> 
> AFAIK Pino doesn't have commit access to libvirt.
> 

Oh, right. He even told me yesterday in person but I completely forgot.
Sorry, pushed now.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list