[libvirt] [PATCH python] rpm: rename packages to python2-libvirt / python3-libvirt

Daniel P. Berrange posted 1 patch 6 years, 7 months ago
Failed in applying to current master (apply log)
libvirt-python.spec.in | 28 +++++++++++++++++++++++-----
1 file changed, 23 insertions(+), 5 deletions(-)
[libvirt] [PATCH python] rpm: rename packages to python2-libvirt / python3-libvirt
Posted by Daniel P. Berrange 6 years, 7 months ago
This compiles with Fedora naming policy for python packages

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 libvirt-python.spec.in | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
index ed9f2bd..e4fb17a 100644
--- a/libvirt-python.spec.in
+++ b/libvirt-python.spec.in
@@ -25,14 +25,32 @@ written in the Python programming language to use the interface
 supplied by the libvirt library to use the virtualization capabilities
 of recent versions of Linux (and other OSes).
 
-%package -n libvirt-python3
+%package -n python2-libvirt
+Summary: The libvirt virtualization API python2 binding
+Url: http://libvirt.org
+License: LGPLv2+
+Group: Development/Libraries
+%{?python_provide:%python_provide python2-libvirt}
+Provides: libvirt-python = %{version}-%{release}
+Obsoletes: libvirt-python < %{version}-%{release}
+
+%description -n python2-libvirt
+The libvirt-python2 package contains a module that permits applications
+written in the Python programming language to use the interface
+supplied by the libvirt library to use the virtualization capabilities
+of recent versions of Linux (and other OSes).
+
+%package -n python3-libvirt
 Summary: The libvirt virtualization API python3 binding
 Url: http://libvirt.org
 License: LGPLv2+
 Group: Development/Libraries
+%{?python_provide:%python_provide python3-libvirt}
+Provides: libvirt-python3 = %{version}-%{release}
+Obsoletes: libvirt-python3 < %{version}-%{release}
 
-%description -n libvirt-python3
-The libvirt-python package contains a module that permits applications
+%description -n python3-libvirt
+The libvirt-python3 package contains a module that permits applications
 written in the Python programming language to use the interface
 supplied by the libvirt library to use the virtualization capabilities
 of recent versions of Linux (and other OSes).
@@ -57,7 +75,7 @@ CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build
 %{__python} setup.py test
 %{__python3} setup.py test
 
-%files
+%files -n python2-libvirt
 %defattr(-,root,root)
 %doc ChangeLog AUTHORS NEWS README COPYING COPYING.LESSER examples/
 %{_libdir}/python2*/site-packages/libvirt.py*
@@ -66,7 +84,7 @@ CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build
 %{_libdir}/python2*/site-packages/libvirtmod*
 %{_libdir}/python2*/site-packages/*egg-info
 
-%files -n libvirt-python3
+%files -n python3-libvirt
 %defattr(-,root,root)
 %doc ChangeLog AUTHORS NEWS README COPYING COPYING.LESSER examples/
 %{_libdir}/python3*/site-packages/libvirt.py*
-- 
2.13.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH python] rpm: rename packages to python2-libvirt / python3-libvirt
Posted by Martin Kletzander 6 years, 7 months ago
On Wed, Aug 09, 2017 at 05:08:58PM +0100, Daniel P. Berrange wrote:
>This compiles with Fedora naming policy for python packages
>

s/compile/complies/

>Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
>---
> libvirt-python.spec.in | 28 +++++++++++++++++++++++-----
> 1 file changed, 23 insertions(+), 5 deletions(-)
>

It's a pityt hat it'll be yet another of those confusing packages where
the source rpm and the specfile etc. are named libvirt-python even
though pythonX-libvirt is the name.  I guess we have no other choice,
though.

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH python] rpm: rename packages to python2-libvirt / python3-libvirt
Posted by Laine Stump 6 years, 7 months ago
On 08/10/2017 03:30 AM, Martin Kletzander wrote:
> On Wed, Aug 09, 2017 at 05:08:58PM +0100, Daniel P. Berrange wrote:
>> This compiles with Fedora naming policy for python packages
>>
>
> s/compile/complies/
>
>> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
>> ---
>> libvirt-python.spec.in | 28 +++++++++++++++++++++++-----
>> 1 file changed, 23 insertions(+), 5 deletions(-)
>>
>
> It's a pityt hat it'll be yet another of those confusing packages where
> the source rpm and the specfile etc. are named libvirt-python even
> though pythonX-libvirt is the name.

Yeah, that and also it will make downgrading for testing purposes
awkward. Ah well, like you say:

>   I guess we have no other choice,
> though.
>
> Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list