From nobody Fri May 3 07:36:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1493056436046436.02454026031376; Mon, 24 Apr 2017 10:53:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9A5E49330A; Mon, 24 Apr 2017 17:53:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5EC7F6292F; Mon, 24 Apr 2017 17:53:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A018D5EC62; Mon, 24 Apr 2017 17:53:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v3OHrjZ2004046 for ; Mon, 24 Apr 2017 13:53:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id D5A1C7D975; Mon, 24 Apr 2017 17:53:45 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-126-74.rdu2.redhat.com [10.10.126.74]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9EDCE80733 for ; Mon, 24 Apr 2017 17:53:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9A5E49330A Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9A5E49330A From: John Ferlan To: libvir-list@redhat.com Date: Mon, 24 Apr 2017 13:53:42 -0400 Message-Id: <20170424175342.22156-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] test: Remove unnecessary unlocks in cleanup paths X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 24 Apr 2017 17:53:54 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Commit id '865f479da' altered the logic to use a common test*ObjFindByName helpers which would lock/unlock the test driver; however, a few cleanup pat= hs in that cleanup missed removing the Unlock, so remove it now. Signed-off-by: John Ferlan --- src/test/test_driver.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 00999b1..2db3f7d 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3931,7 +3931,6 @@ testInterfaceUndefine(virInterfacePtr iface) ret =3D 0; =20 cleanup: - testDriverUnlock(privconn); return ret; } =20 @@ -3960,7 +3959,6 @@ testInterfaceCreate(virInterfacePtr iface, cleanup: if (privinterface) virInterfaceObjUnlock(privinterface); - testDriverUnlock(privconn); return ret; } =20 @@ -3989,7 +3987,6 @@ testInterfaceDestroy(virInterfacePtr iface, cleanup: if (privinterface) virInterfaceObjUnlock(privinterface); - testDriverUnlock(privconn); return ret; } =20 @@ -4480,7 +4477,6 @@ testStoragePoolUndefine(virStoragePoolPtr pool) if (privpool) virStoragePoolObjUnlock(privpool); testObjectEventQueue(privconn, event); - testDriverUnlock(privconn); return ret; } =20 @@ -4591,7 +4587,6 @@ testStoragePoolDestroy(virStoragePoolPtr pool) testObjectEventQueue(privconn, event); if (privpool) virStoragePoolObjUnlock(privpool); - testDriverUnlock(privconn); return ret; } =20 --=20 2.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list