From nobody Sun Feb 8 20:52:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1492041871732517.6860203558506; Wed, 12 Apr 2017 17:04:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 565C97E9DE; Thu, 13 Apr 2017 00:04:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 284D177FE8; Thu, 13 Apr 2017 00:04:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D54144E9BD; Thu, 13 Apr 2017 00:04:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v3D04NLC012176 for ; Wed, 12 Apr 2017 20:04:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id EDCE7173F3; Thu, 13 Apr 2017 00:04:23 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-15.phx2.redhat.com [10.3.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC6D317187 for ; Thu, 13 Apr 2017 00:04:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 565C97E9DE Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 565C97E9DE From: John Ferlan To: libvir-list@redhat.com Date: Wed, 12 Apr 2017 20:04:16 -0400 Message-Id: <20170413000418.30018-4-jferlan@redhat.com> In-Reply-To: <20170413000418.30018-1-jferlan@redhat.com> References: <20170413000418.30018-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [REPOST PATCH 3/5] conf: Alter coding style of network conf function prototypes X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 13 Apr 2017 00:04:31 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" In an effort to be consistent with the source module, alter the function prototypes to follow the similar style of source with the "type" on one line followed by the function name and arguments on subsequent lines with with argument getting it's own line. Signed-off-by: John Ferlan --- src/conf/network_conf.h | 84 ++++++++++++------- src/conf/virnetworkobj.h | 212 ++++++++++++++++++++++++++++---------------= ---- 2 files changed, 182 insertions(+), 114 deletions(-) diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h index 6922942..e9a5baf 100644 --- a/src/conf/network_conf.h +++ b/src/conf/network_conf.h @@ -290,43 +290,71 @@ enum { VIR_NETWORK_OBJ_LIST_ADD_CHECK_LIVE =3D (1 << 1), }; =20 -virNetworkDefPtr virNetworkDefCopy(virNetworkDefPtr def, unsigned int flag= s); -virNetworkDefPtr virNetworkDefParseXML(xmlXPathContextPtr ctxt); -virNetworkDefPtr virNetworkDefParseString(const char *xmlStr); -virNetworkDefPtr virNetworkDefParseFile(const char *filename); -virNetworkDefPtr virNetworkDefParseNode(xmlDocPtr xml, - xmlNodePtr root); -char *virNetworkDefFormat(const virNetworkDef *def, unsigned int flags); -int virNetworkDefFormatBuf(virBufferPtr buf, - const virNetworkDef *def, - unsigned int flags); - -const char * virNetworkDefForwardIf(const virNetworkDef *def, size_t n); - -virPortGroupDefPtr virPortGroupFindByName(virNetworkDefPtr net, - const char *portgroup); +virNetworkDefPtr +virNetworkDefCopy(virNetworkDefPtr def, unsigned int flags); + +virNetworkDefPtr +virNetworkDefParseXML(xmlXPathContextPtr ctxt); + +virNetworkDefPtr +virNetworkDefParseString(const char *xmlStr); + +virNetworkDefPtr +virNetworkDefParseFile(const char *filename); + +virNetworkDefPtr +virNetworkDefParseNode(xmlDocPtr xml, + xmlNodePtr root); + +char * +virNetworkDefFormat(const virNetworkDef *def, + unsigned int flags); + +int +virNetworkDefFormatBuf(virBufferPtr buf, + const virNetworkDef *def, + unsigned int flags); + +const char * +virNetworkDefForwardIf(const virNetworkDef *def, + size_t n); + +virPortGroupDefPtr +virPortGroupFindByName(virNetworkDefPtr net, + const char *portgroup); =20 virNetworkIPDefPtr virNetworkDefGetIPByIndex(const virNetworkDef *def, - int family, size_t n); + int family, + size_t n); + virNetDevIPRoutePtr virNetworkDefGetRouteByIndex(const virNetworkDef *def, - int family, size_t n); -int virNetworkIPDefPrefix(const virNetworkIPDef *def); -int virNetworkIPDefNetmask(const virNetworkIPDef *def, - virSocketAddrPtr netmask); + int family, + size_t n); + +int +virNetworkIPDefPrefix(const virNetworkIPDef *def); =20 -int virNetworkSaveXML(const char *configDir, - virNetworkDefPtr def, - const char *xml); +int +virNetworkIPDefNetmask(const virNetworkIPDef *def, + virSocketAddrPtr netmask); + +int +virNetworkSaveXML(const char *configDir, + virNetworkDefPtr def, + const char *xml); =20 -int virNetworkSaveConfig(const char *configDir, - virNetworkDefPtr def); +int +virNetworkSaveConfig(const char *configDir, + virNetworkDefPtr def); =20 -char *virNetworkConfigFile(const char *dir, - const char *name); +char * +virNetworkConfigFile(const char *dir, + const char *name); =20 -void virNetworkSetBridgeMacAddr(virNetworkDefPtr def); +void +virNetworkSetBridgeMacAddr(virNetworkDefPtr def); =20 VIR_ENUM_DECL(virNetworkForward) =20 diff --git a/src/conf/virnetworkobj.h b/src/conf/virnetworkobj.h index 1eb3151..431721b 100644 --- a/src/conf/virnetworkobj.h +++ b/src/conf/virnetworkobj.h @@ -47,8 +47,11 @@ struct _virNetworkObj { virMacMapPtr macmap; }; =20 -virNetworkObjPtr virNetworkObjNew(void); -void virNetworkObjEndAPI(virNetworkObjPtr *net); +virNetworkObjPtr +virNetworkObjNew(void); + +void +virNetworkObjEndAPI(virNetworkObjPtr *net); =20 typedef struct _virNetworkObjList virNetworkObjList; typedef virNetworkObjList *virNetworkObjListPtr; @@ -59,67 +62,98 @@ virNetworkObjIsActive(const virNetworkObj *net) return net->active; } =20 -virNetworkObjListPtr virNetworkObjListNew(void); - -virNetworkObjPtr virNetworkObjFindByUUIDLocked(virNetworkObjListPtr nets, - const unsigned char *uuid); -virNetworkObjPtr virNetworkObjFindByUUID(virNetworkObjListPtr nets, - const unsigned char *uuid); -virNetworkObjPtr virNetworkObjFindByNameLocked(virNetworkObjListPtr nets, - const char *name); -virNetworkObjPtr virNetworkObjFindByName(virNetworkObjListPtr nets, - const char *name); -bool virNetworkObjTaint(virNetworkObjPtr obj, - virNetworkTaintFlags taint); - -typedef bool (*virNetworkObjListFilter)(virConnectPtr conn, - virNetworkDefPtr def); - -virNetworkObjPtr virNetworkAssignDef(virNetworkObjListPtr nets, - virNetworkDefPtr def, - unsigned int flags); -void virNetworkObjAssignDef(virNetworkObjPtr network, - virNetworkDefPtr def, - bool live); -int virNetworkObjSetDefTransient(virNetworkObjPtr network, bool live); -void virNetworkObjUnsetDefTransient(virNetworkObjPtr network); -virNetworkDefPtr virNetworkObjGetPersistentDef(virNetworkObjPtr network); -int virNetworkObjReplacePersistentDef(virNetworkObjPtr network, - virNetworkDefPtr def); -int virNetworkConfigChangeSetup(virNetworkObjPtr dom, unsigned int flags); - -void virNetworkRemoveInactive(virNetworkObjListPtr nets, - virNetworkObjPtr net); - -int virNetworkSaveStatus(const char *statusDir, - virNetworkObjPtr net) ATTRIBUTE_RETURN_CHECK; - -virNetworkObjPtr virNetworkLoadConfig(virNetworkObjListPtr nets, - const char *configDir, - const char *autostartDir, - const char *file); - -virNetworkObjPtr virNetworkLoadState(virNetworkObjListPtr nets, - const char *stateDir, - const char *name); - -int virNetworkLoadAllConfigs(virNetworkObjListPtr nets, - const char *configDir, - const char *autostartDir); - -int virNetworkLoadAllState(virNetworkObjListPtr nets, - const char *stateDir); - -int virNetworkDeleteConfig(const char *configDir, - const char *autostartDir, - virNetworkObjPtr net); - -char *virNetworkConfigFile(const char *dir, - const char *name); - -int virNetworkBridgeInUse(virNetworkObjListPtr nets, - const char *bridge, - const char *skipname); +virNetworkObjListPtr +virNetworkObjListNew(void); + +virNetworkObjPtr +virNetworkObjFindByUUIDLocked(virNetworkObjListPtr nets, + const unsigned char *uuid); + +virNetworkObjPtr +virNetworkObjFindByUUID(virNetworkObjListPtr nets, + const unsigned char *uuid); + +virNetworkObjPtr +virNetworkObjFindByNameLocked(virNetworkObjListPtr nets, + const char *name); + +virNetworkObjPtr +virNetworkObjFindByName(virNetworkObjListPtr nets, + const char *name); + +bool +virNetworkObjTaint(virNetworkObjPtr obj, + virNetworkTaintFlags taint); + +typedef bool +(*virNetworkObjListFilter)(virConnectPtr conn, + virNetworkDefPtr def); + +virNetworkObjPtr +virNetworkAssignDef(virNetworkObjListPtr nets, + virNetworkDefPtr def, + unsigned int flags); + +void +virNetworkObjAssignDef(virNetworkObjPtr network, + virNetworkDefPtr def, + bool live); + +int +virNetworkObjSetDefTransient(virNetworkObjPtr network, + bool live); + +void +virNetworkObjUnsetDefTransient(virNetworkObjPtr network); + +virNetworkDefPtr +virNetworkObjGetPersistentDef(virNetworkObjPtr network); + +int +virNetworkObjReplacePersistentDef(virNetworkObjPtr network, + virNetworkDefPtr def); + +int +virNetworkConfigChangeSetup(virNetworkObjPtr dom, + unsigned int flags); + +void +virNetworkRemoveInactive(virNetworkObjListPtr nets, + virNetworkObjPtr net); + +int +virNetworkSaveStatus(const char *statusDir, + virNetworkObjPtr net) ATTRIBUTE_RETURN_CHECK; + +virNetworkObjPtr +virNetworkLoadConfig(virNetworkObjListPtr nets, + const char *configDir, + const char *autostartDir, + const char *file); + +virNetworkObjPtr +virNetworkLoadState(virNetworkObjListPtr nets, + const char *stateDir, + const char *name); + +int +virNetworkLoadAllConfigs(virNetworkObjListPtr nets, + const char *configDir, + const char *autostartDir); + +int +virNetworkLoadAllState(virNetworkObjListPtr nets, + const char *stateDir); + +int +virNetworkDeleteConfig(const char *configDir, + const char *autostartDir, + virNetworkObjPtr net); + +int +virNetworkBridgeInUse(virNetworkObjListPtr nets, + const char *bridge, + const char *skipname); =20 int virNetworkObjUpdate(virNetworkObjPtr obj, @@ -129,32 +163,38 @@ virNetworkObjUpdate(virNetworkObjPtr obj, const char *xml, unsigned int flags); /* virNetworkUpdateFlags */ =20 -int virNetworkObjListExport(virConnectPtr conn, - virNetworkObjListPtr netobjs, - virNetworkPtr **nets, - virNetworkObjListFilter filter, - unsigned int flags); - -typedef int (*virNetworkObjListIterator)(virNetworkObjPtr net, - void *opaque); - -int virNetworkObjListForEach(virNetworkObjListPtr nets, - virNetworkObjListIterator callback, +int +virNetworkObjListExport(virConnectPtr conn, + virNetworkObjListPtr netobjs, + virNetworkPtr **nets, + virNetworkObjListFilter filter, + unsigned int flags); + +typedef int +(*virNetworkObjListIterator)(virNetworkObjPtr net, void *opaque); =20 -int virNetworkObjListGetNames(virNetworkObjListPtr nets, - bool active, - char **names, - int nnames, - virNetworkObjListFilter filter, - virConnectPtr conn); +int +virNetworkObjListForEach(virNetworkObjListPtr nets, + virNetworkObjListIterator callback, + void *opaque); =20 -int virNetworkObjListNumOfNetworks(virNetworkObjListPtr nets, - bool active, - virNetworkObjListFilter filter, - virConnectPtr conn); +int +virNetworkObjListGetNames(virNetworkObjListPtr nets, + bool active, + char **names, + int nnames, + virNetworkObjListFilter filter, + virConnectPtr conn); =20 -void virNetworkObjListPrune(virNetworkObjListPtr nets, - unsigned int flags); +int +virNetworkObjListNumOfNetworks(virNetworkObjListPtr nets, + bool active, + virNetworkObjListFilter filter, + virConnectPtr conn); + +void +virNetworkObjListPrune(virNetworkObjListPtr nets, + unsigned int flags); =20 #endif /* __VIRNETWORKOBJ_H__ */ --=20 2.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list