From nobody Sun Feb 8 16:24:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1491573138370789.7304617364122; Fri, 7 Apr 2017 06:52:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6CE40C04B946; Fri, 7 Apr 2017 13:52:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC6C788665; Fri, 7 Apr 2017 13:52:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B35A64BB75; Fri, 7 Apr 2017 13:52:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v37DqCve028162 for ; Fri, 7 Apr 2017 09:52:12 -0400 Received: by smtp.corp.redhat.com (Postfix) id 731C19ABF3; Fri, 7 Apr 2017 13:52:12 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-19.phx2.redhat.com [10.3.116.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 326E1A0C9F for ; Fri, 7 Apr 2017 13:52:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6CE40C04B946 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6CE40C04B946 From: John Ferlan To: libvir-list@redhat.com Date: Fri, 7 Apr 2017 09:52:09 -0400 Message-Id: <20170407135209.1403-1-jferlan@redhat.com> In-Reply-To: <20170407114959.22362-1-jferlan@redhat.com> References: <20170407114959.22362-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 3/3] disk: Force clearing of the first 2048 bytes of device prior to mklabel X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 07 Apr 2017 13:52:17 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" https://bugzilla.redhat.com/show_bug.cgi?id=3D1439132 During 'matrix' testing of all possible combinations I found that if device is formated with "gpt" first, then an attempt is made to format using "mac", a startup will fail. By adding a clearing of the first 2048 bytes of the device (similar to the logical pool code), the issue is resolved. Signed-off-by: John Ferlan --- Difference to v1 - just split it out and sent separately with it's own commit message. src/storage/storage_backend_disk.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/storage/storage_backend_disk.c b/src/storage/storage_backe= nd_disk.c index 39371f2..ce40ddd 100644 --- a/src/storage/storage_backend_disk.c +++ b/src/storage/storage_backend_disk.c @@ -496,6 +496,10 @@ virStorageBackendDiskBuildPool(virConnectPtr conn ATTR= IBUTE_UNUSED, } =20 if (ok_to_mklabel) { + if (virStorageBackendZeroDeviceHeader(pool->def->source.devices[0]= .path, + 4 * SECTOR_SIZE) < 0) + goto error; + /* eg parted /dev/sda mklabel --script msdos */ if (format =3D=3D VIR_STORAGE_POOL_DISK_UNKNOWN) format =3D pool->def->source.format =3D VIR_STORAGE_POOL_DISK_= DOS; --=20 2.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list