From nobody Sun Feb 8 19:40:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1491479323273882.0024545243319; Thu, 6 Apr 2017 04:48:43 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0C4B480508; Thu, 6 Apr 2017 11:48:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D02399A59D; Thu, 6 Apr 2017 11:48:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7F4C718523CC; Thu, 6 Apr 2017 11:48:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v36BmN3w029889 for ; Thu, 6 Apr 2017 07:48:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id 64112A8633; Thu, 6 Apr 2017 11:48:23 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-19.phx2.redhat.com [10.3.116.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21F02A861B for ; Thu, 6 Apr 2017 11:48:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0C4B480508 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0C4B480508 From: John Ferlan To: libvir-list@redhat.com Date: Thu, 6 Apr 2017 07:48:13 -0400 Message-Id: <20170406114814.31184-7-jferlan@redhat.com> In-Reply-To: <20170406114814.31184-1-jferlan@redhat.com> References: <20170406114814.31184-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 6/7] storage: Pass driver arg by ref X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 06 Apr 2017 11:48:42 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Alter virStoragePoolObjListExport in order to pass the drivers->pools by reference Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 8 ++++---- src/conf/virstorageobj.h | 2 +- src/storage/storage_driver.c | 2 +- src/test/test_driver.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index a9367a2..34a3225 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -1100,7 +1100,7 @@ virStoragePoolMatch(virStoragePoolObjPtr poolobj, =20 int virStoragePoolObjListExport(virConnectPtr conn, - virStoragePoolObjList poolobjs, + virStoragePoolObjListPtr poolobjs, virStoragePoolPtr **pools, virStoragePoolObjListFilter filter, unsigned int flags) @@ -1111,11 +1111,11 @@ virStoragePoolObjListExport(virConnectPtr conn, int ret =3D -1; size_t i; =20 - if (pools && VIR_ALLOC_N(tmp_pools, poolobjs.count + 1) < 0) + if (pools && VIR_ALLOC_N(tmp_pools, poolobjs->count + 1) < 0) goto cleanup; =20 - for (i =3D 0; i < poolobjs.count; i++) { - virStoragePoolObjPtr poolobj =3D poolobjs.objs[i]; + for (i =3D 0; i < poolobjs->count; i++) { + virStoragePoolObjPtr poolobj =3D poolobjs->objs[i]; virStoragePoolObjLock(poolobj); if ((!filter || filter(conn, poolobj->def)) && virStoragePoolMatch(poolobj, flags)) { diff --git a/src/conf/virstorageobj.h b/src/conf/virstorageobj.h index b651865..7c11910 100644 --- a/src/conf/virstorageobj.h +++ b/src/conf/virstorageobj.h @@ -191,7 +191,7 @@ virStoragePoolObjUnlock(virStoragePoolObjPtr obj); =20 int virStoragePoolObjListExport(virConnectPtr conn, - virStoragePoolObjList poolobjs, + virStoragePoolObjListPtr poolobjs, virStoragePoolPtr **pools, virStoragePoolObjListFilter filter, unsigned int flags); diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 9493da8..6b8bbb5 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -2653,7 +2653,7 @@ storageConnectListAllStoragePools(virConnectPtr conn, goto cleanup; =20 storageDriverLock(); - ret =3D virStoragePoolObjListExport(conn, driver->pools, pools, + ret =3D virStoragePoolObjListExport(conn, &driver->pools, pools, virConnectListAllStoragePoolsCheckAC= L, flags); storageDriverUnlock(); diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 1a6601e..a2a17ef 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4194,7 +4194,7 @@ testConnectListAllStoragePools(virConnectPtr conn, virCheckFlags(VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_ALL, -1); =20 testDriverLock(privconn); - ret =3D virStoragePoolObjListExport(conn, privconn->pools, pools, + ret =3D virStoragePoolObjListExport(conn, &privconn->pools, pools, NULL, flags); testDriverUnlock(privconn); =20 --=20 2.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list