[libvirt] [PATCH v2 00/10] hyperv: add support for Hyper-V 2012 and newer.

Dawid Zamirski posted 10 patches 6 years, 12 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170402045049.19631-1-dzamirski@datto.com
There is a newer version of this series
src/Makefile.am                       |   2 -
src/hyperv/hyperv_driver.c            | 168 ++++++++-------
src/hyperv/hyperv_private.h           |   8 +-
src/hyperv/hyperv_wmi.c               | 173 +++++++++++----
src/hyperv/hyperv_wmi.h               |  56 ++++-
src/hyperv/hyperv_wmi_classes.h       |  30 +++
src/hyperv/hyperv_wmi_generator.input | 239 ++++++++++++++++++---
src/hyperv/hyperv_wmi_generator.py    | 385 +++++++++++++++++++++++++---------
8 files changed, 810 insertions(+), 251 deletions(-)
[libvirt] [PATCH v2 00/10] hyperv: add support for Hyper-V 2012 and newer.
Posted by Dawid Zamirski 6 years, 12 months ago
Hello,

This is v2 with all the code review feedback addressed. Please see the
cover letter in v1 here: 
https://www.redhat.com/archives/libvir-list/2017-March/msg01624.html

Changes in v2:
* checked each patch with make syntax-check individually
* fixed missing notices in hyperv_wmi_generator.py
* addressed an issue where a case of "v2-only" WMI classes was not
  handled properly.


Patches 5-10 should be squashed onto 4 - those won't compile
individually as the code is too inter-dependent and are kept separately
just for review puroposes.

Regards,

Dawid Zamirski (10):
  hyperv: store WMI version in hypervPrivate.
  hyperv: introduce hypervWmiClassInfo struct.
  hyperv: update hypervObject struct.
  hyperv: add hypervWqlQuery struct.
  hyperv: make hypervEnumAndPull use hypervWqlQuery
  hyperv: update generator input file.
  hyperv: update wmi code generator.
  hyperv: add helper for getting WMI class lists.
  hyperv: port rest of the driver to new stucts.
  hyperv: add hypervInitConnection.

 src/Makefile.am                       |   2 -
 src/hyperv/hyperv_driver.c            | 168 ++++++++-------
 src/hyperv/hyperv_private.h           |   8 +-
 src/hyperv/hyperv_wmi.c               | 173 +++++++++++----
 src/hyperv/hyperv_wmi.h               |  56 ++++-
 src/hyperv/hyperv_wmi_classes.h       |  30 +++
 src/hyperv/hyperv_wmi_generator.input | 239 ++++++++++++++++++---
 src/hyperv/hyperv_wmi_generator.py    | 385 +++++++++++++++++++++++++---------
 8 files changed, 810 insertions(+), 251 deletions(-)

-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 00/10] hyperv: add support for Hyper-V 2012 and newer.
Posted by Matthias Bolte 6 years, 11 months ago
2017-04-02 6:50 GMT+02:00 Dawid Zamirski <dzamirski@datto.com>:
> Hello,
>
> This is v2 with all the code review feedback addressed. Please see the
> cover letter in v1 here:
> https://www.redhat.com/archives/libvir-list/2017-March/msg01624.html
>
> Changes in v2:
> * checked each patch with make syntax-check individually
> * fixed missing notices in hyperv_wmi_generator.py
> * addressed an issue where a case of "v2-only" WMI classes was not
>   handled properly.

There is one final question one patch 9/10.

One thing that's missing is a potential documentation update (see
docs/drvhyperv.html.in) and an addition to the news file (see
docs/news.xml)

-- 
Matthias Bolte
http://photron.blogspot.com

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 00/10] hyperv: add support for Hyper-V 2012 and newer.
Posted by Dawid Zamirski 6 years, 11 months ago
On Tue, 2017-04-04 at 00:11 +0200, Matthias Bolte wrote:
> 2017-04-02 6:50 GMT+02:00 Dawid Zamirski <dzamirski@datto.com>:
> > Hello,
> > 
> > This is v2 with all the code review feedback addressed. Please see
> > the
> > cover letter in v1 here:
> > https://www.redhat.com/archives/libvir-list/2017-March/msg01624.htm
> > l
> > 
> > Changes in v2:
> > * checked each patch with make syntax-check individually
> > * fixed missing notices in hyperv_wmi_generator.py
> > * addressed an issue where a case of "v2-only" WMI classes was not
> >   handled properly.
> 
> There is one final question one patch 9/10.
> 
> One thing that's missing is a potential documentation update (see
> docs/drvhyperv.html.in) and an addition to the news file (see
> docs/news.xml)
> 

Ok, I've just posted v3 addressing those:
https://www.redhat.com/archives/libvir-list/2017-April/msg00071.html

Thanks a lot for taking time to review my code and catching bugs :-)

Regards,
Dawid

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list