[libvirt] [PATCH] docs: make interface start mode element optional

Laine Stump posted 1 patch 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170327045259.19349-1-laine@laine.org
docs/schemas/interface.rng | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
[libvirt] [PATCH] docs: make interface start mode element optional
Posted by Laine Stump 7 years ago
This brings the libvirt version of this RNG file in line with the same
file in netcf (as soon as the corresponding patch there is ACKed and
pushed).

There's no reason to require it when defining an interface (the config
option it corresponds to is optional), and it isn't even output in the
status of an interface.

Resolves: https://bugzilla.redhat.com/1414404
---
 docs/schemas/interface.rng | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/docs/schemas/interface.rng b/docs/schemas/interface.rng
index 052703c..4bb08e9 100644
--- a/docs/schemas/interface.rng
+++ b/docs/schemas/interface.rng
@@ -279,17 +279,19 @@
   </define>
 
   <define name="startmode">
-    <element name="start">
-      <attribute name="mode">
-        <choice>
-          <value>onboot</value>
-          <value>none</value>
-          <value>hotplug</value>
-          <!-- Jim Fehlig lists the following that SuSe supports:
-               manual, ifplug, nfsroot -->
-        </choice>
-      </attribute>
-    </element>
+    <optional>
+      <element name="start">
+        <attribute name="mode">
+          <choice>
+            <value>onboot</value>
+            <value>none</value>
+            <value>hotplug</value>
+            <!-- Jim Fehlig lists the following that SuSe supports:
+                 manual, ifplug, nfsroot -->
+          </choice>
+        </attribute>
+      </element>
+    </optional>
   </define>
 
   <!--
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] docs: make interface start mode element optional
Posted by Martin Kletzander 7 years ago
On Mon, Mar 27, 2017 at 12:52:59AM -0400, Laine Stump wrote:
>This brings the libvirt version of this RNG file in line with the same
>file in netcf (as soon as the corresponding patch there is ACKed and
>pushed).
>
>There's no reason to require it when defining an interface (the config
>option it corresponds to is optional), and it isn't even output in the
>status of an interface.
>

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list