From nobody Sat May 4 03:01:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 149051699110768.04896999692335; Sun, 26 Mar 2017 01:29:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C707041A2B; Sun, 26 Mar 2017 08:29:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A1437BA889; Sun, 26 Mar 2017 08:29:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E9B48B3481; Sun, 26 Mar 2017 08:29:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v2Q4luHe003561 for ; Sun, 26 Mar 2017 00:47:56 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1577C19653; Sun, 26 Mar 2017 04:47:56 +0000 (UTC) Received: from mx1.redhat.com (ext-mx08.extmail.prod.ext.phx2.redhat.com [10.5.110.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E6F47D57D for ; Sun, 26 Mar 2017 04:47:54 +0000 (UTC) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 32E04C05683F for ; Sun, 26 Mar 2017 04:47:52 +0000 (UTC) Received: by mail-lf0-f51.google.com with SMTP id h125so8303184lfe.0 for ; Sat, 25 Mar 2017 21:47:51 -0700 (PDT) Received: from kloomba.my.domain ([31.29.231.57]) by smtp.gmail.com with ESMTPSA id e13sm1223163lfb.14.2017.03.25.21.47.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Mar 2017 21:47:48 -0700 (PDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C707041A2B Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C707041A2B Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W7j8PSlx" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 32E04C05683F Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=bogorodskiy@gmail.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 32E04C05683F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=kysMa5itXSu8Il9VG4sam4JE38/Wtt0r1Ro7XsaZhEE=; b=W7j8PSlxACTSNu5UFxxc8cCTo/P4mI0qL7klUgps3nlpFWtp8LjHHQqvUa0eVjCEAh tXEhFI6Z+Ee8I6IHymfHgFb/SwiHWPc11j1ZbmzMba4aCrhycqYMuV0AZMUeSfdy5Ptf 21DEcdrTgrJfl9zQEgH6EO4AJB7jd34Yda27KJBOxjbmYhJp/tY8PjyJminnHK7WG8o2 eHYxecYqITmg0ntq3nJME0HqVmENgCS0GDXRNStjoSom9f70oaX3j4mfJdNdJDs6WQS0 7iNNBFJeEyMlUoXsC+r8/wS/HCSsP2uj4huyzKrbRcyKNQE6vDo+28nQPYrwI/e/xI4/ ulAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kysMa5itXSu8Il9VG4sam4JE38/Wtt0r1Ro7XsaZhEE=; b=nlP00AK3d7svVAPcNDjKgXe8tIzbd2zBMd7iCGIjVm+23t5b04WBynYir1coYe7ROL ejIyxCBSR5WUFZ+ArtYzu+7T370qtgyWejOL9nQrOxD7BQtoyMBH2qX5b1cm960H5+2L Im/ZYKObtHIMxrTK+fXaxk/n00u1S0H2XxAHurpm3PcNUpg2lNiBYT4VHNv8fGep8Hnq iyt88Ee+0O59jy8qqX7I8wBrdqeouvGpH57nvdmNy9r1eN/sMmNbetrQGINbmE2xTGrG QKGXUziPvqffhq8wBtZXLir5LckR/r92JFE8FzO+LbBCIm/HUpH/YgrcRUKp9js5Hpm3 2nTA== X-Gm-Message-State: AFeK/H1jYuqtkq3+spZf9Lgh6ZYcdEVYDJHGqT7S1/CpgpTgNmmug5soexjxpCdWgRHpwA== X-Received: by 10.25.32.9 with SMTP id g9mr7752382lfg.7.1490503668971; Sat, 25 Mar 2017 21:47:48 -0700 (PDT) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Sun, 26 Mar 2017 08:47:43 +0400 Message-Id: <20170326044743.31786-1-bogorodskiy@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sun, 26 Mar 2017 04:47:52 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sun, 26 Mar 2017 04:47:52 +0000 (UTC) for IP:'209.85.215.51' DOMAIN:'mail-lf0-f51.google.com' HELO:'mail-lf0-f51.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.27 (BAYES_50, DCC_REPUT_00_12, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.215.51 mail-lf0-f51.google.com 209.85.215.51 mail-lf0-f51.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.32 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH] qemu: fix build with clang X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Sun, 26 Mar 2017 08:29:51 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" qemuMigrationResetTLS() does not initialize 'ret' by default, so when it jumps to 'cleanup' on error, the 'ret' variable will be uninitialized, which clang complains about. Set it to '-1' by default. --- Pushed under the build-breaker rule. src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index d91279ec6..a69e8784a 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -3815,7 +3815,7 @@ qemuMigrationResetTLS(virQEMUDriverPtr driver, char *tlsAlias =3D in_tlsAlias; char *secAlias =3D in_secAlias; qemuMonitorMigrationParams migParams =3D { 0 }; - int ret; + int ret =3D -1; =20 /* If coming from a path that doesn't know whether it's been used or n= ot, * let's first check we need to do this. If the tls-creds doesn't exist --=20 2.11.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list