From nobody Mon Feb 9 08:54:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.24 as permitted sender) client-ip=209.132.183.24; envelope-from=libvir-list-bounces@redhat.com; helo=mx3-phx2.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.24 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by mx.zohomail.com with SMTPS id 148863344091638.28546513296067; Sat, 4 Mar 2017 05:17:20 -0800 (PST) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v24DDOt4012111; Sat, 4 Mar 2017 08:13:24 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v24DChEs029295 for ; Sat, 4 Mar 2017 08:12:43 -0500 Received: from localhost.localdomain.com (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v24DCe06009154 for ; Sat, 4 Mar 2017 08:12:42 -0500 From: John Ferlan To: libvir-list@redhat.com Date: Sat, 4 Mar 2017 08:12:35 -0500 Message-Id: <20170304131235.2057-5-jferlan@redhat.com> In-Reply-To: <20170304131235.2057-1-jferlan@redhat.com> References: <20170304131235.2057-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/4] conf: Alter coding style of interface function prototypes X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" In an effort to be consistent with the source module, alter the function prototypes to follow the similar style of source with the "type" on one line followed by the function name and arguments on subsequent lines with with argument getting it's own line. Signed-off-by: John Ferlan --- src/conf/interface_conf.h | 19 ++++++++++++------ src/conf/virinterfaceobj.h | 48 ++++++++++++++++++++++++++++++------------= ---- 2 files changed, 44 insertions(+), 23 deletions(-) diff --git a/src/conf/interface_conf.h b/src/conf/interface_conf.h index 7325d65..76f37b6 100644 --- a/src/conf/interface_conf.h +++ b/src/conf/interface_conf.h @@ -161,14 +161,21 @@ struct _virInterfaceDef { virInterfaceProtocolDefPtr *protos; /* ptr to array of protos[nprotos]= */ }; =20 -void virInterfaceDefFree(virInterfaceDefPtr def); +void +virInterfaceDefFree(virInterfaceDefPtr def); =20 -virInterfaceDefPtr virInterfaceDefParseString(const char *xmlStr); -virInterfaceDefPtr virInterfaceDefParseFile(const char *filename); -virInterfaceDefPtr virInterfaceDefParseNode(xmlDocPtr xml, - xmlNodePtr root); +virInterfaceDefPtr +virInterfaceDefParseString(const char *xmlStr); =20 -char *virInterfaceDefFormat(const virInterfaceDef *def); +virInterfaceDefPtr +virInterfaceDefParseFile(const char *filename); + +virInterfaceDefPtr +virInterfaceDefParseNode(xmlDocPtr xml, + xmlNodePtr root); + +char * +virInterfaceDefFormat(const virInterfaceDef *def); =20 # define VIR_CONNECT_LIST_INTERFACES_FILTERS_ACTIVE \ (VIR_CONNECT_LIST_INTERFACES_ACTIVE | \ diff --git a/src/conf/virinterfaceobj.h b/src/conf/virinterfaceobj.h index dfda748..6c5e2e7 100644 --- a/src/conf/virinterfaceobj.h +++ b/src/conf/virinterfaceobj.h @@ -44,27 +44,41 @@ virInterfaceObjIsActive(const virInterfaceObj *iface) return iface->active; } =20 -int virInterfaceObjFindByMACString(virInterfaceObjListPtr interfaces, - const char *mac, - virInterfaceObjPtr *matches, int maxmat= ches); -virInterfaceObjPtr virInterfaceObjFindByName(virInterfaceObjListPtr interf= aces, - const char *name); +int +virInterfaceObjFindByMACString(virInterfaceObjListPtr interfaces, + const char *mac, + virInterfaceObjPtr *matches, int maxmatches= ); =20 +virInterfaceObjPtr +virInterfaceObjFindByName(virInterfaceObjListPtr interfaces, + const char *name); =20 -void virInterfaceObjFree(virInterfaceObjPtr iface); -void virInterfaceObjListFree(virInterfaceObjListPtr vms); -int virInterfaceObjListClone(virInterfaceObjListPtr src, - virInterfaceObjListPtr dest); +void +virInterfaceObjFree(virInterfaceObjPtr iface); =20 +void +virInterfaceObjListFree(virInterfaceObjListPtr vms); =20 -virInterfaceObjPtr virInterfaceObjAssignDef(virInterfaceObjListPtr interfa= ces, - virInterfaceDefPtr def); -void virInterfaceObjRemove(virInterfaceObjListPtr interfaces, - virInterfaceObjPtr iface); +int +virInterfaceObjListClone(virInterfaceObjListPtr src, + virInterfaceObjListPtr dest); =20 -void virInterfaceObjLock(virInterfaceObjPtr obj); -void virInterfaceObjUnlock(virInterfaceObjPtr obj); +virInterfaceObjPtr +virInterfaceObjAssignDef(virInterfaceObjListPtr interfaces, + virInterfaceDefPtr def); + +void +virInterfaceObjRemove(virInterfaceObjListPtr interfaces, + virInterfaceObjPtr iface); + +void +virInterfaceObjLock(virInterfaceObjPtr obj); + +void +virInterfaceObjUnlock(virInterfaceObjPtr obj); + +typedef bool +(*virInterfaceObjListFilter)(virConnectPtr conn, + virInterfaceDefPtr def); =20 -typedef bool (*virInterfaceObjListFilter)(virConnectPtr conn, - virInterfaceDefPtr def); #endif /* __VIRINTERFACEOBJ_H__ */ --=20 2.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list