From nobody Sat Apr 27 05:01:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.24 as permitted sender) client-ip=209.132.183.24; envelope-from=libvir-list-bounces@redhat.com; helo=mx3-phx2.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.24 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by mx.zohomail.com with SMTPS id 1486802093117571.9852270873031; Sat, 11 Feb 2017 00:34:53 -0800 (PST) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v1B8VILm009415; Sat, 11 Feb 2017 03:31:19 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v1B8VHAg005091 for ; Sat, 11 Feb 2017 03:31:17 -0500 Received: from mx1.redhat.com (ext-mx05.extmail.prod.ext.phx2.redhat.com [10.5.110.29]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1B8VG3K022878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sat, 11 Feb 2017 03:31:16 -0500 Received: from mail-pg0-f53.google.com (mail-pg0-f53.google.com [74.125.83.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C2EB6461C3 for ; Sat, 11 Feb 2017 08:31:15 +0000 (UTC) Received: by mail-pg0-f53.google.com with SMTP id 14so17514346pgg.1 for ; Sat, 11 Feb 2017 00:31:14 -0800 (PST) Received: from localhost.net ([2601:647:4501:a0d1::82a9]) by smtp.googlemail.com with ESMTPSA id t22sm3318476pfa.114.2017.02.11.00.31.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Feb 2017 00:31:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=uaLrBXYKboI2D9NzQ9UoQOhmHUcac9z/SYmrW3OtF6k=; b=r1Re7XMyNs4+AYcgxKxTtWopSWihmcygAUTxuY9o4F+RGdCE+Q8kk+XnRt70+7Fiva G+EeXHrMyKya+Lm7y7arewDiqIqn5C+NtKz1MvfcYu/eKSO1pKGiuMnU8THPBxCyUqyF +WfnGhU43co00kHlbctkI+/EWBRLFuNy5/QBqSAZKUPj2OaoJl6nt0SLGeMcH+7psyZA reGEJ7MvsnDBN1RZgOnUl3p5TdMYJBdQGjkVJugtJkrT8K249dB2tJ7mqH7Ww+JlsTpA KWTcFRXh3Y9cjoPA/7cZ8V+42Z6XVQlj8VxdhTrQx7MCMJhsre+DGOJqv4DOq71jzb56 ir1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=uaLrBXYKboI2D9NzQ9UoQOhmHUcac9z/SYmrW3OtF6k=; b=AI6SEbf7zesdr2LriPaW3uN05n2NilNbiK4j/6xPjl+7uPZylqhAuhrJys+VyqKpoj 7mqxmTwX/iaMOsVd5tfxn8g1Md4MtvfqCFprvHCe/Ngn9N7R/tFhQm2hnBM6rtd3YhUa C8/JZg1Xer7hX2LH2epXTCX3KxDKY4cvAiN5mHA28hbctGA6Z6ZyPLUD4Q6aIX4pPKPQ XJ7SpeQjMIa0DTufwCZ3pQV6VIc/k7vp/F0tB5+V4vpXZdO0e/pBO4HbBzPyCXXo3eJ6 5yjCvB2arI1SEUweWtEXc1cE2pPdPAaZcSjzCp2A7AyQo6DX8ed/TnaVMcEq6RFye76S ig5Q== X-Gm-Message-State: AMke39kjfW/+6uusJAb3LB3WX6e1fhmngQBbY8vBYC3n4yzVJIHHL6AWwiDehYfkxxO8kg== X-Received: by 10.84.241.66 with SMTP id u2mr16914116plm.107.1486801873954; Sat, 11 Feb 2017 00:31:13 -0800 (PST) From: Sagar Ghuge To: libvir-list@redhat.com Date: Sat, 11 Feb 2017 00:31:03 -0800 Message-Id: <20170211083103.24283-1-ghugesss@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sat, 11 Feb 2017 08:31:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sat, 11 Feb 2017 08:31:15 +0000 (UTC) for IP:'74.125.83.53' DOMAIN:'mail-pg0-f53.google.com' HELO:'mail-pg0-f53.google.com' FROM:'ghugesss@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.27 (BAYES_50, DCC_REPUT_00_12, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 74.125.83.53 mail-pg0-f53.google.com 74.125.83.53 mail-pg0-f53.google.com X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.29 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] libxl: implement virDomainObjCheckIsActive X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Add function which raises error if domain is not active Signed-off-by: Sagar Ghuge --- src/conf/domain_conf.c | 13 +++++++++++++ src/conf/domain_conf.h | 1 + src/libxl/libxl_driver.c | 4 +--- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1bc72a4..10a69af 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2995,6 +2995,19 @@ virDomainObjWait(virDomainObjPtr vm) } =20 =20 +int +virDomainObjCheckIsActive(virDomainObjPtr vm) +{ + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("domain is not running")); + return -1; + } + + return 0; +} + + /** * Waits for domain condition to be triggered for a specific period of tim= e. * diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index dd79206..b6c7826 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2559,6 +2559,7 @@ bool virDomainObjTaint(virDomainObjPtr obj, =20 void virDomainObjBroadcast(virDomainObjPtr vm); int virDomainObjWait(virDomainObjPtr vm); +int virDomainObjCheckIsActive(virDomainObjPtr vm); int virDomainObjWaitUntil(virDomainObjPtr vm, unsigned long long whenms); =20 diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 74cb05a..3a487ac 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -1183,10 +1183,8 @@ libxlDomainSuspend(virDomainPtr dom) if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0) goto cleanup; =20 - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("Domain is not r= unning")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } =20 if (virDomainObjGetState(vm, NULL) !=3D VIR_DOMAIN_PAUSED) { if (libxl_domain_pause(cfg->ctx, vm->def->id) !=3D 0) { --=20 2.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list