[libvirt] [PATCH] virtlockd: fix systemd unit file dependancies

Daniel P. Berrange posted 1 patch 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170203114855.12627-1-berrange@redhat.com
daemon/libvirtd.service.in       | 1 +
src/locking/virtlockd.service.in | 1 +
src/locking/virtlockd.socket.in  | 1 +
3 files changed, 3 insertions(+)
[libvirt] [PATCH] virtlockd: fix systemd unit file dependancies
Posted by Daniel P. Berrange 7 years, 1 month ago
After deploying virtlogd by default we identified a number of
mistakes in the systemd unit file. virtlockd's relationship
to libvirtd is the same as virtlogd, so we must apply the
same unit file fixes to virtlockd

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 daemon/libvirtd.service.in       | 1 +
 src/locking/virtlockd.service.in | 1 +
 src/locking/virtlockd.socket.in  | 1 +
 3 files changed, 3 insertions(+)

diff --git a/daemon/libvirtd.service.in b/daemon/libvirtd.service.in
index bbf27da..c72dde5 100644
--- a/daemon/libvirtd.service.in
+++ b/daemon/libvirtd.service.in
@@ -6,6 +6,7 @@
 [Unit]
 Description=Virtualization daemon
 Requires=virtlogd.socket
+Requires=virtlockd.socket
 Before=libvirt-guests.service
 After=network.target
 After=dbus.service
diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in
index 57089b0..69b568f 100644
--- a/src/locking/virtlockd.service.in
+++ b/src/locking/virtlockd.service.in
@@ -1,6 +1,7 @@
 [Unit]
 Description=Virtual machine lock manager
 Requires=virtlockd.socket
+Before=libvirtd.service
 Documentation=man:virtlockd(8)
 Documentation=http://libvirt.org
 
diff --git a/src/locking/virtlockd.socket.in b/src/locking/virtlockd.socket.in
index 9808bbb..45e0f20 100644
--- a/src/locking/virtlockd.socket.in
+++ b/src/locking/virtlockd.socket.in
@@ -1,5 +1,6 @@
 [Unit]
 Description=Virtual machine lock manager socket
+Before=libvirtd.service
 
 [Socket]
 ListenStream=@localstatedir@/run/libvirt/virtlockd-sock
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] virtlockd: fix systemd unit file dependancies
Posted by Peter Krempa 7 years, 1 month ago
On Fri, Feb 03, 2017 at 11:48:55 +0000, Daniel Berrange wrote:
> After deploying virtlogd by default we identified a number of
> mistakes in the systemd unit file. virtlockd's relationship
> to libvirtd is the same as virtlogd, so we must apply the
> same unit file fixes to virtlockd
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  daemon/libvirtd.service.in       | 1 +
>  src/locking/virtlockd.service.in | 1 +
>  src/locking/virtlockd.socket.in  | 1 +
>  3 files changed, 3 insertions(+)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] virtlockd: fix systemd unit file dependancies
Posted by Andrea Bolognani 7 years, 1 month ago
On Fri, 2017-02-03 at 11:48 +0000, Daniel P. Berrange wrote:
> After deploying virtlogd by default we identified a number of
> mistakes in the systemd unit file. virtlockd's relationship
> to libvirtd is the same as virtlogd, so we must apply the
> same unit file fixes to virtlockd

ACK

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list