From nobody Tue Oct 28 17:34:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1760024302; cv=none; d=zohomail.com; s=zohoarc; b=NovbSA8k4gpPBooHkkaa3QwDknbolt5y8JbuNtNven9h6+rRNbPVrxDfiTbmFwj4bYiCf2BoOTOcrXZN9u3iUv5HMMpVPSkZs1t95R1oXW7c2ciQ8Mc31CrPsSC25h/TNz9SoaayfSxiLIDUaof9tDA8PdMdhNqm8tTSIR5fPqc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760024302; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=+3O8c78Gi19iPsV0gzOK70JJ3M4Rs22E3fP98SXg2B8=; b=L5o4KkopEoKsDwHryxA2sDryQnJNthJq3/DX5F1/2z1jKMX6gdOSNTmRQyOD1jk8PJv1tb3BAegSpl9KPPD6wcm7qMmfqN7b6FAmxpv+nDH8v5PXddffSsMhCUXJsav23f8j9dBphaUc8Vea2JHe2jJLO5tElDNRmsBAhZFa2Dc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 176002430275074.33781495343453; Thu, 9 Oct 2025 08:38:22 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 2109444350; Thu, 9 Oct 2025 11:38:22 -0400 (EDT) Received: from [172.19.199.20] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 277FE44AC0; Thu, 9 Oct 2025 11:17:58 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C22594434E; Thu, 9 Oct 2025 11:17:49 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id ADEB643F04 for ; Thu, 9 Oct 2025 11:16:40 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-Ot7i4WaxPROXTdWnTVvT-A-1; Thu, 09 Oct 2025 11:16:38 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4FDC119560AD for ; Thu, 9 Oct 2025 15:16:37 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.12]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 879641955F22 for ; Thu, 9 Oct 2025 15:16:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760023000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+3O8c78Gi19iPsV0gzOK70JJ3M4Rs22E3fP98SXg2B8=; b=MEDkbmlT1VIH/avTvfMHKDA5Zm92khqCHcNl4dxvpJUkhST5LG6hi+E8snH3EhogHw13Dw 2fv+QyIU3c4YYVeCnuCg74rCKuk8teULrEnB4XnDqr1hTnP71Jyj7UkPxvCl9luWuk0X5U uzu4eIezxOD7FLYPuXelT9Nt8g7Redc= X-MC-Unique: Ot7i4WaxPROXTdWnTVvT-A-1 X-Mimecast-MFC-AGG-ID: Ot7i4WaxPROXTdWnTVvT-A_1760022997 To: devel@lists.libvirt.org Subject: [RFC PATCH 14/16] qemu: capabilities: Introduce QEMU_CAPS_DISK_TIMED_STATS Date: Thu, 9 Oct 2025 17:16:14 +0200 Message-ID: <1fe8e808e605c6ad5505bbb6ae97e2061fbaf5ed.1760022633.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0_8fJSuwLgK_2rWJNcfEP0X8TonvYBFTCoNBFUxDVbQ_1760022997 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FBSCOYLERFTKSU2BBLU2PLHQ34BI6Y52 X-Message-ID-Hash: FBSCOYLERFTKSU2BBLU2PLHQ34BI6Y52 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1760024305223154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The capability tracks support for 'stats-intervals' property of disk frontends which enables statistics collection on the devices. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 5 +++++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_10.2.0_x86_64.xml | 1 + 3 files changed, 7 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 618291e5b6..7d643c5357 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -746,6 +746,7 @@ VIR_ENUM_IMPL(virQEMUCaps, /* 485 */ "acpi-generic-initiator", /* QEMU_CAPS_ACPI_GENERIC_INITIATO= R */ + "disk-timed-stats", /* QEMU_CAPS_DISK_TIMED_STATS */ ); @@ -1478,6 +1479,7 @@ static struct virQEMUCapsDevicePropsFlags virQEMUCaps= DevicePropsVirtioBlk[] =3D { { "queue-size", QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE, NULL }, { "acpi-index", QEMU_CAPS_ACPI_INDEX, NULL }, { "iothread-vq-mapping", QEMU_CAPS_VIRTIO_BLK_IOTHREAD_MAPPING, NULL }, + { "stats-intervals", QEMU_CAPS_DISK_TIMED_STATS, NULL }, }; static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsVirtioNet[= ] =3D { @@ -1509,9 +1511,11 @@ static struct virQEMUCapsDevicePropsFlags virQEMUCap= sDevicePropsVfioPCI[] =3D { static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsSCSIDisk[]= =3D { { "channel", QEMU_CAPS_SCSI_DISK_CHANNEL, NULL }, { "rotation_rate", QEMU_CAPS_ROTATION_RATE, NULL }, + { "stats-intervals", QEMU_CAPS_DISK_TIMED_STATS, NULL }, }; static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsIDEDrive[]= =3D { + { "stats-intervals", QEMU_CAPS_DISK_TIMED_STATS, NULL }, }; static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsPiix4PM[] = =3D { @@ -1523,6 +1527,7 @@ static struct virQEMUCapsDevicePropsFlags virQEMUCaps= DevicePropsUSBRedir[] =3D { }; static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsUSBStorage= [] =3D { + { "stats-intervals", QEMU_CAPS_DISK_TIMED_STATS, NULL }, }; static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsKVMPit[] = =3D { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index c71fc19a03..3e9963bb85 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -727,6 +727,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for = syntax-check */ /* 485 */ QEMU_CAPS_ACPI_GENERIC_INITIATOR, /* -object acpi-generic-initiator */ + QEMU_CAPS_DISK_TIMED_STATS, /* timed stats support ('stats-intervals' = property of disk frontends) */ QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/tests/qemucapabilitiesdata/caps_10.2.0_x86_64.xml b/tests/qemu= capabilitiesdata/caps_10.2.0_x86_64.xml index 59d33c7049..49fdb6edba 100644 --- a/tests/qemucapabilitiesdata/caps_10.2.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_10.2.0_x86_64.xml @@ -215,6 +215,7 @@ + 10001050 43100287 v10.1.0-1063-g3bf55b83ef --=20 2.51.0