From nobody Sun Feb 8 07:15:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1554993341; cv=none; d=zoho.com; s=zohoarc; b=Y8alDKtVHd/GRUsgXP7HtkLOstaEh/VogxzeMtDZmsgBzoQ7mmfeLVG+i0T3aws+jwonL+R+NnmC/QtyeY1NnJXdcos4Rwlxc7U2M6lM21GrJ+B9c8r/EYe+3a3yFN3SxDD9sw+e73hhpE0YoW13vpBKWXKyRmgcCWpMAjusyhE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1554993341; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=1X/aEKZUjjDTQnZfXNNU+itGHDgzd0/vhbKQ8SLRAF4=; b=AE0bhl4lQzvg6qSPBCaHuRJRFKOVdgzlT7hD99qe1x28VCLLDp8Y6I1B+p+ZEtFclO/rUcxMa1Emgjb0DMIFyCnRf0S3AGqaUBKy3RZLekImNQX4zHXs6RbZQou6TX0iskfXf2oKIQGjrpPDrSV7iMmBiN5KC/6Z0m/Ei1lOrB8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1554993341521157.39772539987348; Thu, 11 Apr 2019 07:35:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C2129C023B; Thu, 11 Apr 2019 14:35:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08A8217BB6; Thu, 11 Apr 2019 14:35:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C0E03181AC46; Thu, 11 Apr 2019 14:35:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3BEZBZF006428 for ; Thu, 11 Apr 2019 10:35:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4912B1001DEA; Thu, 11 Apr 2019 14:35:11 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E16D1001943; Thu, 11 Apr 2019 14:35:10 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 11 Apr 2019 16:35:00 +0200 Message-Id: <1eb4268e9191f03fdfcd9b569bbb1fcffedfa070.1554993076.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: danielhb413@gmail.com Subject: [libvirt] [PATCH 4/4] Revert "domain_conf: check device address before attach" X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 11 Apr 2019 14:35:40 +0000 (UTC) Content-Type: text/plain; charset="utf-8" This reverts commit f1d6585300001c7b23b8796a0faa4411c3531996. Turns out, this caused a regression. There is this (perhaps less known) semantic of virDomainAttachDevice() where if the device the API is trying to attach is a CDROM/floppy that is already in the domain the attach request is handled as 'change the media in the drive'. We have a better fix anyways. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index bce4e65e0d..14d3f4d67e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -28586,15 +28586,6 @@ virDomainDefCompatibleDevice(virDomainDefPtr def, if (oldDev) data.oldInfo =3D virDomainDeviceGetInfo(oldDev); =20 - if (action =3D=3D VIR_DOMAIN_DEVICE_ACTION_ATTACH && - data.newInfo && - data.newInfo->type !=3D VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE && - virDomainDefHasDeviceAddress(def, data.newInfo)) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("Domain already contains a device with the same a= ddress")); - return -1; - } - if (action =3D=3D VIR_DOMAIN_DEVICE_ACTION_UPDATE && live && (data.newInfo && data.oldInfo && --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list