From nobody Sun Feb 8 21:33:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1691059005; cv=none; d=zohomail.com; s=zohoarc; b=UQDlwPw+uCAbVT3nvVHn0p0uYxgdPJBt2of0oWba7YypdmOCfT1L/SIECS1ZEcsfrIVYFkfuWKbfkvsNT5T+K6Txm9SE7Pm5qriX+F6LIF/XjQX8rbZMIB2k93fo+/hin3we7SmWi8ue+r0Ywy4G/PSQlukSnQeRguYaQWo0dMc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691059005; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hxOs7YtgR84U47vE/hHwr+FZr96D6spjVX/r9M0irC4=; b=AxsF4+PfczBkZeir5EBvHWef6MLiQZGvsoPm/ZVVn1bMEusf3ryGK+L8q0Q8vP6s+ch5dDgaf/uM3nBNY7Qul2xHUF/95DdgSRFQg7BMQeLQP7JKKwDZD9WBcmQTIaqKmVASJAheI11RisMtrbrBko8PDohCuFY+EQ+VKuRa8Yc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1691059005717416.9792589550949; Thu, 3 Aug 2023 03:36:45 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-215-sLsd_tvhNJig3yD7tzkjEw-1; Thu, 03 Aug 2023 06:36:36 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BE3038870D8; Thu, 3 Aug 2023 10:36:33 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id ABF7540C2071; Thu, 3 Aug 2023 10:36:33 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 66D7C19451C4; Thu, 3 Aug 2023 10:36:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DC8C01947218 for ; Thu, 3 Aug 2023 10:36:25 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id C1A9CF7FB4; Thu, 3 Aug 2023 10:36:25 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 68D5EF7FA6 for ; Thu, 3 Aug 2023 10:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691059001; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=hxOs7YtgR84U47vE/hHwr+FZr96D6spjVX/r9M0irC4=; b=aoQQkykNhJUNC9fcNyjrYl4MVT0rO+sh2hrk9d/jhAhmvBrfK8CbE/lxWv5GPHo+mNPhy9 8a328+qMJdEsFOXtL0tegeCNXF9lbSScqSXXT3Qb34T668jdSON5ppu3JuX4LySpZaD/wx EgEVuqmmZubpTQ7HhqjXqdE9TBTvRPM= X-MC-Unique: sLsd_tvhNJig3yD7tzkjEw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 05/13] remote_driver: Drop explicit memset(&sargs) in remoteAuthSASL() Date: Thu, 3 Aug 2023 12:36:12 +0200 Message-ID: <1dfc5fe8d948b97c192e01a2975c4e5a172a92d8.1691058853.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1691059010385100013 Content-Type: text/plain; charset="utf-8"; x-default="true" Inside of remoteAuthSASL() the sargs variable is already initialized to zero during declaration. There's no need to memset() it again as it's unused in between it's declaration and said memset(). Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana --- src/remote/remote_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index d775f65fe2..7ccf550dff 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -3833,7 +3833,6 @@ remoteAuthSASL(virConnectPtr conn, struct private_dat= a *priv, goto cleanup; } /* NB, distinction of NULL vs "" is *critical* in SASL */ - memset(&sargs, 0, sizeof(sargs)); sargs.nil =3D clientout ? 0 : 1; sargs.data.data_val =3D (char*)clientout; sargs.data.data_len =3D clientoutlen; --=20 2.41.0