From nobody Mon Feb 9 01:48:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1698234065; cv=none; d=zohomail.com; s=zohoarc; b=TyxtY6fGRte1JqTzzig5opFqQPj5FhZFxtO2jdXuDiaYEaws9yca/2azGpn3dX3jGZcQNrkYr2D4rRulo8ZEKd4viTFhKMdKuYtglta8w2nXXUNDxmKLua8QiMPUxbOOnRm9fKpyvmYME3XZmzvcH29kQgOiTiBqYgGXAKv3SgU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698234065; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=s8LISkaxZUFXzCb+6pLDqnObtuqiDk0GZEY4ow3R8/s=; b=C0YUMwgsOHNV4X2ddtjVuPAUKi0/xEW60fxeg1pNVjpnGQtB1pGlApAZxsqUy72jfBGG9IU9Y65ujFfVwGzQZeJPhV1gjRLtd9AHGrT5EVKHsvCj8wgxXBbXXM1RPbLXInFg699uuamOxsxLBEqpL+7Y+uz92Wo9iUZ/O5Vv7EE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1698234065887326.89389614498873; Wed, 25 Oct 2023 04:41:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-wcOJSg2UPTSKXTUBOo449A-1; Wed, 25 Oct 2023 07:40:11 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 90470811E92; Wed, 25 Oct 2023 11:39:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CB0940C6F79; Wed, 25 Oct 2023 11:39:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 61484194658D; Wed, 25 Oct 2023 11:39:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 94ED0194658D for ; Wed, 25 Oct 2023 11:39:52 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 78156492BFB; Wed, 25 Oct 2023 11:39:52 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0418E492BFA for ; Wed, 25 Oct 2023 11:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698234064; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=s8LISkaxZUFXzCb+6pLDqnObtuqiDk0GZEY4ow3R8/s=; b=YAqvxAnPh/wsaTJ44PGwKozYft7VMdAMFkqH4TZmOd8Be5AIDpMpMXxJBL5pTE+J/UDzIb dANHF+ynPIpIDwF47S4xzXmSgwaWJZA6lQm35La3TJxP+SfSdDvcrIN05QAqcFyaYs/Z9h AixW/LdJ14AQ9xI4vCscWWM9w50QATo= X-MC-Unique: wcOJSg2UPTSKXTUBOo449A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 11/22] qemublocktest: Fix logical bug in TEST_JSON_FORMAT macro Date: Wed, 25 Oct 2023 13:39:21 +0200 Message-ID: <1db25a4a97f67c6b81a2c2df5f21a10e7da18f48.1698233503.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1698234067548100002 Content-Type: text/plain; charset="utf-8" Condition handling failure of the first virTestRun was lacking the 'ret =3D -1' line thus the subsequent line was taken as it's body rendering the first invocation useless. Signed-off-by: Peter Krempa --- tests/qemublocktest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c index a89dddf002..161fd84871 100644 --- a/tests/qemublocktest.c +++ b/tests/qemublocktest.c @@ -1015,6 +1015,7 @@ mymain(void) xmljsonxmldata.legacy =3D true; \ if (virTestRun(virTestCounterNext(), testBackingXMLjsonXML, \ &xmljsonxmldata) < 0) \ + ret =3D -1; \ xmljsonxmldata.legacy =3D false; \ if (virTestRun(virTestCounterNext(), testBackingXMLjsonXML, \ &xmljsonxmldata) < 0) \ --=20 2.41.0