From nobody Sun Feb 8 09:23:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1629465563; cv=none; d=zohomail.com; s=zohoarc; b=JUPxow5KqKoVRAC+RAZE3tATBTuHTApas8nxQNEHbkRZhQmQ4Yvr5egGpV/680JiIk1cggQrDP0YKcECQasZ+gxB9B4gZVw/OQsI9L2QmTdN/8b6Speewqwyuz2YPW7tuTuJYsP5OA91ZLpFKjyAcNgW7ET7Q4p9AglN2BCQqm0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629465563; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GVj8XlffxDCofsNpjDeHqF87fwM/FdW8j2l52c3nQ0c=; b=Mbma8muEZrSkWoa9l3bV12/VmmZAyWjmjVWJtduvQVK8vVSGeM2tWOOA3ThfiU+EFTIPUAddO8d6S1jjIm86jydHWSWhxAEVP/20UMW2edA41SQJZLfMi3ins8iLKbIDQ+m5emj9aI89TnqFjOqSi/gJTn2hKSDD8uXFM7abKK0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 16294655639132.4910939527710525; Fri, 20 Aug 2021 06:19:23 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-576--qo13EuNO6iE9W4TkpS7nw-1; Fri, 20 Aug 2021 09:19:20 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1163192AB8C; Fri, 20 Aug 2021 13:19:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BB091A26A; Fri, 20 Aug 2021 13:19:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1A3F34A7C8; Fri, 20 Aug 2021 13:19:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17KDFgi4016610 for ; Fri, 20 Aug 2021 09:15:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1FED31002D71; Fri, 20 Aug 2021 13:15:42 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C68310013C1 for ; Fri, 20 Aug 2021 13:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629465562; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GVj8XlffxDCofsNpjDeHqF87fwM/FdW8j2l52c3nQ0c=; b=EaLq3nKzFIHtzGWmTVGHhjganw6kxbFV9Pp8Mf66k4YPCCjZUQ5fLto4B87XXl5YDdq6My DyKdg5RmzwNWyqD2mIlyka1mjrZ4U/t5tRWm6h4q7qpq+NI+1Imm9oR74YwmwA5WxYYkeb KHpwNwMb0QBns11sWSsgAZZTGAUX/cw= X-MC-Unique: -qo13EuNO6iE9W4TkpS7nw-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 2/5] tests: virnetdevopenvswitch: use g_auto Date: Fri, 20 Aug 2021 15:15:29 +0200 Message-Id: <1da90da86214ff62ecf6d0c482568aa168a9d1bc.1629465240.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1629465565970100001 Signed-off-by: J=C3=A1n Tomko --- tests/virnetdevopenvswitchtest.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/virnetdevopenvswitchtest.c b/tests/virnetdevopenvswitcht= est.c index 8c5034a5c6..89ffc1e4b5 100644 --- a/tests/virnetdevopenvswitchtest.c +++ b/tests/virnetdevopenvswitchtest.c @@ -48,8 +48,8 @@ struct testClearQosStruct { #define PARSE(xml, var) \ do { \ int rc; \ - xmlDocPtr doc; \ - xmlXPathContextPtr ctxt =3D NULL; \ + g_autoptr(xmlDoc) doc =3D NULL; \ + g_autoptr(xmlXPathContext) ctxt =3D NULL; \ \ if (!xml) \ break; \ @@ -63,8 +63,6 @@ struct testClearQosStruct { NULL, \ ctxt->node, \ true); \ - xmlFreeDoc(doc); \ - xmlXPathFreeContext(ctxt); \ if (rc < 0) \ goto cleanup; \ } while (0) @@ -160,7 +158,7 @@ testVirNetDevOpenvswitchInterfaceSetQos(const void *dat= a) const char *iface =3D info->iface; g_autoptr(virNetDevBandwidth) band =3D NULL; g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; - char *actual_cmd =3D NULL; + g_autofree char *actual_cmd =3D NULL; g_autoptr(virCommandDryRunToken) dryRunToken =3D virCommandDryRunToken= New(); =20 PARSE(info->band, band); @@ -187,7 +185,6 @@ testVirNetDevOpenvswitchInterfaceSetQos(const void *dat= a) =20 ret =3D 0; cleanup: - VIR_FREE(actual_cmd); return ret; } =20 @@ -198,7 +195,7 @@ testVirNetDevOpenvswitchInterfaceClearQos(const void *d= ata) int ret =3D -1; const struct testClearQosStruct *info =3D data; g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; - char *actual_cmd =3D NULL; + g_autofree char *actual_cmd =3D NULL; const char *iface =3D info->iface; const unsigned char *vmid =3D info->vmid; g_autoptr(virCommandDryRunToken) dryRunToken =3D virCommandDryRunToken= New(); @@ -222,7 +219,6 @@ testVirNetDevOpenvswitchInterfaceClearQos(const void *d= ata) =20 ret =3D 0; cleanup: - VIR_FREE(actual_cmd); return ret; } =20 --=20 2.31.1