From nobody Sun Feb 8 18:24:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636104940; cv=none; d=zohomail.com; s=zohoarc; b=liapseKi8THGoVLlTWStyt42ztoUTOVokAmMCumnG4v4M+cgKusLVhfR2YlB28e0RZ1rkmwvqbK5+6VPbiirNaHgLioZ7mdD37YZCwqcRa+1ET4/wwqmQt80e/jUkZbRwowMjS/I3YWj5rffklmXgwxQsA5ztQNWfpFbyZ42BMc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636104940; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rNIZ70OMt1SMof/SLTRWElBZ8+ikZsULm+3qYsJRfFQ=; b=M5slBeRBFfGTKOOUzin4U7xwqltcDk96jgaZ+ZpvIiJ6xnlcXx+yjMEhIRngu3tRBvNGbrjUBBy6vvLGph9swzAxZzDF59h76Mo8419whdE2RYdMZ9+ea3aiVF1KD2UTuxbmg0m1dqWNAFNE9oMCI131GwCpBRiM/nt9IjUQb7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1636104940510893.4757023328117; Fri, 5 Nov 2021 02:35:40 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-s5d2U9ocMyaUMlbNM1Pm-Q-1; Fri, 05 Nov 2021 05:35:35 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 40671C7474; Fri, 5 Nov 2021 09:35:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 237491017CF3; Fri, 5 Nov 2021 09:35:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EB1D3180BAD1; Fri, 5 Nov 2021 09:35:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A59ZOIt026102 for ; Fri, 5 Nov 2021 05:35:24 -0400 Received: by smtp.corp.redhat.com (Postfix) id A959E100239F; Fri, 5 Nov 2021 09:35:24 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 302B210016F5 for ; Fri, 5 Nov 2021 09:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636104939; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=rNIZ70OMt1SMof/SLTRWElBZ8+ikZsULm+3qYsJRfFQ=; b=JRRWOmRcGEeY2M2zbI8r/PVxolysbwKqmBQolydW+ZJJD8JYf35tbxTBRPMy4p5B3rpmWl hundiYCgdMdH8K9ozztK6WDijjIj9t/5p6xl5W8j1MJrFep6A12OmsQwn2Ad1WZZvVawWY UqHZDc/rEEdhkvUWlRm3PfbXRhg9CqI= X-MC-Unique: s5d2U9ocMyaUMlbNM1Pm-Q-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 1/4] qemu_command: Don't validate accelerator when building cmd line Date: Fri, 5 Nov 2021 10:35:17 +0100 Message-Id: <1cfd46fd8f3610af9de4d2189ed90e6808559864.1636104680.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636104941063100001 Content-Type: text/plain; charset="utf-8" The domain accelerator was validated in qemuValidateDomainDef() which calls virQEMUCapsIsVirtTypeSupported() which reports proper error if QEMU is not capable of KVM/TCG. There is no point in doing the validation again when building command line. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/qemu/qemu_command.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 483041f584..cd133cc86c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7061,15 +7061,8 @@ qemuBuildMachineCommandLine(virCommand *cmd, case VIR_DOMAIN_VIRT_BHYVE: case VIR_DOMAIN_VIRT_VZ: case VIR_DOMAIN_VIRT_NONE: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("the QEMU binary does not support %s"), - virDomainVirtTypeToString(def->virtType)); - return -1; - case VIR_DOMAIN_VIRT_LAST: - default: - virReportEnumRangeError(virDomainVirtType, def->virtType); - return -1; + break; } =20 /* To avoid the collision of creating USB controllers when calling --=20 2.32.0