From nobody Fri Dec 19 17:01:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596406318; cv=none; d=zohomail.com; s=zohoarc; b=ElcCSe9veWpFokGXhngDyomkXjiRxoVQLeysIsWMd+LQpQzW0++xXXCdFVJK4enVwEfZMak30YmOfGx7QyLVbMylLPExQyNonz14bKJN0mZFuPZSVMgPEltFK9YdZ8aSuhwNX+xYVSv5MhHNmgq2F6E5peKICp98rudA6TYaRII= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596406318; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8oyPwL60yP/5kk/7ow6z93UnoJulOje4PLlQ/YU4Jco=; b=fOjPMs7ItndyLgD81xJSCsrXEimofmt1d4xidEz8CnfmJ/NFZBi5fiez4vuwC1WhDKcIHCp2YrC8gg4tdFI6Ok24kTISiqrN39Wyi3eE/eWn4piTge/4fAFyqP3+v5uDEjDz5v9HKtcellGG7vCHzuFzJEg14kRdF5F/hVClzcM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1596406318198169.04836434021274; Sun, 2 Aug 2020 15:11:58 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-xEDa5Fw2N7ao32BE3eEmnQ-1; Sun, 02 Aug 2020 18:11:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D60AE1893DDF; Sun, 2 Aug 2020 22:11:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E06B65D9CD; Sun, 2 Aug 2020 22:11:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 22E231809554; Sun, 2 Aug 2020 22:11:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 072MBfAM010566 for ; Sun, 2 Aug 2020 18:11:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1C60C5C6DD; Sun, 2 Aug 2020 22:11:41 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C5F05C5B7 for ; Sun, 2 Aug 2020 22:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596406316; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8oyPwL60yP/5kk/7ow6z93UnoJulOje4PLlQ/YU4Jco=; b=fOmnzPBefDJWCrTRDvcCPymWRwOKPx7YI/BWzW0tSdCrrwsqa4jXzc7WAFFs2u4KuL/Gfi Qbmw86VxO3XpckYAeNIpSBgRCDHkQ2vn6eV6cO9Wb5tdZp/BXyr8eOWTsDIw4qbqrpeHm+ 2ttApIPtn5RhyT5mfLz37su53AVONiQ= X-MC-Unique: xEDa5Fw2N7ao32BE3eEmnQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/8] vz: remove redundant NULL pointer check Date: Mon, 3 Aug 2020 00:11:24 +0200 Message-Id: <1c9685bb425193d96e564e29d9ae74245e83396a.1596406221.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The 'dom' pointer is already dereferenced earlier. src/vz/vz_sdk.c:249:24: warning: Either the condition 'if(dom)' is redundant or there is possible null pointer dereference: dom. [nullPointerRedundantCheck] Signed-off-by: J=C3=A1n Tomko --- src/vz/vz_sdk.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index b5e69b385f..bb1ef0ea47 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -256,11 +256,11 @@ waitDomainJobHelper(PRL_HANDLE job, virDomainObjPtr d= om, unsigned int timeout, } =20 pdom->job.sdkJob =3D job; - if (dom) - virObjectUnlock(dom); + + virObjectUnlock(dom); ret =3D waitJobHelper(job, timeout, filename, funcname, linenr); - if (dom) - virObjectLock(dom); + virObjectLock(dom); + pdom->job.sdkJob =3D NULL; =20 return ret; --=20 2.26.2