From nobody Mon Feb 9 01:45:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584979860; cv=none; d=zohomail.com; s=zohoarc; b=UWu5IoNljskifGHcwfaCVUGg4b/K4VfqOlpZtf20NIoilwDp12gadoxDmTjbsr3SA7j/Ny6RTWh44e9yqCHSbKBtselnm2zJ9pWX/6HAbRUO1FCnGTVia034hysYdVXI6ZqQ8OCHEPvigA98iJuWuF7tUqj80mbEQZ0bg11HnT0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584979860; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UGHIU0do3DZupXHCadK29LinUIjT/gpGSE4ZIPy7mQo=; b=TXPAjgn1Xs8T91xiP6j+5jKPz96R8/znJ9Aszvm+bkvk1oIBbJ+n3gUC+ATeVI1mf4lybmVz4IHzSaUp9Hu567f9f/0y6BC2ajg2fXipW93Xxhg4TfOn03pOBbQQNpWPOLO+TR6OYLTtkPgJZ/BwPBQlGDZas5BwsQO6Z5PXmqQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 1584979860891425.7994902742604; Mon, 23 Mar 2020 09:11:00 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-i4rJE3xWMV-3VQM_gMPH-w-1; Mon, 23 Mar 2020 12:10:55 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 65002100550D; Mon, 23 Mar 2020 16:10:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 324CE196AE; Mon, 23 Mar 2020 16:10:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C074718089CD; Mon, 23 Mar 2020 16:10:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02NGAmTh004996 for ; Mon, 23 Mar 2020 12:10:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id 545B19B92D; Mon, 23 Mar 2020 16:10:48 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.40.208.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B05A9B931 for ; Mon, 23 Mar 2020 16:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584979859; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UGHIU0do3DZupXHCadK29LinUIjT/gpGSE4ZIPy7mQo=; b=ZHEy6PA0DHgn4StYDKN86JKHgrsQmX9OUydzmvRFEYzQHNZjYd11i0p52TkXWheeM+ZTMl VZiCkdNvIFNFofnl5n0lROXJM/HxhEfbOMh7DNkQZhSTTTy1G7GTkndGRD+KEqlIGjgngO h6HOh/+/ZhQK1DgJEPd49VmMcjh45Lw= X-MC-Unique: i4rJE3xWMV-3VQM_gMPH-w-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 4/4] qemu: virtiofs: use a .log.fs suffix for logs Date: Mon, 23 Mar 2020 17:10:37 +0100 Message-Id: <1c61a77a689e7a1d2ff40428fa55b21fdfffe427.1584979790.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" As Dave pointed out, someone creative might name a domain to make its logfile conflict with a logfile of another domain's virtiofsd log. Signed-off-by: J=C3=A1n Tomko Reported-by: Dr. David Alan Gilbert Reviewed-by: Michal Privoznik --- src/qemu/qemu_virtiofs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index aaa25bcbb8..575b47fd74 100644 --- a/src/qemu/qemu_virtiofs.c +++ b/src/qemu/qemu_virtiofs.c @@ -67,9 +67,9 @@ qemuVirtioFSCreateLogFilename(virQEMUDriverConfigPtr cfg, { g_autofree char *name =3D NULL; =20 - name =3D g_strdup_printf("%s-%s", def->name, alias); + name =3D g_strdup_printf("%s-%s.log.fs", def->name, alias); =20 - return virFileBuildPath(cfg->logDir, name, "-virtiofsd.log"); + return virFileBuildPath(cfg->logDir, name, NULL); } =20 =20 --=20 2.25.1