From nobody Sun Feb 8 22:34:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639421045; cv=none; d=zohomail.com; s=zohoarc; b=nOCvc4imj6txXPntjmQvRbW2uJZVLgal5CeNi8ERhsxHbU5R/cG+XfHpoWcCpWqynnVKfzzcQytf6diafOMcDOfKzijSaGBVVyCd+9Jfp/lAzLfTCB0/FH8jsgtuY4XA5M3iTX8buzeiJtALijJjsjRPimuBJe0dBJkXMgzlNeo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639421045; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pjo1Jqvm1IughhzKXgzN1adFBcjy9wa1meibv7FUtw0=; b=Eask26bUTs29XR4G4yYQgX84V/fBH62vut8eV22tRnJd2Fnva4l8fKvAXVYTrLlcqUlM4Hw5cus+2KCyP0tFYBaLh0K9hTyqY9z/OzdyOaMwU0cB9NCBkB2glzNzJwU9FYPpePiyRztTHqKKpGkOA5O/q2Drjtte+OH8bsjMXNE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1639421045835928.8672198900126; Mon, 13 Dec 2021 10:44:05 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-437-XOYxymE1PkiiVoX3ha5ErA-1; Mon, 13 Dec 2021 13:43:59 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9071A1006ADE; Mon, 13 Dec 2021 18:43:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73FC67AB48; Mon, 13 Dec 2021 18:43:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4713C4A710; Mon, 13 Dec 2021 18:43:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1BDIhV7J003999 for ; Mon, 13 Dec 2021 13:43:31 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7427160C04; Mon, 13 Dec 2021 18:43:31 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFEBA61082 for ; Mon, 13 Dec 2021 18:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639421044; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=pjo1Jqvm1IughhzKXgzN1adFBcjy9wa1meibv7FUtw0=; b=b4Or0bOo8koglUvhKgYqqgsRr5jzvZyZ/hu/uAbSdNyzxzEd2rQeyu7Dvi9/M55ju28drG 5YO1kXfq9E19MYY/zPZ5GBgmQl3OIfpdJXh4aM2YP/luk9rnQJ5oub9uJJIW6lZM4UIRlL oeFD3Ig8Qn3swajxmatsiWjRvQrw/8g= X-MC-Unique: XOYxymE1PkiiVoX3ha5ErA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 20/20] tests: storagevolxml2argvtest: do not reuse cmd Date: Mon, 13 Dec 2021 19:43:12 +0100 Message-Id: <1bba69ac0e7356dccdc06a80db439ca3b44018cd.1639420923.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639421046677100001 Reduce the scope of the variable to avoid mixing automatic and manual cleanup. Signed-off-by: J=C3=A1n Tomko --- tests/storagevolxml2argvtest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/storagevolxml2argvtest.c b/tests/storagevolxml2argvtest.c index 9597509f00..94e2de1730 100644 --- a/tests/storagevolxml2argvtest.c +++ b/tests/storagevolxml2argvtest.c @@ -50,7 +50,6 @@ testCompareXMLToArgvFiles(bool shouldFail, g_autoptr(virStorageVolDef) vol =3D NULL; g_autoptr(virStorageVolDef) inputvol =3D NULL; g_autoptr(virStoragePoolDef) inputpool =3D NULL; - g_autoptr(virCommand) cmd =3D NULL; =20 if (!(def =3D virStoragePoolDefParseFile(poolxml))) goto cleanup; @@ -88,7 +87,8 @@ testCompareXMLToArgvFiles(bool shouldFail, convertStep =3D VIR_STORAGE_VOL_ENCRYPT_CREATE; =20 do { - virCommandFree(cmd); + g_autoptr(virCommand) cmd =3D NULL; + cmd =3D virStorageBackendCreateQemuImgCmdFromVol(obj, vol, inputvol, flags, create_tool, --=20 2.31.1