From nobody Sun May 19 20:13:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1605287998; cv=none; d=zohomail.com; s=zohoarc; b=FADpJfhn2ZRhLGj2ZzrjO/ksfgDA9MOCm0+w5/WOoQ/hnfyims24MePf9vVTMgaTtKpjqE1kf+3tJkuiFDhjYNYLQL9QrpqhQ1BHjdtm7L7uWYT1+/zWbLr1gfqpWHNp3DkSEztxE/QHr8CqE9QiMDk9FMJsj4HRd3kc9v74+QA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605287998; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=v+LdEwvG5a9BIC9DCkisFGnIg2K2bKUgEmbnCNw9XLE=; b=AZDY3FcH7/aHPxLTdtDvbz2fYcv/ObUZcmzyQHvFf936Eyr+tf99DOix+5jKydS5f3khGzYCKrDCAvpJJ9IFZrTrpsUAXC05WcMZpZGld8m+OR+d6SbJ2miz+EB7zlZP+HN/trTRiG2hyxQ9Hxi+EJ+9u/ro81447G0lPa6Aq20= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1605287998750936.9453296175649; Fri, 13 Nov 2020 09:19:58 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591--Ep0ayFlMm2-UZakOHFm6Q-1; Fri, 13 Nov 2020 12:19:55 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E50068049FB; Fri, 13 Nov 2020 17:19:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 690FE60C11; Fri, 13 Nov 2020 17:19:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6AA0458103; Fri, 13 Nov 2020 17:19:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0ADHFReX031954 for ; Fri, 13 Nov 2020 12:15:27 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7819755789; Fri, 13 Nov 2020 17:15:27 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC8F555785 for ; Fri, 13 Nov 2020 17:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605287997; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=v+LdEwvG5a9BIC9DCkisFGnIg2K2bKUgEmbnCNw9XLE=; b=IJTkwhmgYhRSk59N2TsmaSPbxl1QZEuLeNctJe/gJG8KMMZuEt/O4CPX+u8xNqON0NC8eV YzgTCuew1InLQj42Ep+xWVD8AOCVcV6Kp7vMBOIehJHrOtA7KMQ7TdylbeOFZwkjO8Uk3M yZQnFGodMpnHIKKjWLaH+cxwgULfHc0= X-MC-Unique: -Ep0ayFlMm2-UZakOHFm6Q-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] virnetdevopenvswitch: Fix ATTRIBUTE_NONNULL() tag for virNetDevOpenvswitchGetVhostuserIfname() Date: Fri, 13 Nov 2020 18:15:20 +0100 Message-Id: <1b077e611663a3d1734d320d865f526111c9a490.1605287599.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" After e4c29e2904 the function has one argument more and the argument that can't be NULL moved from second to third position. Reported-by: John Ferlan Signed-off-by: Michal Privoznik --- Pushed as trivial. src/util/virnetdevopenvswitch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdevopenvswitch.h b/src/util/virnetdevopenvswitc= h.h index 5cd1d22ae3..8409aa92ac 100644 --- a/src/util/virnetdevopenvswitch.h +++ b/src/util/virnetdevopenvswitch.h @@ -63,7 +63,7 @@ int virNetDevOpenvswitchInterfaceGetMaster(const char *if= name, char **master) int virNetDevOpenvswitchGetVhostuserIfname(const char *path, bool server, char **ifname) - ATTRIBUTE_NONNULL(2) G_GNUC_WARN_UNUSED_RESULT G_GNUC_NO_INLINE; + ATTRIBUTE_NONNULL(3) G_GNUC_WARN_UNUSED_RESULT G_GNUC_NO_INLINE; =20 int virNetDevOpenvswitchUpdateVlan(const char *ifname, const virNetDevVlan *virtVlan) --=20 2.26.2