From nobody Sun Feb 8 06:05:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623851930; cv=none; d=zohomail.com; s=zohoarc; b=Z+Lc0tOI7QRBqaVtyrtsQ9Ac6jY+ATIDK05QSxzxNt/R5XGKggsBPWan4EEqWiy0Grtmyn4Wizh2osqG7DxdTs9nbrz2k4D6DNhS/mqSWH58OBEIze7TwdDdMu9oajmUeV6Zb4lWE+4Tw0I0YzeQ7rbrlbO7L5VKCgb2KMVIUNk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623851930; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UeaaFJun1wiHpK3NWXHSiimjFoXv2yIrSkr5t0pC1kM=; b=Ina9aJcmcl2ytNpQpZUcRMZG07kxnQ5mAj/wYBig6WJ28jkp15TM0RO+t0m8wCbos8Xl88irM517ejb2w/2u7aGAoGo7xpW/IS9bKbtm8hm8J7kU7Vw5aOb5iZuWGoUusLEEWxY+LvcuUKEovnNZqeSV5eiFYouHuBpdfvZT6E4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1623851930036270.016371610243; Wed, 16 Jun 2021 06:58:50 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-_xegS2m7Pcyuq8pCVvg93Q-1; Wed, 16 Jun 2021 09:58:46 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DCF451012584; Wed, 16 Jun 2021 13:58:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D7AB100238C; Wed, 16 Jun 2021 13:58:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 87C501809CAE; Wed, 16 Jun 2021 13:58:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 15GDwc0v006651 for ; Wed, 16 Jun 2021 09:58:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id CFFFA10016F4; Wed, 16 Jun 2021 13:58:38 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A81F10013D7 for ; Wed, 16 Jun 2021 13:58:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623851928; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UeaaFJun1wiHpK3NWXHSiimjFoXv2yIrSkr5t0pC1kM=; b=GDSarIejA61bs7xWWrDslGjocK8OosJXi/gTpyHQ95AIO9S46nxssGf3w9ozTTQYY+Otfk LN2AmMORPdSmnsJ2wENUB99JWMbg+IDxAuhvQ2d1D193Jva6vzOfV9POeGM2Tb79x2C2XC xJj2o19YmXL63r5LOBC+r37uGRFsCL0= X-MC-Unique: _xegS2m7Pcyuq8pCVvg93Q-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/3] conf: require target for external virtiofsd Date: Wed, 16 Jun 2021 15:58:30 +0200 Message-Id: <1a3d18a05b744b6c5b7aeb2ad1f1663f404bf911.1623851827.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) When adding support for externally launched virtiofsd, I was too liberal and did not require a target. But the target is required, because it's passed to the QEMU device, not to virtiofsd. https://bugzilla.redhat.com/show_bug.cgi?id=3D1969232 Fixes: 12967c3e1333a6e106110f449ccb1e96279b9527 Signed-off-by: J=C3=A1n Tomko --- docs/formatdomain.rst | 1 + docs/kbase/virtiofs.rst | 1 + src/conf/domain_conf.c | 2 +- tests/qemuxml2argvdata/vhost-user-fs-sock.xml | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index da4d93a787..c6dede053f 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3261,6 +3261,7 @@ A directory on the host that can be accessed directly= from the guest. + ... diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 8cf7567bf8..6ba7299a72 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -180,4 +180,5 @@ control and need to be set by the application running v= irtiofsd. + diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 139cdfc0a7..ef784575d2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9896,7 +9896,7 @@ virDomainFSDefParseXML(virDomainXMLOption *xmlopt, goto error; } =20 - if (target =3D=3D NULL && !sock) { + if (target =3D=3D NULL) { virReportError(VIR_ERR_NO_TARGET, source ? "%s" : NULL, source); goto error; diff --git a/tests/qemuxml2argvdata/vhost-user-fs-sock.xml b/tests/qemuxml2= argvdata/vhost-user-fs-sock.xml index aef005d3fd..e5a380c9b6 100644 --- a/tests/qemuxml2argvdata/vhost-user-fs-sock.xml +++ b/tests/qemuxml2argvdata/vhost-user-fs-sock.xml @@ -29,6 +29,7 @@ +
--=20 2.31.1