From nobody Mon Feb 9 12:10:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556180419; cv=none; d=zoho.com; s=zohoarc; b=iT/YZgFhoLBnEKEZ/wuwZqeGV1B9IYyMXy1lW4NBWw5tzWri80i8l6IRRG5SrKkBak3zqUrP4O6d1k1nvQ1Nv0YR8grZg7yAcv+U75Pg7+lNw/MJxRZZkOxJL/oqxzs2KOOMrFPZ2ZHsprv97GbJq8LuY1XY6ju7O1002OmQcPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556180419; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=GvGJ9FJUEJ6/Ido8Y28BkffERwQJdDAbCRIiTc2I3YE=; b=BAwOXOIOKkiWKNVQRgODodcOvMKFlEG/VbI6iSq3i8uKjwrCUrxZdYuoFOyIzk7jwg/Jl1QpfVJVzHUynQXa4lFBmJXOeIqXXQ5S64iPjGL+GkjXuzU9y4M/yKdQ5PiiNRNG0lZmUzqIW3NcKoF0GIEaGGb4ROP0BRruaDW0lCg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1556180419391609.959753012324; Thu, 25 Apr 2019 01:20:19 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D20D0C04BE09; Thu, 25 Apr 2019 08:20:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D93B60BE5; Thu, 25 Apr 2019 08:20:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C09EA181B9E0; Thu, 25 Apr 2019 08:20:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3P8K95k013834 for ; Thu, 25 Apr 2019 04:20:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id F066D60C70; Thu, 25 Apr 2019 08:20:09 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 77D7E60BE5 for ; Thu, 25 Apr 2019 08:20:09 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 25 Apr 2019 10:19:39 +0200 Message-Id: <19c89443b640445fbd7fd90c6613b42a6a80d75a.1556179410.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v4 03/25] qemusecuritymock: Actually set error on failure X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 25 Apr 2019 08:20:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" I don't really know what happened when I was writing the original code, but even if error was to be set the corresponding boolean was set to false meaning no error. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- tests/qemusecuritymock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemusecuritymock.c b/tests/qemusecuritymock.c index 1ca8bd721f..e52a41067a 100644 --- a/tests/qemusecuritymock.c +++ b/tests/qemusecuritymock.c @@ -366,7 +366,7 @@ checkOwner(void *payload, fprintf(stderr, "Path %s wasn't restored back to its original owner\n", (const char *) name); - *chown_fail =3D false; + *chown_fail =3D true; } =20 return 0; @@ -382,7 +382,7 @@ printXATTR(void *payload, =20 /* The fact that we are in this function means that there are * some XATTRs left behind. This is enough to claim an error. */ - *xattr_fail =3D false; + *xattr_fail =3D true; =20 /* Hash table key consists of "$path:$xattr_name", xattr * value is then the value stored in the hash table. */ --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list