From nobody Sun Feb 8 10:04:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602159161; cv=none; d=zohomail.com; s=zohoarc; b=I+hPI8wPmlnUM3vwcXWF44dv8mgbpI6ICn62uOTMX2Pk1NlKvSN0cwMi3Nvx6PgFv/NNXRTr6Ov2VEPD4fvdBX+d847lhG7VV/HTvxMNOC26vAztwqUL+zuo9hGS2afKjpi5BE+w2Q3YU+RysiyIjnSiTPY4VDr6Sac6L1mTItA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602159161; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZmtB42rT/LwLA0jg9OR+5HgtwFfV5gpGBA5Db7g5Zdc=; b=kHdCFfut2dTvz+k/PUYmUHZAXD3KJw6aeN5ZEIjYBwbuUyPEDHezQKDGKkPTw6hcovTukAO7Peo9s/R9yC5jFlNqaI+Uq2Y+rqtWaq2icx+x+x7tMMbwnZn5nv10pOn+1zoynN1xWfdG6WYupxEPl2IAZOwhLy+wgzHYkd8lS4o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1602159161611339.7687666678437; Thu, 8 Oct 2020 05:12:41 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-FKS_PXLIM-OsZLwlKVvMQA-1; Thu, 08 Oct 2020 08:12:36 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8A23107B7E4; Thu, 8 Oct 2020 12:12:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D34E190B1; Thu, 8 Oct 2020 12:12:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 354DB1832FC4; Thu, 8 Oct 2020 12:12:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 098CCK67001271 for ; Thu, 8 Oct 2020 08:12:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id F341B8246F; Thu, 8 Oct 2020 12:12:19 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E654811BF for ; Thu, 8 Oct 2020 12:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602159160; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZmtB42rT/LwLA0jg9OR+5HgtwFfV5gpGBA5Db7g5Zdc=; b=B5Agp4w8/RvTTh7MxoRm88TbemnYLFvBw5bmJrRZfc0hxcbXLiUcIZFy3juEbj/2TWlUCo yx08EUUr/5zEriALlwKzHXv3N6yUMribvqTUnthL7TPFKkdL70KW+d/MEhphQ/6amqDL+Z Jip4Ua7j18ZxPoAetWWIJjLiXLv/Ze8= X-MC-Unique: FKS_PXLIM-OsZLwlKVvMQA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 2/8] libxl: xenParseXMOS: separate VIR_ALLOC call Date: Thu, 8 Oct 2020 14:12:08 +0200 Message-Id: <19b2b56f1ffa7692d787fa151927d2e8852989cc.1602158901.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) To reduce churn in the following patches. Signed-off-by: J=C3=A1n Tomko --- src/libxl/xen_xm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libxl/xen_xm.c b/src/libxl/xen_xm.c index 8ade5aec1c..6d00f47544 100644 --- a/src/libxl/xen_xm.c +++ b/src/libxl/xen_xm.c @@ -42,8 +42,10 @@ xenParseXMOS(virConfPtr conf, virDomainDefPtr def) if (def->os.type =3D=3D VIR_DOMAIN_OSTYPE_HVM) { g_autofree char *boot =3D NULL; =20 - if (VIR_ALLOC(def->os.loader) < 0 || - xenConfigCopyString(conf, "kernel", &def->os.loader->path) < 0) + if (VIR_ALLOC(def->os.loader) < 0) + return -1; + + if (xenConfigCopyString(conf, "kernel", &def->os.loader->path) < 0) return -1; =20 if (xenConfigGetString(conf, "boot", &boot, "c") < 0) --=20 2.26.2