From nobody Tue Sep 9 13:49:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1756477986; cv=none; d=zohomail.com; s=zohoarc; b=HV6YXjOU0OPWueWWXkGGUH3IOhk5SsT1g1REF0Jm024U/zezLXXShJJJ4V+VgT7+w+g22kelgPwAvPKe+xn5/0LSRjvQLkViVjdzFnxc+4TppLxrQNE8sQ7t6Rh8NVlMLTRSoz85zegVqa3W4fkmNPxfkAVO/eWkYHEEsC5PEMs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756477986; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=R7O3rrt/4TbrvnwST5P0x3oy7lmV4CbAHkczfcfoW3I=; b=R8vyus6KMjbbgQwxV46S7itPXn+0uQFg2p7Oq0U1t2MJaarmrJqYx5UYcV0HJpP0G42hDbs5XP+W05TrdSZD2+4XwHxiMVONpVRE7DbPFe4bzzxkQE+clN/Nc7JB89t2lqBJHSfukytE2v2YgPNzFGPei7j0/A1bROHQPtefAIM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1756477986726912.9810611935961; Fri, 29 Aug 2025 07:33:06 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1142644255; Fri, 29 Aug 2025 10:33:06 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 1354944341; Fri, 29 Aug 2025 10:20:21 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 9FEB144194; Fri, 29 Aug 2025 10:19:48 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 393034411F for ; Fri, 29 Aug 2025 10:19:46 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-wTZfU1dKNzGcnu1n6SbREA-1; Fri, 29 Aug 2025 10:19:38 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A6752180035C for ; Fri, 29 Aug 2025 14:19:37 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.44.22.3]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E072A1956095 for ; Fri, 29 Aug 2025 14:19:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756477185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R7O3rrt/4TbrvnwST5P0x3oy7lmV4CbAHkczfcfoW3I=; b=LTZZCtK9zf09icn/oKJALOr/jARWr4j+V4Q1joulWZXu7P2o+wi1cSllkBOuXB2CBYQqjh EgDG6x9382g9SbfWBEH3mEnm/ITyY+hCiZ5LuAPej0fRR3pSFrCXqqTNGMj2YdD+Ix6d8W 2qOg3uKDKsegrfE49tIwdUvnvU1zSCM= X-MC-Unique: wTZfU1dKNzGcnu1n6SbREA-1 X-Mimecast-MFC-AGG-ID: wTZfU1dKNzGcnu1n6SbREA_1756477177 To: devel@lists.libvirt.org Subject: [PATCH 2/8] scripts: qemu-replies-tool: Drop specific invocation of marginally useful dump modes Date: Fri, 29 Aug 2025 16:19:26 +0200 Message-ID: <1870334d2160f070196921db40bc16c0cf52611a.1756477095.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: J0_0u8O9Y1CNvbztHUtwD-F0VyKDtFjSa6IEdF4lECc_1756477177 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XZZTXZCFBYKM7HNINF4S5VU4CXBO7MEL X-Message-ID-Hash: XZZTXZCFBYKM7HNINF4S5VU4CXBO7MEL X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1756477990465124100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa While '--dump-qmp-query-strings' is useful by itself because it's a simple way to generate the QMP schema query strings for libvirt, the other modes aren't useful besides comparing two .replies files by the dumped output. Remove specific options for '--dump-qom-list-types' and '--dump-device-list-properties', so that upcoming additions which will be useful only for comparisons aren't forced to add these options. Signed-off-by: Peter Krempa --- scripts/qemu-replies-tool.py | 24 +++--------------------- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git a/scripts/qemu-replies-tool.py b/scripts/qemu-replies-tool.py index 4ec06ee95d..b5e4ae46ca 100755 --- a/scripts/qemu-replies-tool.py +++ b/scripts/qemu-replies-tool.py @@ -449,11 +449,8 @@ def process_one(filename, args): dump_qmp_probe_strings(c['rep']['return']) dumped =3D True - if args.dump_all or args.dump_qom_list_types: + if args.dump_all: dump_qom_list_types(conv) - dumped =3D True - - if args.dump_all or args.dump_device_list_properties: dump_device_list_properties(conv) dumped =3D True @@ -492,7 +489,8 @@ In 'dump' mode if '-dump-all' or one of the specific '-= dump-*' flags (below) is selected the script outputs information gathered from the given '.repli= es' file. The data is also usable for comparing two '.replies' files in a "dif= fable" fashion as many of the query commands may change ordering or naming without -functional impact on libvirt. +functional impact on libvirt. The following specific dump options are usef= ul +on it's own: --dump-qmp-query-strings @@ -501,16 +499,6 @@ functional impact on libvirt. virQEMUCapsQMPSchemaQueries. It's useful to find specific query string without having to piece the information together from 'query-qmp-schem= a' - --dump-qom-list-types - - Dumps all types returned by 'qom-list-types' in a stable order with the - 'parent' property dropped as it's not relevant for libvirt. - - --dump-device-list-properties - - Dumps all properties of all devices queried by libvirt in stable order - along with types and default values. - The tool can be also used to programmaticaly modify the '.replies' file by editing the 'modify_replies' method directly in the source, or for re-formatting and re-numbering the '.replies' file to conform with the req= uired @@ -541,12 +529,6 @@ parser.add_argument('--dump-all', action=3D'store_true= ', parser.add_argument('--dump-qmp-query-strings', action=3D'store_true', help=3D'dump QMP schema in form of query strings used = to probe capabilities') -parser.add_argument('--dump-qom-list-types', action=3D'store_true', - help=3D'dump data from qom-list-types in a stable orde= r') - -parser.add_argument('--dump-device-list-properties', action=3D'store_true', - help=3D'dump all devices and their properties') - args =3D parser.parse_args() files =3D [] --=20 2.51.0