From nobody Mon Feb 9 05:20:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627031232; cv=none; d=zohomail.com; s=zohoarc; b=fh6qJ7fDbc6VysY4q15GyeXgScpwddF4OB1tqfeSqkWVtr2sLsxS5tfwZk2KbTyDdm2SdjKoDvMhAMLRJTLMvTRvRRxi+Re4SpnaQX8pj5MHL6bPNd8k6XVXJ5zLdOOz0Fa00TFnqgoAqfbpC+qtXz4ABLJ/WmaE8vJ7ip4P2FU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627031232; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J0xg/dqCUlWCneBdci9dGh+JU22+TJg9zZRRjEq9Ck8=; b=LFVVUfcuutV8yWubtWg66t2OWCX5a2cqQOTgMrSSazHVGJTskukORJONDUjsgDClWk+9deBWZ5loahLdr3q0J5W9cRxPvuo9yvnZ3H4kItkFj08v1TmQGR2mHwON25RWwn3z3wMo0At+utCmcFnl44Opp5jcaSNKffrt9e5mcEo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627031232415641.7765336248763; Fri, 23 Jul 2021 02:07:12 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-nQCA5JnvOZmNHsEBZSPj_Q-1; Fri, 23 Jul 2021 05:06:11 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1927A185302E; Fri, 23 Jul 2021 09:06:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7EB0101F965; Fri, 23 Jul 2021 09:06:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AF9144A7CA; Fri, 23 Jul 2021 09:06:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N95xe7019566 for ; Fri, 23 Jul 2021 05:05:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0FF0F6F97F; Fri, 23 Jul 2021 09:05:59 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69BDC60853 for ; Fri, 23 Jul 2021 09:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627031231; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=J0xg/dqCUlWCneBdci9dGh+JU22+TJg9zZRRjEq9Ck8=; b=RMaA89HeRdV7HPXfse/wcj98weDHATydCyN1qwN3biEGP3TgC0b/2CzH0HwkJYWM54ygfn hRqiF8oFLUPzsf6WPZpS4jGUfBenoaIqubnQrDKongvbDvf5yWj5kbMOqHbn9xUoSfP0bA 3QrMo2qWzf8evMyXNjTRt1o+e4DHurQ= X-MC-Unique: nQCA5JnvOZmNHsEBZSPj_Q-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/7] qemuBlockNodeNameGetBackingChain: Shuffle around variable initialization Date: Fri, 23 Jul 2021 11:05:46 +0200 Message-Id: <1775ee8f86edb194adf18acb1241c758c40feaeb.1627031076.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627031233635100001 Content-Type: text/plain; charset="utf-8" Allocate the hash tables first so tat the 'data' struct can be directly initialized removing the need for a memset and two additional assignments. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 8150241015..1bcf7fa4f1 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -230,20 +230,16 @@ GHashTable * qemuBlockNodeNameGetBackingChain(virJSONValue *namednodes, virJSONValue *blockstats) { - struct qemuBlockNodeNameGetBackingChainData data; g_autoptr(GHashTable) namednodestable =3D virHashNew(virJSONValueHashF= ree); g_autoptr(GHashTable) disks =3D virHashNew(qemuBlockNodeNameBackingCha= inDataHashEntryFree); - - memset(&data, 0, sizeof(data)); + struct qemuBlockNodeNameGetBackingChainData data =3D { .nodenamestable= =3D namednodestable, + .disks =3D disks = }; if (virJSONValueArrayForeachSteal(namednodes, qemuBlockNamedNodesArrayToHash, namednodestable) < 0) return NULL; - data.nodenamestable =3D namednodestable; - data.disks =3D disks; - if (virJSONValueArrayForeachSteal(blockstats, qemuBlockNodeNameGetBackingChainDisk, &data) < 0) --=20 2.31.1