From nobody Tue Dec 16 02:36:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1673027572; cv=none; d=zohomail.com; s=zohoarc; b=kKEhdJSlaGZKgUmVXv6ETXPwFl6yuFLhK6MmSFXBflEKknsqI91caOTQILwpN/Mvo87wZFxtcB0aV2S9IrWJyYfFc4QhdJ2lkhQX+q8qzhOCmrCarg1Pd8HZDE7Y8kRjjtmwRlE3zQDCe+yk2eHSt4dwb7UUz1Vi0Gv/jZMRTL4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673027572; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5hFuVp1qgSjEEaPegch2x1wQZrRzbG61jGsILFE7gGk=; b=Hq5BKaMJJ2+KnSIiuZwO6ISPQilUtzNFUrn/J//HR0jJjcSC0fzoo0+jk8TYROAB6toJbwfHpLSX+qYT/LQ7bfloOPfLO9nbGqLCGmNuBvvxxvxTM29zU2NELGGmA8p5xPQeS3dX/+hYLqprFOih5Jzn5o+f+TA9Y+iRiaW8Lk4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 167302757280793.25163874720306; Fri, 6 Jan 2023 09:52:52 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-251--0BgS9inNWurN41zIAfvxQ-1; Fri, 06 Jan 2023 12:52:43 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 93C8C80234E; Fri, 6 Jan 2023 17:52:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80A8C2026D68; Fri, 6 Jan 2023 17:52:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 70CEF19459DF; Fri, 6 Jan 2023 17:52:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1D37519459C1 for ; Fri, 6 Jan 2023 17:52:35 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0F04740C2064; Fri, 6 Jan 2023 17:52:35 +0000 (UTC) Received: from antique-work.redhat.com (ovpn-193-172.brq.redhat.com [10.40.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id A1C0B40C2004 for ; Fri, 6 Jan 2023 17:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673027570; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5hFuVp1qgSjEEaPegch2x1wQZrRzbG61jGsILFE7gGk=; b=ifTaJ1sF8+5Y9jAhe6uIRDV0qr/vsR4VkdMV006a/g74FESXdUgQJJPEck+Efpl/aBB0zm 25njIhClmecHQZD8jMyiUXaKfn+90G89MKFtXlLpnEW11qG7SU5A9BYJsQ2+5iopQKFAnH bN+6zrMs97RxASB/Y5N2/iI12fkR+PU= X-MC-Unique: -0BgS9inNWurN41zIAfvxQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH v3 31/32] api: document support for external snapshot deletion Date: Fri, 6 Jan 2023 18:52:06 +0100 Message-Id: <169b68c4ac0ccc70a5bbf339a13c45e338e99600.1673027206.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1673027573192100011 Content-Type: text/plain; charset="utf-8"; x-default="true" Now that deletion of external snapshot is implemented document the current virDomainSnapshotDelete supported state. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/libvirt-domain-snapshot.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/libvirt-domain-snapshot.c b/src/libvirt-domain-snapshot.c index 2917b8bd90..ab6a029915 100644 --- a/src/libvirt-domain-snapshot.c +++ b/src/libvirt-domain-snapshot.c @@ -1075,6 +1075,13 @@ virDomainRevertToSnapshot(virDomainSnapshotPtr snaps= hot, * libvirt metadata to track snapshots, then this flag is silently * ignored. * + * Since libvirt 9.0.0 deletion of external snapshots is supported + * for QEMU driver. Using @flags VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN + * and VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY is not supported with + * external snapshots. In case that daemon process is terminated + * while the snapshot delete is in process the operation will be + * aborted when the daemon starts again. + * * Returns 0 if the selected snapshot(s) were successfully deleted, * -1 on error. * --=20 2.39.0