From nobody Mon Feb 9 03:13:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=git.sr.ht ARC-Seal: i=1; a=rsa-sha256; t=1690712456; cv=none; d=zohomail.com; s=zohoarc; b=KNtH71cMmKj/nRuaemSlL8CUECNSORmhiEpLK05eIJc8pFYW3rCLvEvmQL+yd1gKDbHKfmQOlZTGxbgN9TbWpIDVgxJLUj6JNLCjhzfuXlrCa0YS68idiHAwsgPIQlcTIKA47U/Y7w7qpBXDnjQLaVuTjU7T9n7uUBVWnGvxGbA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690712456; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=tocfpLYsw6PLEpP2kNWg2ALJixeOzbhyHMEfev18tsU=; b=TPz4KC0kXWEGdoGppL34079gaPrCdqD7fjpIpDS1EC5q2wN0/4KbQ89LfnaHbghwJWLbPjolI4b0vfmo5GnZxrqTf5jnMx5fkznvWsEsbm2KFh0VN+1dP7N9hHP7pJ5U+ePpWYV5WA6oFlPgVyYQXLMqAMV3tX6nEvhpqdi4o1o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1690712455991613.9680188682114; Sun, 30 Jul 2023 03:20:55 -0700 (PDT) Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-67-KRI-GwfDOMCVAvVFtxVgsg-1; Sun, 30 Jul 2023 06:20:47 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7CEA53802B8F; Sun, 30 Jul 2023 10:20:45 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A40A492CA6; Sun, 30 Jul 2023 10:20:45 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5637A1946594; Sun, 30 Jul 2023 10:20:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 490B319451D0 for ; Sun, 30 Jul 2023 10:20:42 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2B13E1454147; Sun, 30 Jul 2023 10:20:42 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 230E31454146 for ; Sun, 30 Jul 2023 10:20:42 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0744E185A78B for ; Sun, 30 Jul 2023 10:20:42 +0000 (UTC) Received: from mail-b.sr.ht (mail-b.sr.ht [173.195.146.151]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-336-EamPjdaaOcqkaRq6B9ahfw-1; Sun, 30 Jul 2023 06:20:39 -0400 Received: from git.sr.ht (unknown [173.195.146.142]) by mail-b.sr.ht (Postfix) with ESMTPSA id 3D6F711EF48 for ; Sun, 30 Jul 2023 10:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690712455; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=tocfpLYsw6PLEpP2kNWg2ALJixeOzbhyHMEfev18tsU=; b=CB8qMl4brx0w/cnt64g+BLwcBf1a+tcIdHPBNshD6RcXJY3CaX2knb58mZ5oSYJgftZ0/q 7fg6+DG7KmZeNFBvhoML4ovxIH5Srl4SAR7W+ke+L4jt4Iy7dzDNoyFD8FQ2b5GorlRjNS 2/PxoLNrB5DcKd4JI21q4Y9aDFhaJM4= X-MC-Unique: KRI-GwfDOMCVAvVFtxVgsg-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: EamPjdaaOcqkaRq6B9ahfw-1 From: ~hyman Date: Sat, 13 Aug 2022 11:06:27 +0800 Subject: [PATCH Libvirt 06/11] qemu_driver: Extend qemuDomainGetVcpus MIME-Version: 1.0 Message-ID: <169071243700.22823.6002973365882521706-6@git.sr.ht> In-Reply-To: <169071243700.22823.6002973365882521706-0@git.sr.ht> To: libvir-list@redhat.com X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ~hyman Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: git.sr.ht Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1690712456154100009 From: Hyman Huang(=E9=BB=84=E5=8B=87) Extend qemuDomainGetVcpus for getting dirty page rate upper limit info so 'virsh vcpuinfo' api can display it. Signed-off-by: Hyman Huang(=E9=BB=84=E5=8B=87) --- include/libvirt/libvirt-domain.h | 2 ++ src/qemu/qemu_driver.c | 55 ++++++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-dom= ain.h index df7deffaa9..4c63d0be7c 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -2395,6 +2395,8 @@ struct _virVcpuInfo { int state; /* value from virVcpuState */ unsigned long long cpuTime; /* CPU time used, in nanoseconds */ int cpu; /* real CPU number, or one of the values f= rom virVcpuHostCpuState */ + unsigned long long limit; /* virtual cpu dirty page rate upper limit= in MB/s */ + unsigned long long current; /* current virtual cpu dirty page rate in = MB/s */ }; =20 /** diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 61b992fc51..f7ff3b7098 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4599,6 +4599,57 @@ qemuDomainGetEmulatorPinInfo(virDomainPtr dom, return ret; } =20 +static int +qemuDomainGetVcpuDirtyLimit(virDomainObj *vm, + virVcpuInfoPtr info, + int maxinfo) +{ + qemuDomainObjPrivate *priv =3D vm->privateData; + qemuMonitorVcpuDirtyLimitInfo dirtylimit_info; + size_t cpuinfo_idx =3D 0; + size_t i; + int ret =3D -1; + + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VCPU_DIRTY_LIMIT)) + return 0; + + if (virDomainObjBeginJob(vm, VIR_JOB_MODIFY) < 0) + goto endjob; + + if (virDomainObjCheckActive(vm) < 0) + goto endjob; + + qemuDomainObjEnterMonitor(vm); + if (qemuMonitorQueryVcpuDirtyLimit(priv->mon, &dirtylimit_info) < 0) { + qemuDomainObjExitMonitor(vm); + goto endjob; + } + qemuDomainObjExitMonitor(vm); + + while (cpuinfo_idx < maxinfo) { + virVcpuInfoPtr vcpuinfo =3D info + cpuinfo_idx; + for (i =3D 0; i < dirtylimit_info.nvcpus && + i < virDomainDefGetVcpusMax(vm->def); i++) { + /* skip the offline virtual CPU */ + virDomainVcpuDef *vcpu =3D virDomainDefGetVcpu(vm->def, i); + if (!vcpu->online) + continue; + + /* match the index of virtual CPU */ + if (vcpuinfo->number =3D=3D dirtylimit_info.limits[i].idx) { + vcpuinfo->current =3D dirtylimit_info.limits[i].current; + vcpuinfo->limit =3D dirtylimit_info.limits[i].limit; + } + } + cpuinfo_idx++; + } + ret =3D 0; + + endjob: + virDomainObjEndJob(vm); + return ret; +} + static int qemuDomainGetVcpus(virDomainPtr dom, virVcpuInfoPtr info, @@ -4623,6 +4674,10 @@ qemuDomainGetVcpus(virDomainPtr dom, =20 ret =3D qemuDomainHelperGetVcpus(vm, info, NULL, NULL, maxinfo, cpumap= s, maplen); =20 + /* append dirty limit data to vcpu info */ + if (qemuDomainGetVcpuDirtyLimit(vm, info, maxinfo) < 0) + goto cleanup; + cleanup: virDomainObjEndAPI(&vm); return ret; --=20 2.38.5