From nobody Mon Feb 9 10:48:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1610358959; cv=none; d=zohomail.com; s=zohoarc; b=gQKe+2xhJ/B2INZVK3eVdkXHAHBKKf06ryZAIuBRsobOPOlxpYBLA3Jty3e4D5qEyaBDQVsbnz2xg6+ZjUKnxVMKSrJfbNGlIhOK34yJVo3d529Y6d4IvL/S+EzbhRhiiVPQH2+32FjuXY4SiCrNImlVnzO0etSBjm/wvHmf/Vs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610358959; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=D8tTWOMJzAFMP18MWzxGFfailzi01mIm9LoAbwENEzU=; b=bzTbhYV2DBQuJ1sINQvOHfrVHOihmfVM6m0ujMYmhHBczdrirr2CgBr1LKHsZZ0A2GuOxccUq1lMKUfgUiva4nTRUR7e86m2fnNjXj4Q5rGecRnHF55n1gQIssG/HSA/EWg+8zo3ucvx3gwBIyX53b3tENspLWVEY32q0rcoN5g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1610358959260132.53593040721285; Mon, 11 Jan 2021 01:55:59 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-m4IAilIKP5OtWEwHoM8sGw-1; Mon, 11 Jan 2021 04:55:55 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 860CF180A086; Mon, 11 Jan 2021 09:55:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 63C8E74449; Mon, 11 Jan 2021 09:55:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2B684180954D; Mon, 11 Jan 2021 09:55:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10B9tl0N014693 for ; Mon, 11 Jan 2021 04:55:48 -0500 Received: by smtp.corp.redhat.com (Postfix) id C529C2026D49; Mon, 11 Jan 2021 09:55:47 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C08132026D5D for ; Mon, 11 Jan 2021 09:55:44 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4C04A186E120 for ; Mon, 11 Jan 2021 09:55:44 +0000 (UTC) Received: from relay3.sw.ru (relay.sw.ru [185.231.240.75]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-YhJF9BEwOF2-qul8J4EM9A-1; Mon, 11 Jan 2021 04:55:41 -0500 Received: from [10.28.15.168] (helo=vz7.sw.ru.) by relay3.sw.ru with esmtp (Exim 4.94) (envelope-from ) id 1kytuD-00GBOE-JK for libvir-list@redhat.com; Mon, 11 Jan 2021 12:54:33 +0300 X-MC-Unique: m4IAilIKP5OtWEwHoM8sGw-1 X-MC-Unique: YhJF9BEwOF2-qul8J4EM9A-1 From: Nikolay Shirokovskiy To: libvir-list@redhat.com Subject: [PATCH 04/23] qemu: remove extra check for QEMU_BLOCK_IOTUNE_MAX Date: Mon, 11 Jan 2021 12:49:57 +0300 Message-Id: <1610358616-567804-5-git-send-email-nshirokovskiy@virtuozzo.com> In-Reply-To: <1610358616-567804-1-git-send-email-nshirokovskiy@virtuozzo.com> References: <1610358616-567804-1-git-send-email-nshirokovskiy@virtuozzo.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This is checked in below call to qemuValidateDomainBlkdeviotune now. Note t= hat qemuValidateDomainBlkdeviotune does not check *_max_length values as we do here. But I guess this is for good. I tried setting high _max_lengh values = and looks like their limits depend on *_max values and much less then 1000000000000000LL. Signed-off-by: Nikolay Shirokovskiy Reviewed-by: Peter Krempa --- src/qemu/qemu_driver.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7337464..984b45d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16121,13 +16121,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, for (i =3D 0; i < nparams; i++) { virTypedParameterPtr param =3D ¶ms[i]; =20 - if (param->value.ul > QEMU_BLOCK_IOTUNE_MAX) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, - _("block I/O throttle limit value must" - " be no more than %llu"), QEMU_BLOCK_IOTUNE_M= AX); - goto endjob; - } - SET_IOTUNE_FIELD(total_bytes_sec, BYTES, TOTAL_BYTES_SEC); SET_IOTUNE_FIELD(read_bytes_sec, BYTES, READ_BYTES_SEC); SET_IOTUNE_FIELD(write_bytes_sec, BYTES, WRITE_BYTES_SEC); --=20 1.8.3.1