From nobody Mon Feb 9 16:51:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1610358781; cv=none; d=zohomail.com; s=zohoarc; b=GrSN+Okcp6oZX9FCBuzMmw59cZmGMqdBDbrAeOdNG80xfHhnsLLRblq/rbYhdr9cH/qGBBzeNl0xzF3bbbvSQiMHjrPqvwWDtcF9Mb9nqGqRVi8EsdY7hLp0umr9FndSnuf9X8eL+RfxRipyAEdWttRrsYBSccmj+NqIYOOcW8o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610358781; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=rLDY/TH0TJyjcfWRPijBqX6a6LERPaGRPjsr8ceobY0=; b=E0jIbbrYnVrM3NefBLhQxUw4rqrOft0ZhpFlEAbIV5FMuoXBW3uQHuVN/7sDCLf8arNBCvBX0Pa+heP4QISRl8ylNtDHcLuETkDbfPoHuBpCAs2BmWOgYQNPNIm1RSCl2tsECbBC3PnfUOhzZFwDpcAh3477ueGqL9cKYyYLDrI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 161035878130167.90939923587189; Mon, 11 Jan 2021 01:53:01 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-329-ffolUScyPEON-uf-hfTzLg-1; Mon, 11 Jan 2021 04:52:58 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EE2208144E6; Mon, 11 Jan 2021 09:52:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C89A46A900; Mon, 11 Jan 2021 09:52:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 914D44BB7B; Mon, 11 Jan 2021 09:52:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10B9qniK014435 for ; Mon, 11 Jan 2021 04:52:49 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5667F2026D5D; Mon, 11 Jan 2021 09:52:49 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 51F4D2026D49 for ; Mon, 11 Jan 2021 09:52:46 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 28C488008A5 for ; Mon, 11 Jan 2021 09:52:46 +0000 (UTC) Received: from relay3.sw.ru (relay.sw.ru [185.231.240.75]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-545-OR-TWQBvNXayv_cRKwVvcQ-1; Mon, 11 Jan 2021 04:52:43 -0500 Received: from [10.28.15.168] (helo=vz7.sw.ru.) by relay3.sw.ru with esmtp (Exim 4.94) (envelope-from ) id 1kytrL-00GBOE-H3 for libvir-list@redhat.com; Mon, 11 Jan 2021 12:51:35 +0300 X-MC-Unique: ffolUScyPEON-uf-hfTzLg-1 X-MC-Unique: OR-TWQBvNXayv_cRKwVvcQ-1 From: Nikolay Shirokovskiy To: libvir-list@redhat.com Subject: [PATCH 01/23] qemu: pass supportGroupNameOption as expected Date: Mon, 11 Jan 2021 12:49:54 +0300 Message-Id: <1610358616-567804-2-git-send-email-nshirokovskiy@virtuozzo.com> In-Reply-To: <1610358616-567804-1-git-send-email-nshirokovskiy@virtuozzo.com> References: <1610358616-567804-1-git-send-email-nshirokovskiy@virtuozzo.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" supportGroupNameOption was originally passed before the below patch. To sol= ve the issue of that patch this change is not necessary and it make sense to pass supportGroupNameOption because of qemuMonitorSetBlockIoThrottle signature. With patch group_name is passed to qemu if disk in iotune group but group is not passed explicitly in parametes. For qemu it does not make a differen= ce. I'm preparing here for the next patch where another usage of supportGroupNameOption will gone and instead of deleting supportGroupNameOp= tion variable altogether I guess it is better to restore it's proper usage. commit e9d75343d4cf552575a3b305fa00a36ee71e9309 Author: Martin Kletzander Date: Tue Jan 24 15:50:00 2017 +0100 qemu: Only set group_name when actually requested Signed-off-by: Nikolay Shirokovskiy Reviewed-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 027617d..b7f22c2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16310,7 +16310,7 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, qemuDomainObjEnterMonitor(driver, vm); ret =3D qemuMonitorSetBlockIoThrottle(priv->mon, drivealias, q= devid, &info, supportMaxOptions, - set_fields & QEMU_BLOCK_IO= TUNE_SET_GROUP_NAME, + supportGroupNameOption, supportMaxLengthOptions); if (qemuDomainObjExitMonitor(driver, vm) < 0) ret =3D -1; --=20 1.8.3.1