From nobody Sun Feb 8 22:43:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1606911935; cv=none; d=zohomail.com; s=zohoarc; b=AFZcvdaM5mnG82Ctb1t3x0ANk2bUk5acZvvInHfqUbNnb7W8WMe/SsxFuDVdDFzbVipvAgaCBS5thYH2bYk7vZqzBcsNvwXGadtK+1ts/Iwn2HuzOV81gyLRPM+dTolW0ZH2qRxL6Rx0auf0EahjR4lrSu9nTvBBKzdADrPCuQ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606911935; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=bd8ddvhKrFc29ehIHhwGda6vyO7rONrfGuXhg9rsER8=; b=YAr1rcoRRNbjxbIDmh6hhHdoSPoGVPUtR8qyWJPeowK2aSMl4bHGJRud13yMw1Hk4upjrJwKPn83O+uhiGvxo9EiIZXXF4mhLMmvYERheJobgCTNyB9ZW8/IhXN6IfLzMj1e8uDCMNmymJTB1L23KBDXtpZdru5CzSkFMAhndmM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1606911935862395.44180318089; Wed, 2 Dec 2020 04:25:35 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-164-Od4r2AqwOeuiJblU34G7Lg-1; Wed, 02 Dec 2020 07:25:31 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 781161006C85; Wed, 2 Dec 2020 12:25:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 551C460C17; Wed, 2 Dec 2020 12:25:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E2D021809CA2; Wed, 2 Dec 2020 12:25:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B2CPOLi001235 for ; Wed, 2 Dec 2020 07:25:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id 75B5C2026D3D; Wed, 2 Dec 2020 12:25:24 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 718692026D3A for ; Wed, 2 Dec 2020 12:25:21 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 197A4185A7BC for ; Wed, 2 Dec 2020 12:25:21 +0000 (UTC) Received: from relay3.sw.ru (relay.sw.ru [185.231.240.75]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-56-l_CYI6l4MLuO44_K_IFzfg-1; Wed, 02 Dec 2020 07:25:18 -0500 Received: from [10.28.15.159] (helo=vz7.sw.ru) by relay3.sw.ru with esmtp (Exim 4.94) (envelope-from ) id 1kkRBx-00BQYB-V4 for libvir-list@redhat.com; Wed, 02 Dec 2020 15:25:06 +0300 X-MC-Unique: Od4r2AqwOeuiJblU34G7Lg-1 X-MC-Unique: l_CYI6l4MLuO44_K_IFzfg-1 From: Nikolay Shirokovskiy To: libvir-list@redhat.com Subject: [PATCH v2 1/2] qemu: support append param on live attaching file chardev Date: Wed, 2 Dec 2020 15:25:09 +0300 Message-Id: <1606911910-109269-2-git-send-email-nshirokovskiy@virtuozzo.com> In-Reply-To: <1606911910-109269-1-git-send-email-nshirokovskiy@virtuozzo.com> References: <1606911910-109269-1-git-send-email-nshirokovskiy@virtuozzo.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently it is simply ignored. Signed-off-by: Nikolay Shirokovskiy Reviewed-by: Daniel Henrique Barboza --- src/qemu/qemu_monitor_json.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 47ee1ff..ff03a5a 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7497,6 +7497,10 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrI= D, backend_type =3D "file"; if (virJSONValueObjectAppendString(data, "out", chr->data.file.pat= h) < 0) goto cleanup; + if (virJSONValueObjectAdd(data, + "T:append", chr->data.file.append, + NULL) < 0) + goto cleanup; break; =20 case VIR_DOMAIN_CHR_TYPE_DEV: --=20 1.8.3.1 From nobody Sun Feb 8 22:43:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1606911935; cv=none; d=zohomail.com; s=zohoarc; b=Si9C80pgh24PKcwPAFuBigUhnOdO6lMSIQnZMDkOMAHeDNkxaoQ8XfOrINYKdndtH/rF02OXQhbu4tG4qgSmu7B2jj7nD+I0CAmoBGY8zN9uuTXeR6r7A87REUh53qsXAG2QC9yggqG3knSOdx6QIXonz7PadIJhRhoXSKJNQaI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606911935; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=nHpPTLlrm8r0MP6pLsGCG8WPkRKcsxS+EwhTwmrivx4=; b=ebRW2DXTXfD4hfl6AdH1cULhVIM/G0r3lRkiKHCdoRsf9M9EhyeoJrhEAXkLII7C4/8J7k76Tg3U9n/VuxV4irdWeKX92lMelJkngT4GdC0Sj4wssMxMeI4OF8ZHsrQQNrfhl4yWiBdIOzv7SOGJehq5lnDiDoPbP+mnYwtBLlM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1606911935061334.6303539865869; Wed, 2 Dec 2020 04:25:35 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-UrCNXLeBP_GZt6YZrIieZg-1; Wed, 02 Dec 2020 07:25:31 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 045EC85818C; Wed, 2 Dec 2020 12:25:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE09C5C1B4; Wed, 2 Dec 2020 12:25:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 353D3180954D; Wed, 2 Dec 2020 12:25:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B2CPNSE001230 for ; Wed, 2 Dec 2020 07:25:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id B11C4ADF86; Wed, 2 Dec 2020 12:25:23 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC1E0AC97F for ; Wed, 2 Dec 2020 12:25:21 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A4A3101A53F for ; Wed, 2 Dec 2020 12:25:21 +0000 (UTC) Received: from relay3.sw.ru (relay.sw.ru [185.231.240.75]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128--OL-IXpRM6CIUtk7Js_49w-1; Wed, 02 Dec 2020 07:25:18 -0500 Received: from [10.28.15.159] (helo=vz7.sw.ru) by relay3.sw.ru with esmtp (Exim 4.94) (envelope-from ) id 1kkRBy-00BQYB-1r for libvir-list@redhat.com; Wed, 02 Dec 2020 15:25:06 +0300 X-MC-Unique: UrCNXLeBP_GZt6YZrIieZg-1 X-MC-Unique: -OL-IXpRM6CIUtk7Js_49w-1 From: Nikolay Shirokovskiy To: libvir-list@redhat.com Subject: [PATCH v2 2/2] qemu: support logfile on live attaching chardev Date: Wed, 2 Dec 2020 15:25:10 +0300 Message-Id: <1606911910-109269-3-git-send-email-nshirokovskiy@virtuozzo.com> In-Reply-To: <1606911910-109269-1-git-send-email-nshirokovskiy@virtuozzo.com> References: <1606911910-109269-1-git-send-email-nshirokovskiy@virtuozzo.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently it is simply ignored. Signed-off-by: Nikolay Shirokovskiy Reviewed-by: Daniel Henrique Barboza --- src/qemu/qemu_monitor_json.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index ff03a5a..0745717 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7611,6 +7611,13 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrI= D, goto cleanup; } =20 + if (chr->logfile && + virJSONValueObjectAdd(data, + "s:logfile", chr->logfile, + "T:logappend", chr->logappend, + NULL) < 0) + goto cleanup; + if (virJSONValueObjectAppendString(backend, "type", backend_type) < 0 = || virJSONValueObjectAppend(backend, "data", data) < 0) goto cleanup; --=20 1.8.3.1