From nobody Mon Feb 9 11:30:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1606910149; cv=none; d=zohomail.com; s=zohoarc; b=e4ST6Ko0nHOw1mugldaTaeNZt5eO+6otLUCgrkGAqZO3IQVcGBge35WCtXYq2/37fp8ptAO6L5kIkDk5VY/xpbWykXb8+RGnbnYSHQ0XGRgmz3FqFKu57ZZtJUfUKsKBNV/pWBIwct5diYNWlA0tCjtJNSmUk3JdmcHtSV1OW9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606910149; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=gNMQmhqqDa76bDODM2gipOFnnXX+63Xn1OXN35zX4v0=; b=N7rXm8ziWWMagflWw1ak/9PsHxN+NS6hURYoTC9QtTbKq5+1sB+zvfCdGXImiBy8D7QAlukmcGFYxh7YJDqCZCrKWqGJuAfIbdgtxdDK7/TBKB0lpp8MMI/2ayexc+6lPPgeF3ngk84uvBBrO7aUH08H5fKYwv2mxf7HD2m/aQo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1606910149780942.4703247979758; Wed, 2 Dec 2020 03:55:49 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-hMdREW-BOFyiWhFRPoUL3Q-1; Wed, 02 Dec 2020 06:55:46 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E9539805BE6; Wed, 2 Dec 2020 11:55:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4E145D973; Wed, 2 Dec 2020 11:55:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 873611809CA0; Wed, 2 Dec 2020 11:55:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B2BtSYw022200 for ; Wed, 2 Dec 2020 06:55:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id 966202166B33; Wed, 2 Dec 2020 11:55:28 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 92A352166B2F for ; Wed, 2 Dec 2020 11:55:25 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8048C101A53F for ; Wed, 2 Dec 2020 11:55:25 +0000 (UTC) Received: from relay3.sw.ru (relay.sw.ru [185.231.240.75]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-5hdFffdqOE-TSDgQeTNSqw-1; Wed, 02 Dec 2020 06:55:23 -0500 Received: from [10.28.15.159] (helo=vz7.sw.ru) by relay3.sw.ru with esmtp (Exim 4.94) (envelope-from ) id 1kkQiz-00BQJv-Kc for libvir-list@redhat.com; Wed, 02 Dec 2020 14:55:09 +0300 X-MC-Unique: hMdREW-BOFyiWhFRPoUL3Q-1 X-MC-Unique: 5hdFffdqOE-TSDgQeTNSqw-1 From: Nikolay Shirokovskiy To: libvir-list@redhat.com Subject: [PATCH 2/3] qemu: support append param on live attaching file chardev Date: Wed, 2 Dec 2020 14:55:08 +0300 Message-Id: <1606910109-88230-3-git-send-email-nshirokovskiy@virtuozzo.com> In-Reply-To: <1606910109-88230-1-git-send-email-nshirokovskiy@virtuozzo.com> References: <1606910109-88230-1-git-send-email-nshirokovskiy@virtuozzo.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently it is simply ignored. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_monitor_json.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 47ee1ff..df95a4a 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7497,6 +7497,9 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID, backend_type =3D "file"; if (virJSONValueObjectAppendString(data, "out", chr->data.file.pat= h) < 0) goto cleanup; + if (virJSONValueObjectAppendBooleanTristate(data, "append", + chr->data.file.append)= < 0) + goto cleanup; break; =20 case VIR_DOMAIN_CHR_TYPE_DEV: --=20 1.8.3.1