From nobody Sun Feb 8 21:20:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1606910141; cv=none; d=zohomail.com; s=zohoarc; b=bkkc6FnwfubCpSXm15VM+h83Xs0xgCSl3pkCREFQq9/jFg2SGBjeoWk3TmCiPpMHQ6+HjB1L1M2eu3Rwamq3SYbWbvSv9KMVrdAbpJkpArfMOGbJYuntxJ0kg3tVH2pDWWAsQnXnePpHdrlqXPbG7vY7GO5V/RrtCTLrSG/HTZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606910141; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=qiXv+8wOrD064vUtydwiIrFzrKiLRJC1m4xSiqR9voI=; b=U+fCv2/PlPmBhjY854u9t0yfJawDrHXjN4ZCxab1V01AYWKxwW8PrGTgZTjckTAIBvzI2WauuCfkdoyPycAWiwNsHxiyizTQyTab5t8TAFUVJvUXSmzNTsUt1Z5SC6mPeNgbHP6qpR2gluFL3oGTnwI/SFqmJU6+h5i8ZoZQLSM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1606910141925968.6597746397995; Wed, 2 Dec 2020 03:55:41 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-544-TE8heq-dNj6NLDYzW94RmQ-1; Wed, 02 Dec 2020 06:55:38 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E3A2100C605; Wed, 2 Dec 2020 11:55:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D7D615D75F; Wed, 2 Dec 2020 11:55:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 72C52180954D; Wed, 2 Dec 2020 11:55:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B2BtSOL022189 for ; Wed, 2 Dec 2020 06:55:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id EFE382026D25; Wed, 2 Dec 2020 11:55:27 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E9F112026D12 for ; Wed, 2 Dec 2020 11:55:25 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6BA4D811E84 for ; Wed, 2 Dec 2020 11:55:25 +0000 (UTC) Received: from relay3.sw.ru (relay.sw.ru [185.231.240.75]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-UiH2I9nPN-2DhpkCLMEuRw-1; Wed, 02 Dec 2020 06:55:23 -0500 Received: from [10.28.15.159] (helo=vz7.sw.ru) by relay3.sw.ru with esmtp (Exim 4.94) (envelope-from ) id 1kkQiz-00BQJv-IA for libvir-list@redhat.com; Wed, 02 Dec 2020 14:55:09 +0300 X-MC-Unique: TE8heq-dNj6NLDYzW94RmQ-1 X-MC-Unique: UiH2I9nPN-2DhpkCLMEuRw-1 From: Nikolay Shirokovskiy To: libvir-list@redhat.com Subject: [PATCH 1/3] util: add virJSONValueObjectAppendBooleanTristate Date: Wed, 2 Dec 2020 14:55:07 +0300 Message-Id: <1606910109-88230-2-git-send-email-nshirokovskiy@virtuozzo.com> In-Reply-To: <1606910109-88230-1-git-send-email-nshirokovskiy@virtuozzo.com> References: <1606910109-88230-1-git-send-email-nshirokovskiy@virtuozzo.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It appends boolean from virTristateBool/virTristateSwitch value. Signed-off-by: Nikolay Shirokovskiy --- src/libvirt_private.syms | 1 + src/util/virjson.c | 25 +++++++++++++++++++++++++ src/util/virjson.h | 1 + 3 files changed, 27 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 179dcec..f7f133c 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2386,6 +2386,7 @@ virJSONValueObjectAdd; virJSONValueObjectAddVArgs; virJSONValueObjectAppend; virJSONValueObjectAppendBoolean; +virJSONValueObjectAppendBooleanTristate; virJSONValueObjectAppendNull; virJSONValueObjectAppendNumberDouble; virJSONValueObjectAppendNumberInt; diff --git a/src/util/virjson.c b/src/util/virjson.c index 4f92464..78ddc4b 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -767,6 +767,31 @@ virJSONValueObjectAppendBoolean(virJSONValuePtr object, =20 =20 int +virJSONValueObjectAppendBooleanTristate(virJSONValuePtr object, + const char *key, + int value) +{ + g_autoptr(virJSONValue) jvalue =3D NULL; + int v; + + if (value =3D=3D VIR_TRISTATE_SWITCH_ABSENT) + return 0; + + if (value =3D=3D VIR_TRISTATE_SWITCH_OFF) + v =3D 0; + else + v =3D 1; + + jvalue =3D virJSONValueNewBoolean(v); + if (virJSONValueObjectAppend(object, key, jvalue) < 0) + return -1; + jvalue =3D NULL; + + return 0; +} + + +int virJSONValueObjectAppendNull(virJSONValuePtr object, const char *key) { diff --git a/src/util/virjson.h b/src/util/virjson.h index 4dc7ed1..aa4ae82 100644 --- a/src/util/virjson.h +++ b/src/util/virjson.h @@ -137,6 +137,7 @@ int virJSONValueObjectAppendNumberLong(virJSONValuePtr = object, const char *key, int virJSONValueObjectAppendNumberUlong(virJSONValuePtr object, const char= *key, unsigned long long number); int virJSONValueObjectAppendNumberDouble(virJSONValuePtr object, const cha= r *key, double number); int virJSONValueObjectAppendBoolean(virJSONValuePtr object, const char *ke= y, int boolean); +int virJSONValueObjectAppendBooleanTristate(virJSONValuePtr object, const = char *key, int value); int virJSONValueObjectAppendNull(virJSONValuePtr object, const char *key); =20 int virJSONValueObjectRemoveKey(virJSONValuePtr object, const char *key, --=20 1.8.3.1 From nobody Sun Feb 8 21:20:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1606910149; cv=none; d=zohomail.com; s=zohoarc; b=e4ST6Ko0nHOw1mugldaTaeNZt5eO+6otLUCgrkGAqZO3IQVcGBge35WCtXYq2/37fp8ptAO6L5kIkDk5VY/xpbWykXb8+RGnbnYSHQ0XGRgmz3FqFKu57ZZtJUfUKsKBNV/pWBIwct5diYNWlA0tCjtJNSmUk3JdmcHtSV1OW9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606910149; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=gNMQmhqqDa76bDODM2gipOFnnXX+63Xn1OXN35zX4v0=; b=N7rXm8ziWWMagflWw1ak/9PsHxN+NS6hURYoTC9QtTbKq5+1sB+zvfCdGXImiBy8D7QAlukmcGFYxh7YJDqCZCrKWqGJuAfIbdgtxdDK7/TBKB0lpp8MMI/2ayexc+6lPPgeF3ngk84uvBBrO7aUH08H5fKYwv2mxf7HD2m/aQo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1606910149780942.4703247979758; Wed, 2 Dec 2020 03:55:49 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-hMdREW-BOFyiWhFRPoUL3Q-1; Wed, 02 Dec 2020 06:55:46 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E9539805BE6; Wed, 2 Dec 2020 11:55:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4E145D973; Wed, 2 Dec 2020 11:55:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 873611809CA0; Wed, 2 Dec 2020 11:55:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B2BtSYw022200 for ; Wed, 2 Dec 2020 06:55:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id 966202166B33; Wed, 2 Dec 2020 11:55:28 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 92A352166B2F for ; Wed, 2 Dec 2020 11:55:25 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8048C101A53F for ; Wed, 2 Dec 2020 11:55:25 +0000 (UTC) Received: from relay3.sw.ru (relay.sw.ru [185.231.240.75]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-5hdFffdqOE-TSDgQeTNSqw-1; Wed, 02 Dec 2020 06:55:23 -0500 Received: from [10.28.15.159] (helo=vz7.sw.ru) by relay3.sw.ru with esmtp (Exim 4.94) (envelope-from ) id 1kkQiz-00BQJv-Kc for libvir-list@redhat.com; Wed, 02 Dec 2020 14:55:09 +0300 X-MC-Unique: hMdREW-BOFyiWhFRPoUL3Q-1 X-MC-Unique: 5hdFffdqOE-TSDgQeTNSqw-1 From: Nikolay Shirokovskiy To: libvir-list@redhat.com Subject: [PATCH 2/3] qemu: support append param on live attaching file chardev Date: Wed, 2 Dec 2020 14:55:08 +0300 Message-Id: <1606910109-88230-3-git-send-email-nshirokovskiy@virtuozzo.com> In-Reply-To: <1606910109-88230-1-git-send-email-nshirokovskiy@virtuozzo.com> References: <1606910109-88230-1-git-send-email-nshirokovskiy@virtuozzo.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently it is simply ignored. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_monitor_json.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 47ee1ff..df95a4a 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7497,6 +7497,9 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID, backend_type =3D "file"; if (virJSONValueObjectAppendString(data, "out", chr->data.file.pat= h) < 0) goto cleanup; + if (virJSONValueObjectAppendBooleanTristate(data, "append", + chr->data.file.append)= < 0) + goto cleanup; break; =20 case VIR_DOMAIN_CHR_TYPE_DEV: --=20 1.8.3.1 From nobody Sun Feb 8 21:20:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1606910147; cv=none; d=zohomail.com; s=zohoarc; b=BPgq/vI4AfjghAsOw9kNbrwAPidp+Xj0km5DBboVJlK6QfHtf62i1Gy79/G6X/MKhJWW9XLij6vqRjhJQE6CeVM+ADsS3R2Ay2YHDuAbRVH0hhY2o4wfbX5fahDuORmXDtboNXkkxjAANaJ+NLgh9Mv8MMxwnnUpjAtZB+wBpa4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606910147; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=Olci4tNTiKxDw6xROjPNVqy6dDe8jp0YoUIzL2b05OI=; b=OkYDkw9DMZEsDBNJbzkkdYyBWD5lSmh4R/Cn2sGRlLwf0aLrS4yIUKrxB+tywU1ef5cnfrwOA8I71jDI3U8i+Dycskj3CcxVvGT+QW+LqbI7hjjVUNSCBogAL82E78Qgc4/zfqgo787F0h3or2/piCUbbOrtBNEgHu/48HBz3pI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1606910147703774.144464824683; Wed, 2 Dec 2020 03:55:47 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-54-WhI1p7OdNVC_pPZNMGT20A-1; Wed, 02 Dec 2020 06:55:44 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 28461185E49F; Wed, 2 Dec 2020 11:55:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 031EB5C3E4; Wed, 2 Dec 2020 11:55:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BE2B74E58F; Wed, 2 Dec 2020 11:55:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B2BtSut022197 for ; Wed, 2 Dec 2020 06:55:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id 964062166B32; Wed, 2 Dec 2020 11:55:28 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 916E72166B2C for ; Wed, 2 Dec 2020 11:55:25 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F5CF800B3A for ; Wed, 2 Dec 2020 11:55:25 +0000 (UTC) Received: from relay3.sw.ru (relay.sw.ru [185.231.240.75]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-410-QyQAjbxUMQSZSyXOTApk4A-1; Wed, 02 Dec 2020 06:55:23 -0500 Received: from [10.28.15.159] (helo=vz7.sw.ru) by relay3.sw.ru with esmtp (Exim 4.94) (envelope-from ) id 1kkQiz-00BQJv-N0 for libvir-list@redhat.com; Wed, 02 Dec 2020 14:55:09 +0300 X-MC-Unique: WhI1p7OdNVC_pPZNMGT20A-1 X-MC-Unique: QyQAjbxUMQSZSyXOTApk4A-1 From: Nikolay Shirokovskiy To: libvir-list@redhat.com Subject: [PATCH 3/3] qemu: support logfile on live attaching chardev Date: Wed, 2 Dec 2020 14:55:09 +0300 Message-Id: <1606910109-88230-4-git-send-email-nshirokovskiy@virtuozzo.com> In-Reply-To: <1606910109-88230-1-git-send-email-nshirokovskiy@virtuozzo.com> References: <1606910109-88230-1-git-send-email-nshirokovskiy@virtuozzo.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently it is simply ignored. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_monitor_json.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index df95a4a..6e96232 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7610,6 +7610,15 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrI= D, goto cleanup; } =20 + if (chr->logfile) { + if (virJSONValueObjectAppendString(data, "logfile", + chr->logfile) < 0) + goto cleanup; + if (virJSONValueObjectAppendBooleanTristate(data, "logappend", + chr->logappend) < 0) + goto cleanup; + } + if (virJSONValueObjectAppendString(backend, "type", backend_type) < 0 = || virJSONValueObjectAppend(backend, "data", data) < 0) goto cleanup; --=20 1.8.3.1