From nobody Tue Dec 16 16:41:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1740042301513901.7069001153897; Thu, 20 Feb 2025 01:05:01 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 797691F27; Thu, 20 Feb 2025 04:05:00 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 462941DD4; Thu, 20 Feb 2025 04:02:12 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 5A9BB1E55; Thu, 20 Feb 2025 04:02:04 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C7F201DC8 for ; Thu, 20 Feb 2025 04:01:51 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-XzGI-TdPNQKYDlzKQF6rkA-1; Thu, 20 Feb 2025 04:01:49 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 324501800991 for ; Thu, 20 Feb 2025 09:01:49 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.26]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 50F7719412A4 for ; Thu, 20 Feb 2025 09:01:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740042111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M1KxUhKXj4e6rwfJF+ZieWe2W9/RoB4kft0ha4zflOc=; b=SgoQEz/6VJEe8zdJ1wcRDzmu9yIrJXP8HPWsH9hDC3j6lff5pyjzVl9Vwkn7RuMTEMj1bl b1Nz0TC/zB6QXFvOGIPtD2GtuCDzRNuT9WBxKnq70eQDfealDsAPwAA+07ksQ9nOLQd2kJ wDLCpteHtf2+Q56HBlyAlWOZwrQU9vg= X-MC-Unique: XzGI-TdPNQKYDlzKQF6rkA-1 X-Mimecast-MFC-AGG-ID: XzGI-TdPNQKYDlzKQF6rkA_1740042109 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 08/21] virBitmapFormat: Clarify returned values Date: Thu, 20 Feb 2025 10:01:21 +0100 Message-ID: <15f478f87dd4caea604659259aba3ab029322a94.1740041997.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HeL5dPJPeHN8OsNQfxTHveO7U65dzxnSxHzf9lEyotM_1740042109 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BJCEESVNO5WAZ5CWERWMIMREGIISL7XM X-Message-ID-Hash: BJCEESVNO5WAZ5CWERWMIMREGIISL7XM X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1740042302972019100 Content-Type: text/plain; charset="utf-8" NULL can't be returned; don't mention it in the docs. Avoid extra cofusing variable when returning copy of empty string. Signed-off-by: Peter Krempa --- src/util/virbitmap.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 138c1ac5af..e42f5b872c 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -327,8 +327,8 @@ virBitmapToString(virBitmap *bitmap) * * If bitmap is NULL or it has no bits set, an empty string is returned. * - * Returns the string on success or NULL otherwise. Caller should call - * VIR_FREE to free the string. + * Returns the formatted string. Caller is responsible for freeing the ret= urned + * string. */ char * virBitmapFormat(virBitmap *bitmap) @@ -337,11 +337,8 @@ virBitmapFormat(virBitmap *bitmap) bool first =3D true; int start, cur, prev; - if (!bitmap || (cur =3D virBitmapNextSetBit(bitmap, -1)) < 0) { - char *ret; - ret =3D g_strdup(""); - return ret; - } + if (!bitmap || (cur =3D virBitmapNextSetBit(bitmap, -1)) < 0) + return g_strdup(""); start =3D prev =3D cur; while (prev >=3D 0) { --=20 2.48.1