From nobody Mon Feb 9 16:32:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=126.com ARC-Seal: i=1; a=rsa-sha256; t=1590453692; cv=none; d=zohomail.com; s=zohoarc; b=WTMk7lV3T4U0NQjLl+Spet1k0A1YV/23T8O4/Xw03Jkwv3JcgtB/rfP/2iqNv/DXF2Ai4be9F2Im4ioSvO8x35L7tmCowWm9nCHRcUxvFeE0t1O9b4b72gye3kJAFhZTJtNxnqSg7dHq9pnk3IbEjTBi84Hza+a6ie73eArx7yg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590453692; h=Content-Type:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=Zuyi3rPJyq9cDX8IhD+EQRcK0vJVockt8tJaEg5/Qew=; b=arO7XNBUCnjYyBWJmrtNnzJP5Y8Ybms10JL0NhQJajPAAKMRNfaxKIli9Luv86DP3/b8oJtA3DwJMjoBxf+vPU9SjACYXE/Psy3+tzOdcIRORc5hSvphMU8JEa1LyKIW4UfKLZTmMJzs/7JXL25uoPDNwB6EB6pVIplNEhRJDwM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1590453692833697.6157984041254; Mon, 25 May 2020 17:41:32 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-CjhMSAfbPQ2p9jI4yoqpRw-1; Mon, 25 May 2020 20:41:28 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 88847107ACCD; Tue, 26 May 2020 00:41:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 167B71001268; Tue, 26 May 2020 00:41:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C156D54D31; Tue, 26 May 2020 00:41:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04Q0fF6h020682 for ; Mon, 25 May 2020 20:41:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6F18642AD4; Tue, 26 May 2020 00:41:15 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AE8C49C3C for ; Tue, 26 May 2020 00:41:13 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B00D780CDBC for ; Tue, 26 May 2020 00:41:13 +0000 (UTC) Received: from mail-m964.mail.126.com (mail-m964.mail.126.com [123.126.96.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-DrYPFTgbP_2keRffH5Y_Eg-1; Mon, 25 May 2020 20:41:11 -0400 Received: from bogon.localdomain (unknown [112.80.215.163]) by smtp9 (Coremail) with SMTP id NeRpCgAnBkeeZcxeQ3o2Pg--.86S4; Tue, 26 May 2020 08:41:08 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590453691; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:content-type:content-type: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Zuyi3rPJyq9cDX8IhD+EQRcK0vJVockt8tJaEg5/Qew=; b=LncVMJTmWMFDB7AqbtDBwG7snnPo0wrSM/xMiPewkBsrvne5/XDdiLfucTDzWI+J2fo67c C8Gi3lCX+D3PiHYoUq0QZR8W3hSY2DuuTeYAi2zCNZqB2fuCNHj0VJPI9P/s+vAmeaF3bh bf3un/LDgb/7/0qezGHFz2V1prWnHgE= X-MC-Unique: CjhMSAfbPQ2p9jI4yoqpRw-1 X-MC-Unique: DrYPFTgbP_2keRffH5Y_Eg-1 From: Chen Hanxiao To: libvir-list@redhat.com Subject: [PATCH v2.1 2/3] downscript: add support for booting and hotplug interface Date: Mon, 25 May 2020 20:41:00 -0400 Message-Id: <1590453661-1791-3-git-send-email-chen_han_xiao@126.com> In-Reply-To: <1590453661-1791-1-git-send-email-chen_han_xiao@126.com> References: <1590453661-1791-1-git-send-email-chen_han_xiao@126.com> X-CM-TRANSID: NeRpCgAnBkeeZcxeQ3o2Pg--.86S4 X-Coremail-Antispam: 1Uf129KBjvJXoW3XFW7Ar48Jr1rWrW3Cr18uFg_yoW3Aw1xp3 WDA3Z5KF40qr47ZanY9a1UZFyfGFWv9rnrWa1IvryYg3W7t3W8Wr13Kry5tFyUArWrA34S ya4kArWYkrnrCaUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jcNVDUUUUU= X-Originating-IP: [112.80.215.163] X-CM-SenderInfo: xfkh0spkdqs5xldrqiyswou0bp/1tbiaAkwrlpEArZC1gAAsB X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Support downscript for booting vm, and hotunplug interface device. Signed-off-by: Chen Hanxiao --- src/qemu/qemu_extdevice.c | 4 ++ src/qemu/qemu_hotplug.c | 3 ++ tests/qemuxml2argvdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmloutdata/downscript.xml | 60 +++++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 5 files changed, 128 insertions(+) create mode 100644 tests/qemuxml2argvdata/downscript.xml create mode 100644 tests/qemuxml2xmloutdata/downscript.xml diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c index 2096272761..4962521de4 100644 --- a/src/qemu/qemu_extdevice.c +++ b/src/qemu/qemu_extdevice.c @@ -213,6 +213,7 @@ qemuExtDevicesStop(virQEMUDriverPtr driver, virDomainObjPtr vm) { virDomainDefPtr def =3D vm->def; + virDomainNetType actualType; size_t i; =20 if (qemuExtDevicesInitPaths(driver, def) < 0) @@ -230,10 +231,13 @@ qemuExtDevicesStop(virQEMUDriverPtr driver, =20 for (i =3D 0; i < def->nnets; i++) { virDomainNetDefPtr net =3D def->nets[i]; + actualType =3D virDomainNetGetActualType(net); qemuSlirpPtr slirp =3D QEMU_DOMAIN_NETWORK_PRIVATE(net)->slirp; =20 if (slirp) qemuSlirpStop(slirp, vm, driver, net); + if (actualType =3D=3D VIR_DOMAIN_NET_TYPE_ETHERNET && net->downscr= ipt) + virNetDevRunEthernetScript(net->ifname, net->downscript); } =20 for (i =3D 0; i < def->nfss; i++) { diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 5608566d69..f94f518f4d 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -4663,6 +4663,9 @@ qemuDomainRemoveNetDevice(virQEMUDriverPtr driver, virDomainNetReleaseActualDevice(conn, vm->def, net); else VIR_WARN("Unable to release network device '%s'", NULLSTR(net-= >ifname)); + } else if (net->type =3D=3D VIR_DOMAIN_NET_TYPE_ETHERNET) { + if (net->script) + virNetDevRunEthernetScript(net->ifname, net->downscript); } virDomainNetDefFree(net); return 0; diff --git a/tests/qemuxml2argvdata/downscript.xml b/tests/qemuxml2argvdata= /downscript.xml new file mode 100644 index 0000000000..4d0fb1beab --- /dev/null +++ b/tests/qemuxml2argvdata/downscript.xml @@ -0,0 +1,60 @@ + + QEMUGuest1 + c7a5fdbd-edaf-9455-926a-d65c16db1809 + 219136 + 219136 + 1 + + hvm + + + + qemu64 + + + destroy + restart + destroy + + /usr/bin/qemu-system-x86_64 + + + + +
+ + +
+ + +
+ + + +
+ + + + +
+ + + + + +
+ + + +